Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Thu, 23 Jul 2020 18:56:25 +0200
From:   Maxime Ripard <maxime@cerno.tech>
To:     Daniel Lezcano <daniel.lezcano@linaro.org>
Cc:     Frank Lee <tiny.windzz@gmail.com>,
        Frank Lee <frank@allwinnertech.com>,
        Vasily Khoruzhick <anarsoul@gmail.com>,
        Zhang Rui <rui.zhang@intel.com>,
        Amit Kucheria <amit.kucheria@verdurent.com>,
        Chen-Yu Tsai <wens@csie.org>,
        Linux PM <linux-pm@vger.kernel.org>,
        Linux ARM <linux-arm-kernel@lists.infradead.org>,
        Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
        =?utf-8?B?6buE54OB55Sf?= <huangshuosheng@allwinnertech.com>,
        liyong@allwinnertech.com
Subject: Re: [PATCH v4 08/16] thermal: sun8i: add TEMP_CALIB_MASK for
 calibration data in sun50i_h6_ths_calibrate
Message-ID: <20200723165625.zo5d4sv27y3dtcbb@gilmour.lan>
References: <cover.1594708863.git.frank@allwinnertech.com>
 <b8761e036b25f20873534e5f8d10b37b5d2ce72c.1594708864.git.frank@allwinnertech.com>
 <4771acd6-ecd3-b8e1-8605-75d78720b1d3@linaro.org>
 <CAEExFWv9_1kec_b+t+nnvT3cziXzmVa8GzJT3pQAZiCf4KA0ig@mail.gmail.com>
 <836e1b23-1c75-57fe-6e45-f7141272071c@linaro.org>
 <CAEExFWsJBizFArd+9Mh6D=o6rvD7GLPZ-1pNFzTvBiE+uKwVhQ@mail.gmail.com>
 <c1491845-ebd0-27d2-cf50-a8c5847869ab@linaro.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable
In-Reply-To: <c1491845-ebd0-27d2-cf50-a8c5847869ab@linaro.org>
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Mon, Jul 20, 2020 at 12:38:10PM +0200, Daniel Lezcano wrote:
> On 20/07/2020 11:27, Frank Lee wrote:
> > HI,
> > On Fri, Jul 17, 2020 at 3:56 PM Daniel Lezcano
> > <daniel.lezcano@linaro.org> wrote:
> >>
> >> On 17/07/2020 09:35, Frank Lee wrote:
> >>> On Fri, Jul 17, 2020 at 12:26 PM Daniel Lezcano
> >>> <daniel.lezcano@linaro.org> wrote:
> >>>>
> >>>> On 14/07/2020 09:13, Frank Lee wrote:
> >>>>> From: Yangtao Li <frank@allwinnertech.com>
> >>>>>
> >>>>> For sun50i_h6_ths_calibrate(), the data read from nvmem needs a rou=
nd of
> >>>>> calculation. On the other hand, the newer SOC may store other data =
in
> >>>>> the space other than 12bit sensor data. Add mask operation to read =
data
> >>>>> to avoid conversion error.
> >>>>>
> >>>>> Signed-off-by: Yangtao Li <frank@allwinnertech.com>
> >>>>> Reviewed-by: Yangtao Li <tiny.windzz@gmail.com>
> >>>>
> >>>> Can you clarify these SoB ?
> >>>
> >>> Previously I used 'Signed-off-by: Yangtao Li <tiny.windzz@gmail.com>',
> >>> maybe this should be removed directly?
> >>>
> >>>>
> >>>> Frank Lee=3D=3DYangtao Li=3D=3Dfrank@allwinnertech.com=3D=3Dtiny.win=
dzz@gmail.com ?
> >>>>
> >>>
> >>> Yeah.
> >>
> >> You are not supposed to add reviewed-by yourself. Please remove it.
> >=20
> > Should I resend the entire series or just the thermal patch?
> > What about those that have been applied.
>=20
> I can not speak on behalf of other maintainers.
>=20
> The simplest would be to ask them directly.
>=20
> If you want to go forward with the thermal changes, you can send them
> separately but Maxim's Ack will be needed anyway.

Given that I had a few other comments on the other patches, I guess you
can resend the whole series, it will be simpler to track down.

Maxime