Received: by 2002:a25:e74b:0:0:0:0:0 with SMTP id e72csp1557006ybh; Thu, 23 Jul 2020 11:50:54 -0700 (PDT) X-Google-Smtp-Source: ABdhPJyDkmwVgoTALQfOsaGRA5wx+4NhE67zjXjwo/xMlx5tEZkdnOTA/dqnLjoR6bCivpywA78b X-Received: by 2002:a17:906:e210:: with SMTP id gf16mr5565532ejb.386.1595530254648; Thu, 23 Jul 2020 11:50:54 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1595530254; cv=none; d=google.com; s=arc-20160816; b=Z+5kILD0jzr7XEnlrBrFRoDOmHKqOCteW1OdnV40coJSNXdxmNqV894A7EcaQlH58+ +D0FZX00jpO6i1ztTAZtmwzdr41PqbBK9ZsbQ8wR7GHjRuHvh+0EgqHncaZEZqTvI3kt Iizn/Tq5UiTcrCa/gzrx5bU00uttcQb8Qq2VKh5wbXnDmkTwbKELtoqb+7xVhGo4V00M E0iMrAoCoWSRMkLSsceeU+Di7aNaNilEFHsLDx2xocxMrNmw2V4cmJ2r0qCKlFfPfLTH LSoVXG5CH6lkqzeNYcnkNg4Hn3oFLD05RNaQ1nWc/Z2S2Ua9EBVRTK9sUHeEmP9M05ka CZ9w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:in-reply-to:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :dkim-signature; bh=ZBGeT5meaENGUkHBjaTnLB8Wyc3JbNoxdGt3rTZZJuE=; b=SD/kAjSQHJ7vGK6LdQWB6he2xRuH6Js/qMJbwQHJmlkYtlCFQeOulBGowVxlZHaKVx 5vGLTanTVpKa3VWzsIM3sdTZa4laa5JlUqBy3xsg6hN6h0wD/K2kXv9X0JI4KI0saSWa 0woDtnP0FnoTButaAw3fm2FAGW7iK3a0Rr+92bKIYudLJSiifXGc4K1AODFTImpoCY/h +F/Isr2F2nXMZOQoO/qChAtMvdlb8Z+f+/gGp8J+hdyvNIuU2gDElx7vnNYWhIHZBNqu FK8r3QoBcHyp3Kc2VgzeO21LIf+jdRaaQLFsGKgx3c7344iLxexQdMxCYgMynZp6E23B gj+Q== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail header.i=@gerhold.net header.s=strato-dkim-0002 header.b=jIyJlWeC; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id c6si2675459ejr.345.2020.07.23.11.50.30; Thu, 23 Jul 2020 11:50:54 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=fail header.i=@gerhold.net header.s=strato-dkim-0002 header.b=jIyJlWeC; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727965AbgGWSrv (ORCPT + 99 others); Thu, 23 Jul 2020 14:47:51 -0400 Received: from mo4-p03-ob.smtp.rzone.de ([81.169.146.172]:24568 "EHLO mo4-p03-ob.smtp.rzone.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726349AbgGWSru (ORCPT ); Thu, 23 Jul 2020 14:47:50 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; t=1595530068; s=strato-dkim-0002; d=gerhold.net; h=In-Reply-To:References:Message-ID:Subject:Cc:To:From:Date: X-RZG-CLASS-ID:X-RZG-AUTH:From:Subject:Sender; bh=ZBGeT5meaENGUkHBjaTnLB8Wyc3JbNoxdGt3rTZZJuE=; b=jIyJlWeC6htiBwmYGqOP3L/ZQy5QJxGPcPjCJ9yVLPmwCs32JQ8XQQpLCx+9mJBxgz aFVsQRPypuOA2ENtiuKNUgTT+nQmxjE77xNEXrb/am0QqYBXF+x386dzc/s/bEGSpqe/ jTkNBWrN5484GastutkeIfu4kBoSiQZHBzA4I3oMivKUHbSm8fZFL3T4Ale78UeboToI 6ZTw/WfMCaHclJwnORFE59QU0+Vk3EmKhifZ+3rCh6250FOD72e/98Mm7/0stpC8HZge kLUvJtoc5ka9mKMO5zFoiXzBmG4BI2m91RhLmGyBLNsrSEjh9hIQvQDxg5kXI2Y2z6Ev Az0g== X-RZG-AUTH: ":P3gBZUipdd93FF5ZZvYFPugejmSTVR2nRPhVOQ/OcYgojyw4j34+u26zEodhPgRDZ8j7IczHboo=" X-RZG-CLASS-ID: mo00 Received: from gerhold.net by smtp.strato.de (RZmta 46.10.5 DYNA|AUTH) with ESMTPSA id Y0939ew6NIif5J4 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256 bits)) (Client did not present a certificate); Thu, 23 Jul 2020 20:44:41 +0200 (CEST) Date: Thu, 23 Jul 2020 20:44:36 +0200 From: Stephan Gerhold To: Srinivas Kandagatla Cc: Cheng-Yi Chiang , linux-kernel@vger.kernel.org, Mark Brown , Taniya Das , Rohit kumar , Banajit Goswami , Patrick Lai , Andy Gross , Bjorn Andersson , Liam Girdwood , Rob Herring , Jaroslav Kysela , Takashi Iwai , dianders@chromium.org, dgreid@chromium.org, tzungbi@chromium.org, linux-arm-kernel@lists.infradead.org, linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, alsa-devel@alsa-project.org, Ajit Pandey Subject: Re: [PATCH v2 2/2] ASoC: qcom: sc7180: Add machine driver for sound card registration Message-ID: <20200723184432.GA321518@gerhold.net> References: <20200721104422.369368-1-cychiang@chromium.org> <20200721104422.369368-3-cychiang@chromium.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Jul 22, 2020 at 10:25:14AM +0100, Srinivas Kandagatla wrote: > > +static int sc7180_parse_of(struct snd_soc_card *card) > > +{ > > This code is getting duplicated in various places like apq8016_sbc_parse_of, > it will be nice to common this up, if possible! > FYI, I started work on making apq8016_sbc use qcom_snd_parse_of() a while ago already, but didn't find the time to finish it up. I have now sent it, this should make it possible to use the common qcom_snd_parse_of() function in this driver as well. See: https://lore.kernel.org/alsa-devel/20200723183904.321040-1-stephan@gerhold.net/ Stephan