Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Content-Type: text/plain; charset="utf-8"
MIME-Version: 1.0
Content-Transfer-Encoding: quoted-printable
In-Reply-To: <20200414143536.v10.1.I30e2a8ff8cc4ad1ffb65df09ad933e5b4d9f16f8@changeid>
References: <20200414143536.v10.1.I30e2a8ff8cc4ad1ffb65df09ad933e5b4d9f16f8@changeid>
Subject: Re: [PATCH v10 1/2] dt-bindings: iio: Add bindings for sx9310 sensor
From:   Stephen Boyd <swboyd@chromium.org>
Cc:     Jonathan Cameron <jic23@kernel.org>,
        Daniel Campello <campello@chromium.org>,
        Rob Herring <robh@kernel.org>,
        Hartmut Knaack <knaack.h@gmx.de>,
        Lars-Peter Clausen <lars@metafoo.de>,
        Mark Rutland <mark.rutland@arm.com>,
        Peter Meerwald-Stadler <pmeerw@pmeerw.net>,
        Rob Herring <robh+dt@kernel.org>, linux-iio@vger.kernel.org
To:     Daniel Campello <campello@chromium.org>,
        LKML <devicetree@vger.kernel.org>,
        LKML <linux-kernel@vger.kernel.org>
Date:   Thu, 23 Jul 2020 12:29:33 -0700
Message-ID: <159553257307.3847286.4297914412173341085@swboyd.mtv.corp.google.com>
User-Agent: alot/0.9.1
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

Quoting Daniel Campello (2020-04-14 13:36:07)
> Adds device tree bandings for sx9310 sensor.
>=20
> Signed-off-by: Daniel Campello <campello@chromium.org>
> Reviewed-by: Rob Herring <robh@kernel.org>
> ---

I don't see this picked up anywhere in linux-next. Can we squash in this
change? Typically the voltage regulator names match the data sheet, and
in this case the datasheet names them vdd and svdd. Also, they're not
strictly necessary to be in the binding if they're always on supplies so
we can remove them from the required section and DT files can omit them
if they don't care to actively power manage them.

---8<---
diff --git a/Documentation/devicetree/bindings/iio/proximity/semtech,sx9310=
.yaml b/Documentation/devicetree/bindings/iio/proximity/semtech,sx9310.yaml
index b52ffdac678b..ba734ee868c7 100644
--- a/Documentation/devicetree/bindings/iio/proximity/semtech,sx9310.yaml
+++ b/Documentation/devicetree/bindings/iio/proximity/semtech,sx9310.yaml
@@ -31,12 +31,15 @@ properties:
       available or that a close/far proximity event has happened.
     maxItems: 1
=20
-  power-supply: true
+  vdd-supply:
+    description: Main power supply
+
+  svdd-supply:
+    description: Host interface power supply
=20
 required:
   - compatible
   - reg
-  - power-supply
=20
 additionalProperties: false
=20
@@ -51,6 +54,7 @@ examples:
         reg =3D <0x28>;
         interrupt-parent =3D <&pio>;
         interrupts =3D <5 IRQ_TYPE_LEVEL_LOW 5>;
-        power-supply =3D <...>;
+        vdd-supply =3D <&pp3300_a>;
+        svdd-supply =3D <&pp1800_prox>;
       };
     };