Received: by 2002:a25:e74b:0:0:0:0:0 with SMTP id e72csp1607297ybh; Thu, 23 Jul 2020 13:14:00 -0700 (PDT) X-Google-Smtp-Source: ABdhPJy+r4AIf6qljkRb6nlwHafziA9DHXyGFDM18B7p1CZ7X7b4dYa8sNAyypadqQd6G/pyBcCy X-Received: by 2002:a50:ee8a:: with SMTP id f10mr5664802edr.383.1595535240432; Thu, 23 Jul 2020 13:14:00 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1595535240; cv=none; d=google.com; s=arc-20160816; b=0uKIRpERJBCoT9BWnWcxLP2BKLvo1iit75+dTn02iuc8QQsf/yXX31lA7XdqvwPxyG EhRduUqmLxD8L7HnmAG6WQ/BMJj7mP2w/ZJIDm6ENz59hjFweXu6GJmfW4C6yr7+qc3P hGUPxRc0yAN4argoj+HON92sWsbw1XsZmouKZ7PpYKXYlkzBxxpXY7N8fIzjmGYTIJn6 mAZrsb6+kqi5/06+YAFSQSirffgZJ8okEt3mI9c4SU742YWrlCcQoZhyly7p6HVNUPO1 F2WC+V3d1mhGOyj4hcd9pnMX7OPz7UNS6vywQun+7jLP09crkew+rZt8CE/hWm1Q+Avb SuSw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from; bh=apmAGohnrehF/TOx1zD4BbD9xA7SqVGBvTkI9DgfLwY=; b=iI93DebaOB/4HH679NruAZ6Zjk5hwEVDV31mb7GqAF5Z0coqzvimVMuCLkslg+GuTQ dLrruFcerXENUNuM9g7MLfnt3M4FobBTB7JPvJU4/2VZRGxy7++gx1STKEmQfglGCJut hGOXluwNUUHnnpzP+VmDS3+LPrRTXGPImuev040tckAm3Nz1BLg++a8h9DYAV6UTqiVn zzXE400hKfHObP9vAjeC0KytU491ZEfmwW7ZFTDJYxLQBSB5+ApYmrVcQsmSLyxaRVBK MzdUuWt/cULcfhLIMSgMuCQGY5G16vqcQIah1zB4dwgKM798/6T+0SHBLULIU9iJl7Ka D4vg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id bs1si3004462edb.418.2020.07.23.13.13.37; Thu, 23 Jul 2020 13:14:00 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727029AbgGWULC (ORCPT + 99 others); Thu, 23 Jul 2020 16:11:02 -0400 Received: from mail.fireflyinternet.com ([77.68.26.236]:52420 "EHLO fireflyinternet.com" rhost-flags-OK-FAIL-OK-FAIL) by vger.kernel.org with ESMTP id S1726033AbgGWULB (ORCPT ); Thu, 23 Jul 2020 16:11:01 -0400 X-Default-Received-SPF: pass (skip=forwardok (res=PASS)) x-ip-name=78.156.65.138; Received: from build.alporthouse.com (unverified [78.156.65.138]) by fireflyinternet.com (Firefly Internet (M1)) with ESMTP id 21911950-1500050 for multiple; Thu, 23 Jul 2020 21:10:44 +0100 From: Chris Wilson To: linux-kernel@vger.kernel.org Cc: Chris Wilson , Ingo Molnar , Peter Zijlstra , Juri Lelli , Vincent Guittot Subject: [PATCH] sched: Warn if garbage is passed to default_wake_function() Date: Thu, 23 Jul 2020 21:10:42 +0100 Message-Id: <20200723201042.18861-1-chris@chris-wilson.co.uk> X-Mailer: git-send-email 2.20.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Since the default_wake_function() passes its flags onto try_to_wake_up(), warn if those flags collide with internal values. Given that the supplied flags are garbage, no repair can be done but at least alert the user to the damage they are causing. In the belief that these errors should be picked up during testing, the warning is only compiled in under CONFIG_SCHED_DEBUG. Signed-off-by: Chris Wilson Cc: Ingo Molnar Cc: Peter Zijlstra Cc: Juri Lelli Cc: Vincent Guittot --- kernel/sched/core.c | 1 + 1 file changed, 1 insertion(+) diff --git a/kernel/sched/core.c b/kernel/sched/core.c index 7b918059332b..4be209266d8a 100644 --- a/kernel/sched/core.c +++ b/kernel/sched/core.c @@ -4481,6 +4481,7 @@ asmlinkage __visible void __sched preempt_schedule_irq(void) int default_wake_function(wait_queue_entry_t *curr, unsigned mode, int wake_flags, void *key) { + WARN_ON_ONCE(IS_ENABLED(CONFIG_SCHED_DEBUG) && wake_flags & ~WF_SYNC); return try_to_wake_up(curr->private, mode, wake_flags); } EXPORT_SYMBOL(default_wake_function); -- 2.20.1