Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S964848AbWEJI3X (ORCPT ); Wed, 10 May 2006 04:29:23 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S964849AbWEJI3X (ORCPT ); Wed, 10 May 2006 04:29:23 -0400 Received: from mail.suse.de ([195.135.220.2]:31904 "EHLO mx1.suse.de") by vger.kernel.org with ESMTP id S964848AbWEJI3W (ORCPT ); Wed, 10 May 2006 04:29:22 -0400 To: Pekka J Enberg Cc: Mike Kravetz , Andrew Morton , Dave Hansen , Andy Whitcroft , linux-kernel@vger.kernel.org, clameter@sgi.com Subject: Re: [PATCH] alloc_memory_early() routines References: <20060509053512.GA20073@monkey.ibm.com> <20060508224952.0b43d0fd.akpm@osdl.org> <20060509210722.GD3168@w-mikek2.ibm.com> <84144f020605100009i74824233ie6feaf6fd2d9055f@mail.gmail.com> From: Andi Kleen Date: 10 May 2006 10:29:14 +0200 In-Reply-To: Message-ID: User-Agent: Gnus/5.09 (Gnus v5.9.0) Emacs/21.2 MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1065 Lines: 30 Pekka J Enberg writes: > On Wed, 10 May 2006, Pekka Enberg wrote: > > > > +void * __init alloc_memory_early_node(size_t size, gfp_t flags, int node) > > > > +{ > > > > + if (g_cpucache_up == FULL) > > > > + return kmalloc_node(size, flags, node); > > > > + else > > > > + return alloc_bootmem_node(NODE_DATA(node), size); > > > > +} > > > > > > I'd prefer you put this in mm/bootmem.c and added a > > > > > > int slab_is_available(void) > > > { > > > return g_cpucache_up == FULL; > > > } > > > > > > to mm/slab.c instead. > > On Wed, 10 May 2006, Christoph Lameter wrote: > > Does slab not available mean that bootmem can be used? > > Yes. Actually it doesn't - in early boot up there is a phase where even bootmem doesn't work yet. -Andi - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/