Received: by 2002:a25:e74b:0:0:0:0:0 with SMTP id e72csp1613650ybh; Thu, 23 Jul 2020 13:24:32 -0700 (PDT) X-Google-Smtp-Source: ABdhPJw2P6YkzKz4ZQSQpa7NqUpRiu0gg0NB7W2pwdqEYeNC2x6Eif0lAp806GCsrpGWjyuKiAlw X-Received: by 2002:a17:906:8688:: with SMTP id g8mr5931509ejx.505.1595535871734; Thu, 23 Jul 2020 13:24:31 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1595535871; cv=none; d=google.com; s=arc-20160816; b=HeN5rE2timyYnAj3dwitW+v1zpSj2dyH6ykOKUD3tE1jgHUIOs0VUrfOpwPUuEZzLO tzyr8hHzRmy3M3x46PDav3DEpO92tKJONWWGVfkQmyo0lMadn+B9gccjY9AOH6nx52HO CtHdx/FeTMB+p1ctL2zP9q+u8FxHayyo0TkJAinCtF7ye27RfgKC0Hn+CR/4siQ2icfU TUcaSR82LeHdcgV1F9v59g+tpeZu9wcxIU5v8RqkgaRxkWHK7RX89Qd4AjSf0/tqKqwm s52eq/1f/t2o95RASlEUdZYlLj0y4bS9DKU0RGnIGoAiSq1epPs34xGxhSrK3Icm++8c TyDA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date:dkim-signature; bh=yx2Cl0rrJsvUGOSVxOGLvOUAvdhwFXlMCLOJys7SWqQ=; b=eMJNGi4cfaReVblUzmiRcR7gHVsQh2Fw3kXE3tv70TZmWst8u3H6eDrabI3C1KA8m/ Z8YulGO3bxVtnbnQynTDYdVlrCsyHG+vmLIUIR2sKbSAnwYNAhriPpYoQavwuejfksDO fq85YfjFMb9DcuZp4Pp6Sfp6yX0wIutnkp3SBUefjBUq/ER3up6FimKcs1WyVmvIZRQg QTvUnJj6GWZMPfd/pqCopZk56iwpNQejbLAiRQYxw/E7CfM5J+9Me1XKZ7n0/uT2o47/ QqKRZXZ7lxPHRjInCq58a1G0XW6AdwmWUYQtQnbEvrn3f6Yxpj/Vte11/EcdkuRC5XSa VCkQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=wiDrhqxX; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id x15si2479171ejc.115.2020.07.23.13.24.09; Thu, 23 Jul 2020 13:24:31 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=wiDrhqxX; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727908AbgGWUU4 (ORCPT + 99 others); Thu, 23 Jul 2020 16:20:56 -0400 Received: from mail.kernel.org ([198.145.29.99]:36072 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725979AbgGWUU4 (ORCPT ); Thu, 23 Jul 2020 16:20:56 -0400 Received: from localhost (p5486cde4.dip0.t-ipconnect.de [84.134.205.228]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 5CC6E2065F; Thu, 23 Jul 2020 20:20:55 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1595535656; bh=FbxTYh0fWLjQ7Sjp/R5xOaVw+O8KPQCewwVWb3GHb1I=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=wiDrhqxXFEBkyR6m/VPuaPmCl4ujg0haeXzw/xkPYLg3z3GLFf+gmTi1//Rg3F5YG OVTzSeM6GRIMJ2jvZ+8HLl8Z6yuoTEvruZq7jWIayMMCWTG2a1GHwpBErDvopRz/Hy OrAuSlaUupD2qQJWvPEpIotaKQNU1M/CzdCwfsJI= Date: Thu, 23 Jul 2020 22:20:53 +0200 From: Wolfram Sang To: Rayagonda Kokatanur Cc: linux-i2c@vger.kernel.org, linux-kernel@vger.kernel.org, Ray Jui , Scott Branden , bcm-kernel-feedback-list@broadcom.com, Lori Hikichi , Robert Richter , Nishka Dasgupta , Andy Shevchenko , linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH v2 2/2] i2c: iproc: add slave pec support Message-ID: <20200723202053.GD908@ninjato> References: <20200717090155.10383-1-rayagonda.kokatanur@broadcom.com> <20200717090155.10383-3-rayagonda.kokatanur@broadcom.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="/3yNEOqWowh/8j+e" Content-Disposition: inline In-Reply-To: <20200717090155.10383-3-rayagonda.kokatanur@broadcom.com> User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --/3yNEOqWowh/8j+e Content-Type: text/plain; charset=us-ascii Content-Disposition: inline > + /* Enable partial slave HW PEC support if requested by the client */ > + iproc_i2c->en_s_pec = !!(slave->flags & I2C_CLIENT_PEC); > + if (iproc_i2c->en_s_pec) > + dev_info(iproc_i2c->device, "Enable PEC\n"); Where do you set the I2C_CLIENT_PEC flag for the slave? Is your backend code publicly available? I may need a second thought here, but I am not sure I2C_CLIENT_PEC is the right way to enable PEC. Isn't it actually depending on the backend if PEC is needed? I.e. is the backend an I2C device or an SMBus device? --/3yNEOqWowh/8j+e Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAABCgAdFiEEOZGx6rniZ1Gk92RdFA3kzBSgKbYFAl8Z8SUACgkQFA3kzBSg KbbvpBAAtQRmswxsOKcvCyMFVWcsW5AfEvAruqcfflu4znShCEhfrIQJ0ex22Yar wk20IjlcslcHYVA/9orCWd781sMa0BSmsvYLEpCdIKx+O3IJ7H4vOyVIwda2fcSv tMvgFAANNUV7/zEMhrvM8XRV0c86g19iMq8KtbprPGwX/bg2M4VQko8gmUcGBj4f g1q8x0HjbYCSlEViGTethpGqGK1I8tjWJDIKC4FvqLlU5Vqw8RqkExhHpOLrGEdU EHkJp1TyZkkJ4xgwWQTtHtr68HF2r9VI0pV/jMZRM/D0NZr9gYzT3wFr1OZ4aHYt Km/GLzSSjPjf/TWfO5uB2yLE3Ba15N9U+337L8md02v61ZJRSimyUQucTD661XOd u17HCu0/KLY8jCRvEEdoY6OMNcHZPjKJde4vRuW6o2iiIcuygcbaDUPrOfBuZDdl kwbktPNE3cdRsDX5Sayr1iV/gccDLg1VWaIzVnnWSaQpxBmpB79cQjarHmRnviJj N4VxoI5NW+XEc+eKcPRtFKedO78wj9QZmcPygbbFGEC0HMmCX7ciph6fAGE4aNvs 3NJgVPR+XS9GjVUhc/mL1oUuh3vP509cLWUK7PCGumOu2hEIPqI65SqEnKsFo40x CZH02zq7o5wfOEqZtREELmFr0olUhMlxFh8faiCsfEq941LsaCc= =eWxG -----END PGP SIGNATURE----- --/3yNEOqWowh/8j+e--