Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
IronPort-SDR: QYZrAG2UZimOo0rHAIV4S9E6Dcld4eTCNWZPTbMQgsIVIhFB/ax/6prlaFi5X8RvkM17ppSs2n
 bk8lZ4wzCxYg==
IronPort-SDR: d8OBUfzyhIUtrluHwoWBiEPYaGXZ+sJT4Sw1hBqSikxetw67LHKcbn4BFC2pFvvdSQsrr1R7G9
 ZmShiXK962EQ==
Date:   Thu, 23 Jul 2020 22:40:29 +0100
From:   Giovanni Cabiddu <giovanni.cabiddu@intel.com>
To:     Alex Williamson <alex.williamson@redhat.com>
Cc:     herbert@gondor.apana.org.au, cohuck@redhat.com, nhorman@redhat.com,
        vdronov@redhat.com, bhelgaas@google.com, mark.a.chambers@intel.com,
        gordon.mcfadden@intel.com, ahsan.atta@intel.com,
        qat-linux@intel.com, kvm@vger.kernel.org,
        linux-crypto@vger.kernel.org, linux-pci@vger.kernel.org,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 2/5] vfio/pci: Add device blocklist
Message-ID: <20200723214029.GA6572@silpixa00400314>
References: <20200714063610.849858-1-giovanni.cabiddu@intel.com>
 <20200714063610.849858-3-giovanni.cabiddu@intel.com>
 <20200722230210.55b2d326@x1.home>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20200722230210.55b2d326@x1.home>
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Wed, Jul 22, 2020 at 11:02:10PM -0600, Alex Williamson wrote:
> On Tue, 14 Jul 2020 07:36:07 +0100
> Giovanni Cabiddu <giovanni.cabiddu@intel.com> wrote:
> 
> > Add blocklist of devices that by default are not probed by vfio-pci.
> > Devices in this list may be susceptible to untrusted application, even
> > if the IOMMU is enabled. To be accessed via vfio-pci, the user has to
> > explicitly disable the blocklist.
> > 
> > The blocklist can be disabled via the module parameter disable_blocklist.
> > 
> > Signed-off-by: Giovanni Cabiddu <giovanni.cabiddu@intel.com>
> > ---
> >  drivers/vfio/pci/vfio_pci.c | 33 +++++++++++++++++++++++++++++++++
> >  1 file changed, 33 insertions(+)
> 
> Hi Giovanni,
> 
> I'm pretty satisfied with this series, except "blocklist" makes me
> think of block devices, ie. storage, or block chains, or building block
> types of things before I get to "block" as in a barrier.  The other
> alternative listed as a suggestion currently in linux-next is denylist,
> which is the counter to an allowlist.  I've already proposed changing
> some other terminology in vfio.c to use the term "allowed", so
> allow/deny would be my preference versus pass/block.
Thanks Alex for your feedback. A new revision is on the way.

Regards,

-- 
Giovanni