Received: by 2002:a25:e74b:0:0:0:0:0 with SMTP id e72csp1668299ybh; Thu, 23 Jul 2020 14:58:28 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxFxZLOjYwoTlXTYRzHzWgR06RPgnhCBPqZ/QnhGP4a8TBhvp1uyeKv/bkZWg8/QqIueIPw X-Received: by 2002:a50:fb06:: with SMTP id d6mr5966447edq.165.1595541507954; Thu, 23 Jul 2020 14:58:27 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1595541507; cv=none; d=google.com; s=arc-20160816; b=ZVwcEj9xmKk/O+nl+SBfndbIRmvxzKf1Xvk3qbTAPmvkcAnxJ8LOvG7r9oQP+3s68+ Y/SzivYNoH0+nr2dRCx2bj4rG6LVo96VUegHCsbIQ7SJ1UuiVJL5C1Ze973Crm5Kz36c eTzJwwTmtVV/2SntFgnC5YDtPY/3795Cmovc0c8xIDEkTP0Be9L3UjbALoqfaKiBdoq8 fEZa+4x4bwfjrWGMhRaLH7kiHbl3pnOy+JuZw/edE7ShnJMbpYyTsQqe1ZQgrocdU+yD 2tbpqT5nRmKmaGvp18NHFBqQvaua1QfPkxNtz5xYo5QP+gdLCgsAMoXV5T0VXtPKjAPv twvQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :references:in-reply-to:from:subject:cc:to:message-id:date; bh=kkct+79XYQ45Tv0vtJCYtDEeCWuHHvYCmaUq0hbNCBw=; b=M7ttMujnAbWd+w/zh6GD58w06UlXGxMJGsfP79OeyjGqQlU8QVaO/RyHKtNXCzTG7v wTVoCIObI1SZpgDCbIsYXYlVyKF/inekwxk35TnfiWRhR/u6YoUod01L9b4j8M+wGk0k rbtP/reRtBpW3PuiFpOaM3VBpWuv6YBllSH/dUI/hUpn8Quq+lTYII/Qge++oCo7qLHD dCVzJdTZ4tZH9uGd7PM+YGictKentH8cYZLAF6RQ5hCMJkmNNly+9KjBBzdJ0F1uAa6x pBWY3Ld1FU2WGBAKOUKOYoJVhFimi81XrWsUOHUmaDikGCPHDqANnE6EbYLanreV1eKO MxaA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id e12si2060644eds.19.2020.07.23.14.58.04; Thu, 23 Jul 2020 14:58:27 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728028AbgGWV5Z (ORCPT + 99 others); Thu, 23 Jul 2020 17:57:25 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:34240 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726638AbgGWV5Y (ORCPT ); Thu, 23 Jul 2020 17:57:24 -0400 Received: from shards.monkeyblade.net (shards.monkeyblade.net [IPv6:2620:137:e000::1:9]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id D31DBC0619D3; Thu, 23 Jul 2020 14:57:24 -0700 (PDT) Received: from localhost (unknown [IPv6:2601:601:9f00:477::3d5]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (Client did not present a certificate) (Authenticated sender: davem-davemloft) by shards.monkeyblade.net (Postfix) with ESMTPSA id DF90611E48C62; Thu, 23 Jul 2020 14:40:37 -0700 (PDT) Date: Thu, 23 Jul 2020 14:57:22 -0700 (PDT) Message-Id: <20200723.145722.752878326752101646.davem@davemloft.net> To: andrea.righi@canonical.com Cc: boris.ostrovsky@oracle.com, jgross@suse.com, sstabellini@kernel.org, kuba@kernel.org, xen-devel@lists.xenproject.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] xen-netfront: fix potential deadlock in xennet_remove() From: David Miller In-Reply-To: <20200722065211.GA841369@xps-13> References: <20200722065211.GA841369@xps-13> X-Mailer: Mew version 6.8 on Emacs 26.3 Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Thu, 23 Jul 2020 14:40:38 -0700 (PDT) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Andrea Righi Date: Wed, 22 Jul 2020 08:52:11 +0200 > +static int xennet_remove(struct xenbus_device *dev) > +{ > + struct netfront_info *info = dev_get_drvdata(&dev->dev); > + > + dev_dbg(&dev->dev, "%s\n", dev->nodename); These kinds of debugging messages provide zero context and are so much less useful than simply using tracepoints which are more universally available than printk debugging facilities. Please remove all of the dev_dbg() calls from this patch.