Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Subject: Re: [PATCH 4/4] dt-binding: mediatek: mt8192: update mtk-wdt document
To:     Rob Herring <robh@kernel.org>, Seiya Wang <seiya.wang@mediatek.com>
Cc:     Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        Wim Van Sebroeck <wim@linux-watchdog.org>,
        Guenter Roeck <linux@roeck-us.net>,
        linux-serial@vger.kernel.org, devicetree@vger.kernel.org,
        linux-arm-kernel@lists.infradead.org,
        linux-mediatek@lists.infradead.org, linux-kernel@vger.kernel.org,
        linux-watchdog@vger.kernel.org, srv_heupstream@mediatek.com,
        Crystal Guo <crystal.guo@mediatek.com>
References: <20200723090731.4482-1-seiya.wang@mediatek.com>
 <20200723090731.4482-5-seiya.wang@mediatek.com>
 <20200723212935.GA889594@bogus>
From:   Matthias Brugger <matthias.bgg@gmail.com>
Message-ID: <d69d441d-b8c7-f4a4-7ae1-a0012d8001f3@gmail.com>
Date:   Fri, 24 Jul 2020 00:02:24 +0200
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101
 Thunderbird/68.9.0
MIME-Version: 1.0
In-Reply-To: <20200723212935.GA889594@bogus>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk


On 23/07/2020 23:29, Rob Herring wrote:
> On Thu, Jul 23, 2020 at 05:07:31PM +0800, Seiya Wang wrote:
>> From: Crystal Guo <crystal.guo@mediatek.com>
>>
>> update mtk-wdt document for MT8192 platform
>>
>> Signed-off-by: Crystal Guo <crystal.guo@mediatek.com>
>> ---
>>   Documentation/devicetree/bindings/watchdog/mtk-wdt.txt | 2 ++
>>   1 file changed, 2 insertions(+)
>>
>> diff --git a/Documentation/devicetree/bindings/watchdog/mtk-wdt.txt b/Documentation/devicetree/bindings/watchdog/mtk-wdt.txt
>> index 4dd36bd3f1ad..d760ca8a630e 100644
>> --- a/Documentation/devicetree/bindings/watchdog/mtk-wdt.txt
>> +++ b/Documentation/devicetree/bindings/watchdog/mtk-wdt.txt
>> @@ -12,6 +12,8 @@ Required properties:
>>   	"mediatek,mt7629-wdt", "mediatek,mt6589-wdt": for MT7629
>>   	"mediatek,mt8183-wdt", "mediatek,mt6589-wdt": for MT8183
>>   	"mediatek,mt8516-wdt", "mediatek,mt6589-wdt": for MT8516
>> +	"mediatek,mt8192-wdt": for MT8192
>> +
> 
> So, not compatible with "mediatek,mt6589-wdt"? Is so, perhaps summarize
> what the differences are.
> 

Hm, looks to me as if the binding description for mt2712 and mt8183 isn't 
correct, as we have a OF data just as we have for mt8192 now. Could you fix this 
in a separate patch?

Regards,
Matthias

>>   
>>   - reg : Specifies base physical address and size of the registers.
>>   
>> -- 
>> 2.14.1