Received: by 2002:a25:e74b:0:0:0:0:0 with SMTP id e72csp1689759ybh; Thu, 23 Jul 2020 15:33:30 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxjQbRw3PdWLuMHGowZcWGxsXXxkA6dV+GNQj6NgCuNhhO/LFue6X7wD+cdPjJm4oXhSQ17 X-Received: by 2002:a17:906:5909:: with SMTP id h9mr6726703ejq.501.1595543610642; Thu, 23 Jul 2020 15:33:30 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1595543610; cv=none; d=google.com; s=arc-20160816; b=QXK215z/QpMxxm2YEBu5fDltF1+lPmw31R9hvFLS8MW1E6Ggp5Nbs98pj75IqoKPhA YKWXUXkI0EiruTPVsjWKNVp7LZ3QsGY+HOYpoB0gCHeeVQ+6mhadrVubgH4x70+zeFWY +7WFvW5vBhDnMAKLia3kb5r+91zM1gDqSToGY+Q9WACnGUlS6WdgYb4fj08/tUYBKjVY 6/URJCh7IMWzJ2AvRFfeAdKQP9Q5RptDm0wP6cy1P9bX/xm7YYXPbmDMSZ1+GkYfIs1/ EebTbKCGd6LrhJUCkVkB/ojxqYTFzLGVNacNZ3AqEfXDu92CA1lL/FRx2gh3xiGgBAna uozw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from; bh=TFJXKdxELf6f2+EOPDnmcAiql9qeoSB82kXuOENHhng=; b=BCJcTy8Ud0cbyb2mefLiino96xUDubu7nH3NHZ2V9bIzFX264iP5dCnYWeBTyiUmGV 10Pnpcb7yvzJf2KmtQrRPDnXrsLfOZzRLTS0TgWHMk34VqAm0wyS5i7zi99keDjALIU3 jS/bTzOHfOZeyy2KlZZrekjXMqPxNvu6bYIFGVgUrFChHrnc3pBUT/VeUggiXWN1Ek/o FhLYBiIFDlZzYbkLvm15SW0G7F19LzyZSb9vDLSaHBPdBhXjDrtJurliI+vfdY/gA+5C UP/SNYankivhNGjxSn4gA9UJOaomwH+jvoy0rMzFh0BdFTPN76K+KcLjSnij8b3qqFLi dR2Q== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=nvidia.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id fi17si2855877ejb.724.2020.07.23.15.33.06; Thu, 23 Jul 2020 15:33:30 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=nvidia.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728059AbgGWWbD convert rfc822-to-8bit (ORCPT + 99 others); Thu, 23 Jul 2020 18:31:03 -0400 Received: from hqnvemgate25.nvidia.com ([216.228.121.64]:13903 "EHLO hqnvemgate25.nvidia.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727876AbgGWWaw (ORCPT ); Thu, 23 Jul 2020 18:30:52 -0400 Received: from hqpgpgate102.nvidia.com (Not Verified[216.228.121.13]) by hqnvemgate25.nvidia.com (using TLS: TLSv1.2, DES-CBC3-SHA) id ; Thu, 23 Jul 2020 15:29:48 -0700 Received: from hqmail.nvidia.com ([172.20.161.6]) by hqpgpgate102.nvidia.com (PGP Universal service); Thu, 23 Jul 2020 15:30:51 -0700 X-PGP-Universal: processed; by hqpgpgate102.nvidia.com on Thu, 23 Jul 2020 15:30:51 -0700 Received: from HQMAIL111.nvidia.com (172.20.187.18) by HQMAIL101.nvidia.com (172.20.187.10) with Microsoft SMTP Server (TLS) id 15.0.1473.3; Thu, 23 Jul 2020 22:30:42 +0000 Received: from rnnvemgw01.nvidia.com (10.128.109.123) by HQMAIL111.nvidia.com (172.20.187.18) with Microsoft SMTP Server (TLS) id 15.0.1473.3 via Frontend Transport; Thu, 23 Jul 2020 22:30:42 +0000 Received: from rcampbell-dev.nvidia.com (Not Verified[10.110.48.66]) by rnnvemgw01.nvidia.com with Trustwave SEG (v7,5,8,10121) id ; Thu, 23 Jul 2020 15:30:42 -0700 From: Ralph Campbell To: , , , , , CC: Jerome Glisse , John Hubbard , Christoph Hellwig , Jason Gunthorpe , "Andrew Morton" , Shuah Khan , "Ben Skeggs" , Bharata B Rao , "Ralph Campbell" Subject: [PATCH v4 6/6] mm/migrate: remove range invalidation in migrate_vma_pages() Date: Thu, 23 Jul 2020 15:30:04 -0700 Message-ID: <20200723223004.9586-7-rcampbell@nvidia.com> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20200723223004.9586-1-rcampbell@nvidia.com> References: <20200723223004.9586-1-rcampbell@nvidia.com> MIME-Version: 1.0 X-NVConfidentiality: public Content-Transfer-Encoding: 8BIT Content-Type: text/plain Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org When migrating the special zero page, migrate_vma_pages() calls mmu_notifier_invalidate_range_start() before replacing the zero page PFN in the CPU page tables. This is unnecessary since the range was invalidated in migrate_vma_setup() and the page table entry is checked to be sure it hasn't changed between migrate_vma_setup() and migrate_vma_pages(). Therefore, remove the redundant invalidation. DKIM-Signature: v aa-sha256; claxed/relaxed; didia.com; s; t95543388; bhqnSzc0udfc4m+P6cziRmRJk5XEGcgDU5ImloLrCuE hPGP-Universal:From:To:CC:Subject:Date:Message-ID:X-Mailer: In-Reply-To:References:MIME-Version:X-NVConfidentiality: Content-Transfer-Encoding:Content-Type; byLVqKU1Kxf67Qz9TIZ2f1lAaP7YxvFgCZR8v0Vw1fwq7aUbMbgfzcF0bd6+XzG6 ZHtBRMp/Zu/ZLGRxP6lBqZo4wHMHbuW3fXOvPCrYTD5YsCCLv+Ao4RmreWyec2wBTk uBo3ZylCHJ0ckD85BcjQQxpXyY99cBsvIomZw9wzg6QGm7Ksbq6d+UKSkb0L04d6v8 fiRvvLNq3kCbPzrifaBTj3klQcVcKXz34km0XUoRQlSaftlq4BJWopBPX8U7gQtstO OvA7Al9t87sCpKjSnqjE7N1jThU0KzjPrCxJiEHq/0Vf4sqeUA42bOkc+bk/CV1ZSF n9jm36j4kRTUg Signed-off-by: Ralph Campbell --- mm/migrate.c | 20 -------------------- 1 file changed, 20 deletions(-) diff --git a/mm/migrate.c b/mm/migrate.c index 96e1f41a991e..36076ba2f51a 100644 --- a/mm/migrate.c +++ b/mm/migrate.c @@ -2877,9 +2877,7 @@ void migrate_vma_pages(struct migrate_vma *migrate) { const unsigned long npages = migrate->npages; const unsigned long start = migrate->start; - struct mmu_notifier_range range; unsigned long addr, i; - bool notified = false; for (i = 0, addr = start; i < npages; addr += PAGE_SIZE, i++) { struct page *newpage = migrate_pfn_to_page(migrate->dst[i]); @@ -2895,16 +2893,6 @@ void migrate_vma_pages(struct migrate_vma *migrate) if (!page) { if (!(migrate->src[i] & MIGRATE_PFN_MIGRATE)) continue; - if (!notified) { - notified = true; - - mmu_notifier_range_init(&range, - MMU_NOTIFY_CLEAR, 0, - NULL, - migrate->vma->vm_mm, - addr, migrate->end); - mmu_notifier_invalidate_range_start(&range); - } migrate_vma_insert_page(migrate, addr, newpage, &migrate->src[i], &migrate->dst[i]); @@ -2937,14 +2925,6 @@ void migrate_vma_pages(struct migrate_vma *migrate) if (r != MIGRATEPAGE_SUCCESS) migrate->src[i] &= ~MIGRATE_PFN_MIGRATE; } - - /* - * No need to double call mmu_notifier->invalidate_range() callback as - * the above ptep_clear_flush_notify() inside migrate_vma_insert_page() - * did already call it. - */ - if (notified) - mmu_notifier_invalidate_range_only_end(&range); } EXPORT_SYMBOL(migrate_vma_pages); -- 2.20.1