Received: by 2002:a17:90b:8d0:0:0:0:0 with SMTP id ds16csp2258085pjb; Thu, 23 Jul 2020 19:04:13 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwRNFYOUe8ZaThiQXJAQW8a2w/1u+S1ICk3av2R7oybsGA/N8isRSxPvCL5uo1A59+yNIIN X-Received: by 2002:a17:906:2c53:: with SMTP id f19mr7374941ejh.523.1595556252775; Thu, 23 Jul 2020 19:04:12 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1595556252; cv=none; d=google.com; s=arc-20160816; b=VMtHfNYhvrH+FDHMLAONAtveBvx1zXXHAknGs7kM0zEkdjV6KMgP0RoEiQA1MfzGrU qJTY6FOJ/9VR8jdWPRZZsNq8Mb9SAMJTYZN4ujB8qstVvHt6liyhILitkIaYmrguxqZf 7BSMj6AYJQ1EPgYOBeTcBqp+9Dh+elqQwW70jJxye3SFz1DPL+tj8pKGML+jL1ytZtpu P+bWiCkKKGppUv4wYd4u/ZmWBkYn4T9IvjOeucG4bHrbcJw/dSX9a7TX/X5ZdBtX3HZC VnuO/v42qHsUhdCRNVKv1BmKLs9/c8GIU137QHYXm5AYDpW3xPa2ailWhiMtLH+d2otV VQ+w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date:ironport-sdr:ironport-sdr; bh=8fXErTDLdMUywEaqU+1PMpeESGsq3EPMcO3+RBZOfiQ=; b=WQVX32QyF+DibbGB+9CQc4KyuWHwhDnxgcCew6md5JrYibvv0ukLPiStHlwgxd/bfS D0IwNQz7BEIf8R7UedvoIYQGw8ad+K5YanUseI2Rv38+znHHC1Hfs2gzatHo/xtqxtt2 CpoMZVYicBuwhHdkYWzXVU159D32ui/RRSCgIj1TCxp6XHsuw482v7xLw8n3JP7fju6m EFB6o6RObBSOVZ0EZgHFKUn5PZxz0o8zz0VJ5wb8E/EUxuM6jF8OpbzdwtDuu9lyMAyj yG3uGPDf2vOgFlevGDISrMWI1kvwsQ6cR2xr3KSiXhSuIdP2MrjzpP+2oV4/N+mzYV2B w59A== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=intel.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id l13si2853230eja.536.2020.07.23.19.03.47; Thu, 23 Jul 2020 19:04:12 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726759AbgGXCDd (ORCPT + 99 others); Thu, 23 Jul 2020 22:03:33 -0400 Received: from mga01.intel.com ([192.55.52.88]:13785 "EHLO mga01.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726178AbgGXCDd (ORCPT ); Thu, 23 Jul 2020 22:03:33 -0400 IronPort-SDR: Ya6DjcfGUMu3mV/G7SYclGU48xzJG7+ZjFK8ZxMR3mHo3tZMe2ruVlwUqQLL97nsRfta2Iky2A 1lZM1lmW/zrw== X-IronPort-AV: E=McAfee;i="6000,8403,9691"; a="168779432" X-IronPort-AV: E=Sophos;i="5.75,388,1589266800"; d="scan'208";a="168779432" X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga006.fm.intel.com ([10.253.24.20]) by fmsmga101.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 23 Jul 2020 19:03:32 -0700 IronPort-SDR: Pr1rgrMC5mbPr6YgLvMqbidnCxxs8J7FMUSf+6AWg4LYJse1iVdQYLA38+llU4226NNXx46aCl SLOiRtFpQSNw== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.75,388,1589266800"; d="scan'208";a="488578679" Received: from ranerica-svr.sc.intel.com ([172.25.110.23]) by fmsmga006.fm.intel.com with ESMTP; 23 Jul 2020 19:03:31 -0700 Date: Thu, 23 Jul 2020 19:03:16 -0700 From: Ricardo Neri To: Thomas Gleixner Cc: Andy Lutomirski , Cathy Zhang , kvm list , LKML , X86 ML , Paolo Bonzini , "Christopherson, Sean J" , Vitaly Kuznetsov , Wanpeng Li , Jim Mattson , Joerg Roedel , Ingo Molnar , Borislav Petkov , "H. Peter Anvin" , Kyung Min Park , Josh Poimboeuf , Greg KH , Andi Kleen , Dave Hansen , Tony Luck , "Ravi V. Shankar" , fenghua.yu@intel.com Subject: Re: [PATCH v2 1/4] x86/cpufeatures: Add enumeration for SERIALIZE instruction Message-ID: <20200724020316.GA20814@ranerica-svr.sc.intel.com> References: <1594088183-7187-1-git-send-email-cathy.zhang@intel.com> <1594088183-7187-2-git-send-email-cathy.zhang@intel.com> <20200708022102.GA25016@ranerica-svr.sc.intel.com> <87eep3ywz0.fsf@nanos.tec.linutronix.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <87eep3ywz0.fsf@nanos.tec.linutronix.de> User-Agent: Mutt/1.9.4 (2018-02-28) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Jul 23, 2020 at 01:02:43AM +0200, Thomas Gleixner wrote: > Ricardo Neri writes: > > On Tue, Jul 07, 2020 at 09:36:15AM -0700, Andy Lutomirski wrote: > >> On Mon, Jul 6, 2020 at 7:21 PM Cathy Zhang wrote: > >> > > >> > This instruction gives software a way to force the processor to complete > >> > all modifications to flags, registers and memory from previous instructions > >> > and drain all buffered writes to memory before the next instruction is > >> > fetched and executed. > >> > > >> > The same effect can be obtained using the cpuid instruction. However, > >> > cpuid causes modification on the eax, ebx, ecx, and ecx regiters; it > >> > also causes a VM exit. > >> > > >> > A processor supports SERIALIZE instruction if CPUID.0x0x.0x0:EDX[14] is > >> > present. The CPU feature flag is shown as "serialize" in /proc/cpuinfo. > >> > > >> > Detailed information on the instructions and CPUID feature flag SERIALIZE > >> > can be found in the latest Intel Architecture Instruction Set Extensions > >> > and Future Features Programming Reference and Intel 64 and IA-32 > >> > Architectures Software Developer's Manual. > >> > >> Can you also wire this up so sync_core() uses it? > > > > I am cc'ing Fenghua, who has volunteered to work on this. Addind support > > for SERIALIZE in sync_core() should not block merging these patches, > > correct? > > Come on. We are not serving KVM first before making this usable on bare > metal. Hi Thomas, I ended up implementing support for SERIALIZE in sync_core() I will be posting patches for this in the next few days. Thanks and BR, Ricardo