Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
IronPort-SDR: Guh+m5ut9YPsv6xJ9kqYjhFCHkibjsJrcI37GQc54pzwwhPuhcdOQ9NMm7cR2OfcU7bLRpqh8R
 axFWHbK4Eraw==
IronPort-SDR: iBx90Pr7CFLoBrXMYma7ZeELqZZhGNtzLh3cmTkYLqziolVzBvsjenanNTiDKag9mwB731SVIm
 cb/2DPDyllxw==
Subject: Re: [fsnotify] c738fbabb0: will-it-scale.per_process_ops -9.5%
 regression
To:     Amir Goldstein <amir73il@gmail.com>
Cc:     Jan Kara <jack@suse.cz>, LKML <linux-kernel@vger.kernel.org>,
        lkp@lists.01.org
References: <20200721001505.GD19262@shao2-debian>
 <CAOQ4uxgq39EDS_k3eDTngEAm8cxHPa7qrkUSW8Rk6qS9cxC18w@mail.gmail.com>
From:   Rong Chen <rong.a.chen@intel.com>
Message-ID: <9a2a4086-fbad-b4f8-9c00-2b7606441022@intel.com>
Date:   Fri, 24 Jul 2020 10:44:32 +0800
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101
 Thunderbird/60.6.1
MIME-Version: 1.0
In-Reply-To: <CAOQ4uxgq39EDS_k3eDTngEAm8cxHPa7qrkUSW8Rk6qS9cxC18w@mail.gmail.com>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: 7bit
Content-Language: en-US
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk


On 7/21/20 11:59 PM, Amir Goldstein wrote:
> On Tue, Jul 21, 2020 at 3:15 AM kernel test robot <rong.a.chen@intel.com> wrote:
>> Greeting,
>>
>> FYI, we noticed a -9.5% regression of will-it-scale.per_process_ops due to commit:
>>
>>
>> commit: c738fbabb0ff62d0f9a9572e56e65d05a1b34c6a ("fsnotify: fold fsnotify() call into fsnotify_parent()")
> Strange, that's a pretty dumb patch moving some inlined code from one
> function to
> another (assuming there are no fsnotify marks in this test).
>
> Unless I am missing something the only thing that changes slightly is
> an extra d_inode(file->f_path.dentry) deference.
> I can get rid of it.
>
> Is it possible to ask for a re-test with fix patch (attached)?

Hi Amir,

We failed to apply this patch, could you tell us the base commit or the 
base branch?

Best Regards,
Rong Chen