Date: Wed, 10 May 2006 15:57:16 +0530
From: Balbir Singh <balbir@in.ibm.com>
To: Andrew Morton <akpm@osdl.org>
Cc: linux-kernel@vger.kernel.org, lse-tech@lists.sourceforge.net,
       jlan@engr.sgi.com, tglx@linutronix.de
Subject: Re: [PATCH][delayacct] Fix the timespec_sub() interface (was Re: [Patch 1/8] Setup)
Message-ID: <20060510102716.GG29432@in.ibm.com>
Reply-To: balbir@in.ibm.com
References: <20060502061255.GL13962@in.ibm.com> <20060508141713.60c9d33e.akpm@osdl.org> <20060510101622.GB29432@in.ibm.com> <20060510032449.2872a8ba.akpm@osdl.org>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20060510032449.2872a8ba.akpm@osdl.org>
User-Agent: Mutt/1.5.10i
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1291
Lines: 41

On Wed, May 10, 2006 at 03:24:49AM -0700, Andrew Morton wrote:
> Balbir Singh <balbir@in.ibm.com> wrote:
> >
> > Please find the updated patch, which changes the interface of timespec_sub()
> > as suggested in the review comments
> > 
> > ...
> >
> >  /*
> > - * sub = end - start, in normalized form
> > + * sub = lhs - rhs, in normalized form
> >   */
> > -static inline void timespec_sub(struct timespec *start, struct timespec *end,
> > -				struct timespec *sub)
> > +static inline struct timespec timespec_sub(struct timespec *lhs,
> > +						struct timespec *rhs)
> >  {
> 
> I'd have thought that it would be more consistent and a saner interface to
> use pass-by-value:
> 
> static inline struct timespec timespec_sub(struct timespec lhs,
> 						struct timespec rhs)
> 
> It should generate the same code.
> 
> I mentioned this last time - did you choose to not do this for some reason,
> or did it just slip past?

Sorry, that definitely slip past.

I'll send another update

	Balbir Singh,
	Linux Technology Center,
	IBM Software Labs
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/