Received: by 2002:a25:e74b:0:0:0:0:0 with SMTP id e72csp1901004ybh; Thu, 23 Jul 2020 22:27:25 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwllTpje1oD+EUDLBYR8bRupZMp2X8IkxPYxanG9sBxEXWaOacbxQgvesKPUNG1BXqazckB X-Received: by 2002:a17:906:60d0:: with SMTP id f16mr7405824ejk.17.1595568445330; Thu, 23 Jul 2020 22:27:25 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1595568445; cv=none; d=google.com; s=arc-20160816; b=IT4HfH0xY/5fDqK03WQfgeIC0qOR9NcXrKUgfNdidnyhJWXuzWthMmkUP9abRSxqUe IQkuckSrt6j092KL43hhEYzFZvyXKSMeHsSe42DKDVDJxTxrgQ4DM9jecXSk+nVGyaJm J6l417WTpsyBWS+dMGitVrZILpc7cmaYPdcG9tKNjF83hFb/4k2cCwMpvDeCIbzaG/TM Au3ZAx+583doKNJZqWiNc2m58zOqFIh6F1TwDhUpKCRjyXVsgV1ZVengtOhw4VgH0HFf f5ws1rNrJulfMZ3ZUItYT9gDGxyX8f2SyyqbJ6fa5N5VHsFYziQObgaD3tjUY4U1oy8a 9gZw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date; bh=yqpIoQxZ0U7BMW4pC0i583cqb27N2+gCYR2ekx+5IfY=; b=IEPuzFZw9suwEJazOKjmYtbKKOvBy/f4nxwJfccBlLN5i++Nt/p23p0I2Ss9gRaNK+ gSSZrGH1GLg8CBqO2IkJJkpJlqcT99p6QJYKcA8PKBm2heveZj7Wn1ICYFiPI+0jLCkf JTeR5VP2ffmJEMQXdioLF6KuLB0Jj13egfOJWCjCQrVV7T6zGu2w73ToKRDjkz6LjHkc nkLRJjwgqQVAX7lUSjAePupqnkdaEvifKlDocCRlVEN17Oc5D+9G9CqnWz8FT5G94M+R 7/vaLiWL1nBuAYCgmUs7sWU4AkSiLYF2lyoFzitXgwQbBCGft3GQlL4hO8WdYvOroyDK f7yw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id a3si3153015ejc.288.2020.07.23.22.26.46; Thu, 23 Jul 2020 22:27:25 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726565AbgGXF0V (ORCPT + 99 others); Fri, 24 Jul 2020 01:26:21 -0400 Received: from a.mx.secunet.com ([62.96.220.36]:56246 "EHLO a.mx.secunet.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725860AbgGXF0V (ORCPT ); Fri, 24 Jul 2020 01:26:21 -0400 Received: from localhost (localhost [127.0.0.1]) by a.mx.secunet.com (Postfix) with ESMTP id E14212052E; Fri, 24 Jul 2020 07:26:19 +0200 (CEST) X-Virus-Scanned: by secunet Received: from a.mx.secunet.com ([127.0.0.1]) by localhost (a.mx.secunet.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id cD4lS2IjMipk; Fri, 24 Jul 2020 07:26:19 +0200 (CEST) Received: from cas-essen-01.secunet.de (201.40.53.10.in-addr.arpa [10.53.40.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by a.mx.secunet.com (Postfix) with ESMTPS id 329AA201A0; Fri, 24 Jul 2020 07:26:19 +0200 (CEST) Received: from mbx-essen-01.secunet.de (10.53.40.197) by cas-essen-01.secunet.de (10.53.40.201) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1979.3; Fri, 24 Jul 2020 07:26:19 +0200 Received: from gauss2.secunet.de (10.182.7.193) by mbx-essen-01.secunet.de (10.53.40.197) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1979.3; Fri, 24 Jul 2020 07:26:18 +0200 Received: by gauss2.secunet.de (Postfix, from userid 1000) id 7147331805D5; Fri, 24 Jul 2020 07:26:18 +0200 (CEST) Date: Fri, 24 Jul 2020 07:26:18 +0200 From: Steffen Klassert To: Mark Salyzyn CC: , , , Herbert Xu , "David S. Miller" , Jakub Kicinski Subject: Re: [PATCH v2] af_key: pfkey_dump needs parameter validation Message-ID: <20200724052618.GS20687@gauss3.secunet.de> References: <20200722110059.1264115-1-salyzyn@android.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: <20200722110059.1264115-1-salyzyn@android.com> User-Agent: Mutt/1.9.4 (2018-02-28) X-ClientProxiedBy: cas-essen-01.secunet.de (10.53.40.201) To mbx-essen-01.secunet.de (10.53.40.197) X-EXCLAIMER-MD-CONFIG: 2c86f778-e09b-4440-8b15-867914633a10 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Jul 22, 2020 at 04:00:53AM -0700, Mark Salyzyn wrote: > In pfkey_dump() dplen and splen can both be specified to access the > xfrm_address_t structure out of bounds in__xfrm_state_filter_match() > when it calls addr_match() with the indexes. Return EINVAL if either > are out of range. > > Signed-off-by: Mark Salyzyn > Cc: netdev@vger.kernel.org > Cc: linux-kernel@vger.kernel.org > Cc: kernel-team@android.com > Cc: Steffen Klassert > Cc: Herbert Xu > Cc: "David S. Miller" > Cc: Jakub Kicinski > Fixes: 1da177e4c3f4 ("Linux-2.6.12-rc2") Applied, thanks a lot!