Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Fri, 24 Jul 2020 16:32:18 +0800
From:   Leo Yan <leo.yan@linaro.org>
To:     Wei Li <liwei391@huawei.com>
Cc:     Arnaldo Carvalho de Melo <acme@kernel.org>,
        Mark Rutland <mark.rutland@arm.com>,
        Alexander Shishkin <alexander.shishkin@linux.intel.com>,
        Jiri Olsa <jolsa@redhat.com>,
        Namhyung Kim <namhyung@kernel.org>,
        James Clark <james.clark@arm.com>,
        Mathieu Poirier <mathieu.poirier@linaro.org>,
        linux-kernel@vger.kernel.org,
        Peter Zijlstra <peterz@infradead.org>,
        Ingo Molnar <mingo@redhat.com>, guohanjun@huawei.com
Subject: Re: [PATCH] perf: arm-spe: Fix check error when synthesizing events
Message-ID: <20200724083218.GA5185@leoy-ThinkPad-X240s>
References: <20200724072628.35904-1-liwei391@huawei.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20200724072628.35904-1-liwei391@huawei.com>
User-Agent: Mutt/1.9.4 (2018-02-28)
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

Hi Wei,

On Fri, Jul 24, 2020 at 03:26:28PM +0800, Wei Li wrote:
> In arm_spe_read_record(), when we are processing an events packet,
> 'decoder->packet.index' is the length of payload, which has been
> transformed in payloadlen(). So correct the check of 'idx'.
>
> Signed-off-by: Wei Li <liwei391@huawei.com>

Good catch.  I checked the ARMv8 ARM and the function payloadlen(),
can confirm the fixing is correct.

Reviewed-by: Leo Yan <leo.yan@linaro.org>

> ---
>  tools/perf/util/arm-spe-decoder/arm-spe-decoder.c | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/tools/perf/util/arm-spe-decoder/arm-spe-decoder.c b/tools/perf/util/arm-spe-decoder/arm-spe-decoder.c
> index 302a14d0aca9..93e063f22be5 100644
> --- a/tools/perf/util/arm-spe-decoder/arm-spe-decoder.c
> +++ b/tools/perf/util/arm-spe-decoder/arm-spe-decoder.c
> @@ -182,15 +182,15 @@ static int arm_spe_read_record(struct arm_spe_decoder *decoder)
>  			if (payload & BIT(EV_TLB_ACCESS))
>  				decoder->record.type |= ARM_SPE_TLB_ACCESS;
>  
> -			if ((idx == 1 || idx == 2 || idx == 3) &&
> +			if ((idx == 2 || idx == 4 || idx == 8) &&
>  			    (payload & BIT(EV_LLC_MISS)))
>  				decoder->record.type |= ARM_SPE_LLC_MISS;
>  
> -			if ((idx == 1 || idx == 2 || idx == 3) &&
> +			if ((idx == 2 || idx == 4 || idx == 8) &&
>  			    (payload & BIT(EV_LLC_ACCESS)))
>  				decoder->record.type |= ARM_SPE_LLC_ACCESS;
>  
> -			if ((idx == 1 || idx == 2 || idx == 3) &&
> +			if ((idx == 2 || idx == 4 || idx == 8) &&
>  			    (payload & BIT(EV_REMOTE_ACCESS)))
>  				decoder->record.type |= ARM_SPE_REMOTE_ACCESS;
>  
> -- 
> 2.17.1
>