Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Content-Type: text/plain; charset="utf-8"
MIME-Version: 1.0
Content-Transfer-Encoding: quoted-printable
In-Reply-To: <26624b65d0e6b958c4765a406b9929d1a9ce1c2c.1594880946.git.rahul.tanwar@linux.intel.com>
References: <7ef7009b4e9f986fd6dfbf487c0e85de68a4ba9b.1594880946.git.rahul.tanwar@linux.intel.com> <26624b65d0e6b958c4765a406b9929d1a9ce1c2c.1594880946.git.rahul.tanwar@linux.intel.com>
Subject: Re: [PATCH v2 3/3] clk: intel: Avoid unnecessary memset by improving code
From:   Stephen Boyd <sboyd@kernel.org>
Cc:     linux-kernel@vger.kernel.org, andriy.shevchenko@intel.com,
        qi-ming.wu@intel.com, yixin.zhu@linux.intel.com,
        cheol.yong.kim@intel.com, rahul.tanwar.linux@gmail.com,
        Rahul Tanwar <rahul.tanwar@linux.intel.com>
To:     Rahul Tanwar <rahul.tanwar@linux.intel.com>,
        linux-clk@vger.kernel.org, mturquette@baylibre.com
Date:   Fri, 24 Jul 2020 01:56:19 -0700
Message-ID: <159558097978.3847286.7904651694237654748@swboyd.mtv.corp.google.com>
User-Agent: alot/0.9.1
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

Quoting Rahul Tanwar (2020-07-15 23:30:32)
> memset can be avoided in a loop if the variables used are declared
> inside the loop. Move such variables declaration inside the loop
> to avoid memset.
>=20
> Signed-off-by: Rahul Tanwar <rahul.tanwar@linux.intel.com>
> ---
>  drivers/clk/x86/clk-cgu.c | 7 +++----
>  1 file changed, 3 insertions(+), 4 deletions(-)
>=20
> diff --git a/drivers/clk/x86/clk-cgu.c b/drivers/clk/x86/clk-cgu.c
> index c379fedfb9f2..9a1be7035fd0 100644
> --- a/drivers/clk/x86/clk-cgu.c
> +++ b/drivers/clk/x86/clk-cgu.c
> @@ -581,19 +581,18 @@ int lgm_clk_register_ddiv(struct lgm_clk_provider *=
ctx,
>                           unsigned int nr_clk)
>  {
>         struct device *dev =3D ctx->dev;
> -       struct clk_init_data init =3D {};
> -       struct lgm_clk_ddiv *ddiv;
>         struct clk_hw *hw;
>         unsigned int idx;
>         int ret;
> =20
>         for (idx =3D 0; idx < nr_clk; idx++, list++) {
> -               ddiv =3D NULL;
> +               struct clk_init_data init =3D {};
> +               struct lgm_clk_ddiv *ddiv =3D NULL;

Assigning to NULL isn't necessary...

> +
>                 ddiv =3D devm_kzalloc(dev, sizeof(*ddiv), GFP_KERNEL);

because it's assigned right here. I'll just fix it.

>                 if (!ddiv)
>                         return -ENOMEM;
> =20
> -               memset(&init, 0, sizeof(init));
>                 init.name =3D list->name;
>                 init.ops =3D &lgm_clk_ddiv_ops;
>                 init.flags =3D list->flags;