Received: by 2002:a25:e74b:0:0:0:0:0 with SMTP id e72csp2121600ybh; Fri, 24 Jul 2020 05:05:16 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxh8an0XGrmUu78iY0R/fOOBi1OvVy2/8XOzfiqwpYa2L5mP4f8yMGSVpJLwpIe2Jydwso7 X-Received: by 2002:aa7:c656:: with SMTP id z22mr8919085edr.101.1595592315924; Fri, 24 Jul 2020 05:05:15 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1595592315; cv=none; d=google.com; s=arc-20160816; b=pQSW5/YyFPH/422rseGoy3a9bzRGQ/iQWkA9EvJzuwtt3KExah7V0I3O/o+SjqR5gF SQDASvJw0BfG+x3p7XrtC3lGhTI9Xjp+rBOEizgUYHn+V8klV4itqAMVeDdvRvEsk2OH vbyqD5J0VuDKjAKsv1PSxLlix8M7Sqp6CeNirlTtBAx/UVXy2CQwQpBDYp1NT9DZBam7 4QHj4FSJJclI8l85HCJKRjP76mpD2T2YTblk/ymGhzefM1p2RzANE/oTCdO/+8Ebf3sW U3RCWG3+BZLtWJ+132Yep9rVJVBmPRjedJuIJjcHYc50NeHPlw45n7b1cqwbFuY7LEgX g52A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding :robot-unsubscribe:robot-id:message-id:mime-version:references :in-reply-to:cc:subject:to:reply-to:from:dkim-signature :dkim-signature:date; bh=G9/bQiuMXBJXcb9ufzaf/3ECaiQiQB1+J3WjwdA+kc4=; b=DP8LYMIuCJyuhP7hldt3bYZM1ejQKPRcVaByobngLXlvCrJhYUTJwSi9e3D4zWjcvL tSmAmVuQXsKMZdUdvJ5Ybf/iDubh6YLyGs+5QTSYS2Hm1BhS4lpGsteP4ghZ72jcWqB8 VCb6I+EIIvjspfAXhGOYWYZ746B3A77W85W7UukpUTUkLxwREh00HLcT2CdAdilyTy4S QXyBksuTQ6tMDB/1EqTo+XosHLQu85FMfO1fkDpZIYjnrPAemIfgqudKlIoA/Ik6wc+b nUBpKjA5Z9Cgq0/pzHGnZYJo1gyTPZlFT5y/btYcjP6Ib0cxV0lyAZ8PBqOImSiVpvEG Z4YQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail header.i=@linutronix.de header.s=2020 header.b=STiQQZ5l; dkim=neutral (no key) header.i=@linutronix.de header.s=2020e header.b=vog9Butn; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=QUARANTINE dis=NONE) header.from=linutronix.de Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id dt7si588253ejc.389.2020.07.24.05.04.52; Fri, 24 Jul 2020 05:05:15 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=fail header.i=@linutronix.de header.s=2020 header.b=STiQQZ5l; dkim=neutral (no key) header.i=@linutronix.de header.s=2020e header.b=vog9Butn; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=QUARANTINE dis=NONE) header.from=linutronix.de Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726854AbgGXMCc (ORCPT + 99 others); Fri, 24 Jul 2020 08:02:32 -0400 Received: from Galois.linutronix.de ([193.142.43.55]:37730 "EHLO galois.linutronix.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726493AbgGXMC0 (ORCPT ); Fri, 24 Jul 2020 08:02:26 -0400 Date: Fri, 24 Jul 2020 12:02:23 -0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linutronix.de; s=2020; t=1595592144; h=from:from:sender:sender:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=G9/bQiuMXBJXcb9ufzaf/3ECaiQiQB1+J3WjwdA+kc4=; b=STiQQZ5lIZpAYf1MN7mjjVUBKq7nC9vgR9kzICLa0hGT38Fs3FocksmL40/fAn/QOMRvTk C+ud/F8L4WAhDUzQxpaMDBYWdk8gp4E9CWeLxdIwXPQwsl/A78LEl4ocpyMN0HLupMh61n 62piRlqZ2VR03uXmUyZ+igQ7hUbxDTmkXdGtZrxO6te1HN6btTLsRxW74r+lpFRwwNHekX U7yHLsVizk1xCE+m2VgmbzVo1wLBU5nuyMQs+a8YaDE9s1dYKHaroklgiVWkTSRqZa2PhP wqKfCeSl74hew9aY4iPAAsBcYMttL5pBZThauqcZk2DOwfb7gRl6MCjuQlXMMw== DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=linutronix.de; s=2020e; t=1595592144; h=from:from:sender:sender:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=G9/bQiuMXBJXcb9ufzaf/3ECaiQiQB1+J3WjwdA+kc4=; b=vog9Butn+GaeAVwwU7DXySjWclWrM2qkO6z/GKHcwNy8AES8OA4VLHaFdjYrBvYQKUJVIK /h4bODmvpgyeXlBQ== From: "tip-bot2 for Chris Wilson" Reply-to: linux-kernel@vger.kernel.org To: linux-tip-commits@vger.kernel.org Subject: [tip: sched/core] sched: Warn if garbage is passed to default_wake_function() Cc: Chris Wilson , Ingo Molnar , Peter Zijlstra , x86 , LKML In-Reply-To: <20200723201042.18861-1-chris@chris-wilson.co.uk> References: <20200723201042.18861-1-chris@chris-wilson.co.uk> MIME-Version: 1.0 Message-ID: <159559214399.4006.3614094592571422254.tip-bot2@tip-bot2> Robot-ID: Robot-Unsubscribe: Contact to get blacklisted from these emails Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org The following commit has been merged into the sched/core branch of tip: Commit-ID: da3520d750e36051ecd5847ef712659b9c68ce20 Gitweb: https://git.kernel.org/tip/da3520d750e36051ecd5847ef712659b9c68ce20 Author: Chris Wilson AuthorDate: Thu, 23 Jul 2020 21:10:42 +01:00 Committer: Ingo Molnar CommitterDate: Fri, 24 Jul 2020 13:47:12 +02:00 sched: Warn if garbage is passed to default_wake_function() Since the default_wake_function() passes its flags onto try_to_wake_up(), warn if those flags collide with internal values. Given that the supplied flags are garbage, no repair can be done but at least alert the user to the damage they are causing. In the belief that these errors should be picked up during testing, the warning is only compiled in under CONFIG_SCHED_DEBUG. Signed-off-by: Chris Wilson Signed-off-by: Ingo Molnar Acked-by: Peter Zijlstra Link: https://lore.kernel.org/r/20200723201042.18861-1-chris@chris-wilson.co.uk --- kernel/sched/core.c | 1 + 1 file changed, 1 insertion(+) diff --git a/kernel/sched/core.c b/kernel/sched/core.c index bd8e521..637365e 100644 --- a/kernel/sched/core.c +++ b/kernel/sched/core.c @@ -4686,6 +4686,7 @@ asmlinkage __visible void __sched preempt_schedule_irq(void) int default_wake_function(wait_queue_entry_t *curr, unsigned mode, int wake_flags, void *key) { + WARN_ON_ONCE(IS_ENABLED(CONFIG_SCHED_DEBUG) && wake_flags & ~WF_SYNC); return try_to_wake_up(curr->private, mode, wake_flags); } EXPORT_SYMBOL(default_wake_function);