Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Fri, 24 Jul 2020 14:12:50 +0200
From:   Ingo Molnar <mingo@kernel.org>
To:     Nick Terrell <nickrterrell@gmail.com>
Cc:     Borislav Petkov <bp@alien8.de>,
        Thomas Gleixner <tglx@linutronix.de>,
        linux-kernel@vger.kernel.org, Chris Mason <clm@fb.com>,
        linux-kbuild@vger.kernel.org, x86@kernel.org,
        gregkh@linuxfoundation.org, Petr Malat <oss@malat.biz>,
        Kees Cook <keescook@chromium.org>,
        Kernel Team <Kernel-team@fb.com>,
        Adam Borowski <kilobyte@angband.pl>,
        Patrick Williams <patrickw3@fb.com>, rmikey@fb.com,
        Patrick Williams <patrick@stwcx.xyz>,
        Sedat Dilek <sedat.dilek@gmail.com>,
        Norbert Lange <nolange79@gmail.com>,
        Andrew Morton <akpm@linux-foundation.org>,
        Alex Xu <alex_y_xu@yahoo.ca>,
        Arvind Sankar <nivedita@alum.mit.edu>,
        Nick Terrell <terrelln@fb.com>
Subject: Re: [PATCH v8 2/7] lib: add zstd support to decompress
Message-ID: <20200724121250.GA632343@gmail.com>
References: <20200723192801.351114-1-nickrterrell@gmail.com>
 <20200723192801.351114-3-nickrterrell@gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20200723192801.351114-3-nickrterrell@gmail.com>
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk


* Nick Terrell <nickrterrell@gmail.com> wrote:

> +/* Size of the input and output buffers in multi-call mode.
> + * Pick a larger size because it isn't used during kernel decompression,
> + * since that is single pass, and we have to allocate a large buffer for
> + * zstd's window anyways. The larger size speeds up initramfs decompression.
> + */
> +#define ZSTD_IOBUF_SIZE		(1 << 17)

Nit: s/anyways/anyway

Also, please use the customary (multi-line) comment style:

  /*
   * Comment .....
   * ...... goes here.
   */

specified in Documentation/CodingStyle.

Thanks,

        Ingo