Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Fri, 24 Jul 2020 14:17:16 +0200
From:   Ingo Molnar <mingo@kernel.org>
To:     Randy Dunlap <rdunlap@infradead.org>
Cc:     Nick Terrell <nickrterrell@gmail.com>,
        Borislav Petkov <bp@alien8.de>,
        Thomas Gleixner <tglx@linutronix.de>,
        linux-kernel@vger.kernel.org, Chris Mason <clm@fb.com>,
        linux-kbuild@vger.kernel.org, x86@kernel.org,
        gregkh@linuxfoundation.org, Petr Malat <oss@malat.biz>,
        Kees Cook <keescook@chromium.org>,
        Kernel Team <Kernel-team@fb.com>,
        Adam Borowski <kilobyte@angband.pl>,
        Patrick Williams <patrickw3@fb.com>, rmikey@fb.com,
        Patrick Williams <patrick@stwcx.xyz>,
        Sedat Dilek <sedat.dilek@gmail.com>,
        Norbert Lange <nolange79@gmail.com>,
        Andrew Morton <akpm@linux-foundation.org>,
        Alex Xu <alex_y_xu@yahoo.ca>,
        Arvind Sankar <nivedita@alum.mit.edu>,
        Nick Terrell <terrelln@fb.com>
Subject: Re: [PATCH v8 3/7] init: add support for zstd compressed kernel
Message-ID: <20200724121716.GB632343@gmail.com>
References: <20200723192801.351114-1-nickrterrell@gmail.com>
 <20200723192801.351114-4-nickrterrell@gmail.com>
 <9ff49261-f5fd-b8dd-949a-0b8eab75369b@infradead.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <9ff49261-f5fd-b8dd-949a-0b8eab75369b@infradead.org>
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk


* Randy Dunlap <rdunlap@infradead.org> wrote:

> On 7/23/20 12:27 PM, Nick Terrell wrote:
> > +config KERNEL_ZSTD
> > +	bool "ZSTD"
> > +	depends on HAVE_KERNEL_ZSTD
> > +	help
> > +	  ZSTD is a compression algorithm targeting intermediate compression
> > +	  with fast decompression speed. It will compress better than GZIP and
> > +	  decompress around the same speed as LZO, but slower than LZ4. You
> > +	  will need at least 192 KB RAM or more for booting. The zstd command
> > +	  line tools is required for compression.
> 
> 	       tools are required

Since 'zstd' is the singular tool required for compression AFAICS:

   LZ4            = lz4c
   XZ             = xz
  +ZSTD           = zstd

"The zstd command line tool is required for compression" is the 
intended wording I'd say?

Thanks,

	Ingo