Received: by 2002:a25:e74b:0:0:0:0:0 with SMTP id e72csp2145438ybh; Fri, 24 Jul 2020 05:41:09 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzUcJokHluEKBWSFLdu+/hh4apZpg/Xo5DPKYbMS7OQDMe+uCWIwZuTw0x16GBOahoawvUy X-Received: by 2002:a17:906:5912:: with SMTP id h18mr9448700ejq.259.1595594468925; Fri, 24 Jul 2020 05:41:08 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1595594468; cv=none; d=google.com; s=arc-20160816; b=QN5rpOKFBGeYVnuFpaWFd3SNEEHbGRfZPFS0w71JYJkWGK8mdGaH+3MtoX0fHQxXQZ t3ppwNXiB4WZktvCZuK2q6OdRlZ5MTiFY+Vqe2auWcDqYSTYHoPqS+kUJiw9ICn1zqy1 9hR09jo02Kpom5JxSWebpoulbrNtbTXjnaMUgHLcKE5Tfo4aHosL8s4pb7jJkB74kYEv E5EIuIH1dCEfAENwmg4RTRvSkDQYoy1DemrvoPhXdpoGozJhr/mWFlxYxsfl+TVPP8Jv r0/ur4DQjAPdyMSEyG4g+AF1jjBTMsD4D/jIJnR6eXgNFC7N15t85bJrPJOAxRMD1Cye 1sSQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:dkim-signature; bh=hITZ0rNuNZdzv6aASsIGDY5KNIH8glBNT6+akNE1P8o=; b=zKq+LgVl6CuXuz32+XPBd9wUMZ23iS8oZMTeOREv3Tf/lf8/+apbp9KIzdAcPWfNmx 4FfFHhSa++z1iZz9mhg2KhZtkjbmJNj7z67FiR0Xs3L6fwHQizeuqUGYoeFouj27Mhzq 2Iiu2E0HE8X3q0sA2+Vnwc4G52srWbx2M4zlDVOZbs/uCfhEejBFK49H1uNO+3n/pM45 uHhUCL3zPMECwcD3fNwCoL8nmsEN5lv0YoTTBsb2Qhfl4q0W8DM71nCruWuALZ1d9jEb OcPlS9nKIDAkPhrnpOpZYZAR8vbp+K114TKtfRH99PBOM1y+jI0qDxZAOxL+XBXxdFtI Gw0A== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@st.com header.s=STMicroelectronics header.b="oPV/csVA"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=st.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id r15si512667eja.493.2020.07.24.05.40.46; Fri, 24 Jul 2020 05:41:08 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@st.com header.s=STMicroelectronics header.b="oPV/csVA"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=st.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726956AbgGXMiS (ORCPT + 99 others); Fri, 24 Jul 2020 08:38:18 -0400 Received: from mx08-00178001.pphosted.com ([91.207.212.93]:35438 "EHLO mx07-00178001.pphosted.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1726411AbgGXMiJ (ORCPT ); Fri, 24 Jul 2020 08:38:09 -0400 Received: from pps.filterd (m0046661.ppops.net [127.0.0.1]) by mx07-00178001.pphosted.com (8.16.0.42/8.16.0.42) with SMTP id 06OCbmn3030431; Fri, 24 Jul 2020 14:37:56 +0200 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=st.com; h=from : to : cc : subject : date : message-id : in-reply-to : references : mime-version : content-type; s=STMicroelectronics; bh=hITZ0rNuNZdzv6aASsIGDY5KNIH8glBNT6+akNE1P8o=; b=oPV/csVAuyyFnhgTBy6hXaSEMDDcsjG3J5J3FWwkSMQ316F3cyZPhevOdYH+HLLFK6y0 n3sQduS5LwI/ci0i80Fp8CtIJcgSqFHoZKt/fJhwreb0cyykZLfgM9FB7buZez0iytMA i7LCx1IxH8lBPQ+sNl0chC4OPfyPalub3/mirgtBx0Vt3+7VdLRWIKw62OOlNNXdRgNd mo6kaEf9FItLM6xsT9n5myJPMWlFkVnbAvrctuez43fccfOw1htF12QjbDNdI4jT6xnZ nTTVVQy40neJ+kd5MXSUc74O4C0quVdZAX8z2PY/7dzaHj9179tFpbNL659aeIBj26rl 1g== Received: from beta.dmz-eu.st.com (beta.dmz-eu.st.com [164.129.1.35]) by mx07-00178001.pphosted.com with ESMTP id 32bsahgcgu-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Fri, 24 Jul 2020 14:37:56 +0200 Received: from euls16034.sgp.st.com (euls16034.sgp.st.com [10.75.44.20]) by beta.dmz-eu.st.com (STMicroelectronics) with ESMTP id 98A0910002A; Fri, 24 Jul 2020 14:37:55 +0200 (CEST) Received: from Webmail-eu.st.com (sfhdag3node2.st.com [10.75.127.8]) by euls16034.sgp.st.com (STMicroelectronics) with ESMTP id 8ADD82AF334; Fri, 24 Jul 2020 14:37:55 +0200 (CEST) Received: from localhost (10.75.127.44) by SFHDAG3NODE2.st.com (10.75.127.8) with Microsoft SMTP Server (TLS) id 15.0.1347.2; Fri, 24 Jul 2020 14:37:55 +0200 From: Amelie Delaunay To: Minas Harutyunyan , Felipe Balbi , Greg Kroah-Hartman , Rob Herring , Maxime Coquelin , Alexandre Torgue CC: , , , , , Fabrice Gasnier , Amelie Delaunay , Martin Blumenstingl Subject: [PATCH 4/4] usb: dwc2: fix error path with missing dwc2_drd_exit Date: Fri, 24 Jul 2020 14:37:48 +0200 Message-ID: <20200724123748.25369-5-amelie.delaunay@st.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20200724123748.25369-1-amelie.delaunay@st.com> References: <20200724123748.25369-1-amelie.delaunay@st.com> MIME-Version: 1.0 Content-Type: text/plain X-Originating-IP: [10.75.127.44] X-ClientProxiedBy: SFHDAG8NODE2.st.com (10.75.127.23) To SFHDAG3NODE2.st.com (10.75.127.8) X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:6.0.235,18.0.687 definitions=2020-07-24_04:2020-07-24,2020-07-24 signatures=0 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org In case of failure, role switch has to be unregistered. It is done by dwc2_drd_exit. Fixes: bc0f0d4a5853 ("usb: dwc2: override PHY input signals with usb role switch support") Reported-by: kernel test robot Signed-off-by: Amelie Delaunay --- drivers/usb/dwc2/platform.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/usb/dwc2/platform.c b/drivers/usb/dwc2/platform.c index 68b56b43a45e..f4a0371c3e89 100644 --- a/drivers/usb/dwc2/platform.c +++ b/drivers/usb/dwc2/platform.c @@ -600,6 +600,8 @@ static int dwc2_driver_probe(struct platform_device *dev) return 0; error_init: + dwc2_drd_exit(hsotg); + if (hsotg->params.activate_stm_id_vb_detection) regulator_disable(hsotg->usb33d); error: -- 2.17.1