Received: by 2002:a25:e74b:0:0:0:0:0 with SMTP id e72csp2149082ybh; Fri, 24 Jul 2020 05:47:32 -0700 (PDT) X-Google-Smtp-Source: ABdhPJz0rwNLvByhrZ9ZfxfL8+CxnJBdi5GJrpvtlaWHbveNZDrX9aVO6sMEJPOKHx0mYH6h9t+H X-Received: by 2002:a05:6402:21e6:: with SMTP id ce6mr4232117edb.275.1595594852585; Fri, 24 Jul 2020 05:47:32 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1595594852; cv=none; d=google.com; s=arc-20160816; b=XtSXcpv5i7nv8xihS84v/o4R4TL790PRD93oM6kXTgyZKrSocRFNWcbX14NSEn/5CX ubvNF+iRztDyxxQkjxXDTK+o/wFHXZ43+qs90brHAR5wCsbcFKHsAVGbiMu5QSNFM5UB 5gXE64ex5jr8MIECCxqAK53pM9mm91vEY0BqebRoJ+eLwf00DKvtTxbxxv/Kdr0f2HCK Bt7dUf1rcXT/6gArQIlU/mZkJjf0u/AjqVbAeQqtYumvLc9RO+VtrZ9K8VIZkOne5r3w BVqnULEAmxOAhVe3PTv7cr6yHVfCDIs81FTWnDO6auTVWwNdKgSyLGTlKXfJzVGj2LgJ ysqg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:dkim-signature; bh=FGHawDNNHiCHWgrOxcXKqCSMD7oEiI1UqCmKADBljuU=; b=DgPi7B1aOYvdEvp6sgBG/aBCsQ/xCGE4pnumLGtoCGyScOpI30kPkK9pFPpjbh2Hqt kkwE4rxBWx8rtZvzppZR5AGcEQn1FXwdyYy4l1qWwVj/e5em7EB1n4mIcoQnrJrx4IwM 19JaefI7A85I4/tM4eY2yFPYEC/KccAVp+y6Ij4QNJcKp5qGD+r/feUmtcfhCULxbFgW vgcZICXG/777oaaTyIhMZL6t39z0vaKCoOXeLDc0qJRHH6APKeLm75HQvXtsRIbmMFV5 f//wA1ZHHdi+r50KJ9CozQCyRLfwddVHWe+B0IhbuKoskm70QNvETOeJDjWdSwRhFUw/ kh8g== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=EuAwwFRW; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id e23si519418eja.122.2020.07.24.05.47.10; Fri, 24 Jul 2020 05:47:32 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=EuAwwFRW; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727112AbgGXMoU (ORCPT + 99 others); Fri, 24 Jul 2020 08:44:20 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:58740 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726483AbgGXMoT (ORCPT ); Fri, 24 Jul 2020 08:44:19 -0400 Received: from mail-vs1-xe44.google.com (mail-vs1-xe44.google.com [IPv6:2607:f8b0:4864:20::e44]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 46C68C0619E5 for ; Fri, 24 Jul 2020 05:44:19 -0700 (PDT) Received: by mail-vs1-xe44.google.com with SMTP id j186so4795732vsd.10 for ; Fri, 24 Jul 2020 05:44:19 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=FGHawDNNHiCHWgrOxcXKqCSMD7oEiI1UqCmKADBljuU=; b=EuAwwFRWeuUdb4vF35T0sjuH5dKD0BasNwv6q+tQLoNCduhL0GWSu7acttBEE3iv1H bjK3j7nBVDXvHpMygDOgB/y1hWSgES61TVbuJCpr5iBiZuBSSEwo+9b0oVR3jhDxAtRx UNKAU8CRfgMVR0ZeNRGN4w0yIX6LkRxIiFL/Xsme9m/0kt5bdvN7Rk6byC9Swb+auhbI c2TD/rY5ENrsNnfZmnuh8zJ0mfiuK/2aYSEB4m9eqy4IQJcfXr+UtbMp5rlsNxmnRs6d fjwfLn9fg2+ssivzVRjo8yVs4khRFeKgUgX6O8zn/chNccrgLUnT2x/QoJkUFzgauZ1y onMg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=FGHawDNNHiCHWgrOxcXKqCSMD7oEiI1UqCmKADBljuU=; b=CEzk1a4xIeJfi1oISypEpCYTBhNc1oBDWIvaroMqOiUrBD8xDDaLFbeKMqpoDDrW8Y dT+u75ggngrFC3c+dmojnyfD3RAMIIE3rANNuV7sSI4P5JH3KeY4G5thb1xgvyAg2brv rddPLXnLdqFqUfbpqIF3blsQbFjUPclWHTgeRa3wSOi5zfB4H8rNOMV+Jwnw58Dnbc4O RjNAaGCHBMa9Fih/rShvWk/oPwSLVSr6GIKEYIZmLFhs+7Fna7gj0pgeOWmGpc5RUWLP LjNo/EERh1tdjb8URNpsHLDd7ej+9HmFRLUAlWa8HYJC1DBRScln2uzeQnMsZtW2/PNT wcZg== X-Gm-Message-State: AOAM530qFOPlHeeGRtB5rHkB6qGZaKmAZkdq+fdKqQP2yZno8lLWKTvm undRbMIAbf3kODBt9PzEkOBvbWeDDWXdoFO0Tn09fw== X-Received: by 2002:a67:f98c:: with SMTP id b12mr7556870vsq.34.1595594658333; Fri, 24 Jul 2020 05:44:18 -0700 (PDT) MIME-Version: 1.0 References: <20200618141326.25723-1-lars.povlsen@microchip.com> <20200618141326.25723-3-lars.povlsen@microchip.com> <87wo2vkbns.fsf@soft-dev15.microsemi.net> <87zh7pf8sg.fsf@soft-dev15.microsemi.net> In-Reply-To: <87zh7pf8sg.fsf@soft-dev15.microsemi.net> From: Ulf Hansson Date: Fri, 24 Jul 2020 14:43:41 +0200 Message-ID: Subject: Re: [PATCH v4 2/3] sdhci: sparx5: Add Sparx5 SoC eMMC driver To: Lars Povlsen Cc: Adrian Hunter , SoC Team , Microchip Linux Driver Support , "linux-mmc@vger.kernel.org" , DTML , Linux ARM , Linux Kernel Mailing List , Alexandre Belloni Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, 24 Jul 2020 at 13:32, Lars Povlsen wrote: > > > Ulf Hansson writes: > > > On Wed, 22 Jul 2020 at 13:54, Lars Povlsen wrote: > >> > >> > >> Adrian Hunter writes: > >> > >> > On 18/06/20 5:13 pm, Lars Povlsen wrote: > >> >> This adds the eMMC driver for the Sparx5 SoC. It is based upon the > >> >> designware IP, but requires some extra initialization and quirks. > >> >> > >> >> Signed-off-by: Lars Povlsen > >> > > >> > Acked-by: Adrian Hunter > >> > > >> > >> Adrian, > >> > >> Thanks for the ack. I was expecting to see this in linux-next, anything > >> holding it back? > >> > >> pinctrl and hwmon drivers have been merged. > >> > >> Thanks, > > > > Hi Lars, > > > > Looks like you got some feedback on the DT patch (patch1/3) from Rob. > > I didn't find that you have addressed them and therefore I am holding > > back on the $subject patch as well. > > > > Uffe, thank you for responding. > > The automated checker complains about the inclusion of a header file > (#include ) in the example. The > header file itself is part of the "parent" patch series sent to arm-soc, > but is needed to make the example complete. > > I e-mailed Rob about how to handle this, but never got a reply. > > Can you suggest how to deal with this? I have checked the schema with > dt_binding_check manually - with the header file in place. I see, thanks for clarifying. When this kind of dependy happens, we have a couple of options. 1. Wait for a new rc to have the dependent changes included. 2. Share the changes between maintainers's git trees, through immutable branches. Looks like 1) would be easiest here. So, I suggest you re-post the series when v5.9-rc1 is out. > > I can of course remove the include and associated properties, but that > will make the example incomplete and irrelevant. No, that doesn't sound right. [...] Kind regards Uffe