Received: by 2002:a25:e74b:0:0:0:0:0 with SMTP id e72csp2230332ybh; Fri, 24 Jul 2020 07:40:05 -0700 (PDT) X-Google-Smtp-Source: ABdhPJyzSFcp4Dr6FuWNlSADi5rkc4L7Khs9ei7R8dy9zAshsKsW/4tVpbZvvgEIW+ZqONaKNKvh X-Received: by 2002:a17:906:b146:: with SMTP id bt6mr9430772ejb.138.1595601604985; Fri, 24 Jul 2020 07:40:04 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1595601604; cv=none; d=google.com; s=arc-20160816; b=DJlvFxftzgNG68dQz3I88/ncuQ1RXMNjFa699FmcC18zOugRlidOI0FethJ7WhcN8R YHloZiFw6k3GrvLmVlH2ZVBK5zxNPXDXp7NsZaHynjYyQfQK9OQGWaMMSnmD1Boac4Tq eJJ1N5QIOUEvz3zlKh78FtiJnR/nCwRzkEpANYMHI6M6KI70Jmgsp1ygnQyJev2U5ZVm PXOP9RMAEHpQFak7SJQ9Sc+j1KDOGdNX9Df9vT+CDaSmWsFOBtt+ikx6tsPsXQQvhfSX 5b15JJJMSvac9/GSJ/Se4meCyn/gtFuo/xR/D/4EbPc3ojGBJiAtVbbuRpgKkcvF3lJo wNlw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:in-reply-to:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :ironport-sdr:ironport-sdr; bh=c/zlKgXv/+X7PGn/EE3GmKNBlRtuNBhPB2Js3EabuWA=; b=M4p6aP68PYFQudz0J0ewc31qahuEF1UeM3wVkpdUUa+yQSG5TIuSkDTna5xOzRowSp 5Q6lKjyTl1ivoRalXl7YInMO/yxBphgYJvfFEkmxfzDzWLavXAz77Pl5u0r7IO/DH9nV zsCI68XuQT9VEY+BvLuZ4UzmvFv6HKc06Y59XvdEawas5JyLiVtRN3Do6iqalu8l/DL0 m4Xt6ArIHufyBVX3kLskTRQ6IprCj4LM2TB1/Msj9IT5Qm1v5YtVWbSaq7QKpuQJJPz0 DcG0+yJVPq5P17L9tJ1GjGCTXw1PT2UQ9L166ENLbW+EsXoOyVEbjPvWY6bOq6hSua7x xC6g== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=intel.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id dc14si608176edb.240.2020.07.24.07.39.42; Fri, 24 Jul 2020 07:40:04 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726782AbgGXOjK (ORCPT + 99 others); Fri, 24 Jul 2020 10:39:10 -0400 Received: from mga18.intel.com ([134.134.136.126]:62746 "EHLO mga18.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726658AbgGXOjJ (ORCPT ); Fri, 24 Jul 2020 10:39:09 -0400 IronPort-SDR: xFsb1O4KeEi/zoTtXzRNq9AXk2L1ikdxFHseZsUiIR858b2js2TMis8g94mSkI5KAL8mltaPr5 WMG94WTL89Aw== X-IronPort-AV: E=McAfee;i="6000,8403,9691"; a="138218393" X-IronPort-AV: E=Sophos;i="5.75,391,1589266800"; d="scan'208";a="138218393" X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga006.fm.intel.com ([10.253.24.20]) by orsmga106.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 24 Jul 2020 07:39:09 -0700 IronPort-SDR: ifAd3cKGAuEsmBo0T3lYxM9fJTmzHo+Zm2oBBiTYKMkE3F1oC1aITZIPqXBQiQRHb+piW8oJx6 zjJIXvdDn9GQ== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.75,391,1589266800"; d="scan'208";a="488758608" Received: from tassilo.jf.intel.com (HELO tassilo.localdomain) ([10.7.201.21]) by fmsmga006.fm.intel.com with ESMTP; 24 Jul 2020 07:39:08 -0700 Received: by tassilo.localdomain (Postfix, from userid 1000) id E996D301BF9; Fri, 24 Jul 2020 07:39:08 -0700 (PDT) Date: Fri, 24 Jul 2020 07:39:08 -0700 From: Andi Kleen To: peterz@infradead.org Cc: kan.liang@linux.intel.com, acme@redhat.com, mingo@kernel.org, linux-kernel@vger.kernel.org, jolsa@kernel.org, eranian@google.com, alexander.shishkin@linux.intel.com, like.xu@linux.intel.com Subject: Re: [PATCH V7 07/14] perf/core: Add a new PERF_EV_CAP_COEXIST event capability Message-ID: <20200724143908.GC1180481@tassilo.jf.intel.com> References: <20200723171117.9918-1-kan.liang@linux.intel.com> <20200723171117.9918-8-kan.liang@linux.intel.com> <20200724105543.GV119549@hirez.programming.kicks-ass.net> <20200724114628.GJ43129@hirez.programming.kicks-ass.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200724114628.GJ43129@hirez.programming.kicks-ass.net> Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org > The consequence is that SLOTS must be the leader, is that really a > problem? You keep providing the {cycles, slots, metric-things} example, Yes that's a problem. One (major) use case for topdown is to sample on lots of different events, but always create groups that also measure topdown metrics for that sampling period. For that we need other leaders. -Andi