Received: by 2002:a25:e74b:0:0:0:0:0 with SMTP id e72csp2239054ybh; Fri, 24 Jul 2020 07:53:05 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzKjkZ1iH0B/DDpE3IWOTj/Aw+DIE8qdqrs+RGraUkoZs1VZMA7GAWqouFvfdqOCcIXq/K3 X-Received: by 2002:a17:906:2e06:: with SMTP id n6mr9364976eji.34.1595602385310; Fri, 24 Jul 2020 07:53:05 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1595602385; cv=none; d=google.com; s=arc-20160816; b=RRA39eqlrp28zj1qfgLR5loDBlmAxRZrpASOgmdKSIEJCUCzhKq4a4En1KQ8JrgGza 3P3vc3jKqdaX1IH3BXyBSbCO94VaYf2mS2E+3y5OGSEh/iSrke7/geSo2xXdk/9kDHkB TdOdZnrw5mBIlY64fb7jcTm5it34K09MGpfXgBlcga9j9BO8LdgWWKqtoV7IkEWDGuFd O9f0lTWt940UaowLleY5eTKbt1rKKYUSz5prJpFmRTUh/e7Y4ODGXeVKvWll6me6GBT/ b/ocK4csefVBmfTfAkdCG7vheZaZJ2GdOzghuigeo5qyRluOMHpOySQzrwtGGM66fbJC /+Jg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding :content-language:in-reply-to:mime-version:user-agent:date :message-id:from:references:cc:to:subject:dkim-signature; bh=sbSetUwrSbr+vfh9kXLAONxXQfhjpBwlhJKLTwQ8Bb0=; b=h+6eu06ggwmC4vvET1tw5x3uSe8zlFNoWoHpmM0ZQynnOM/Tib3dteIbB1AP7hWPBd nOPPr8rQazjFGkrFa70ppOoR+ns+VbeadGXM0lRNln546tLm1VN77sAYhB74MaX38j6u md535iAhavWaUGvzy83ksE0Xtwwjm8T24BKKzlPKjG+dfAoJmILZkboxIOHfQiy56gZA 6K4nKt1zWAHCmPN9NM0sWd6CE8may5DJC9gZpyD/0jiw8alYJm8BuzV6BhqGlX9PctO1 u1ci/Q1hdeQgHsHQa6vROI/DyTL4b5iQt47xUq9u4rFVE0CYr19+NRKdDGnbhFMhm9ON T/3g== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=i5z8gThr; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id d23si719917ejz.145.2020.07.24.07.52.42; Fri, 24 Jul 2020 07:53:05 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=i5z8gThr; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726747AbgGXOuG (ORCPT + 99 others); Fri, 24 Jul 2020 10:50:06 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:50146 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726650AbgGXOuG (ORCPT ); Fri, 24 Jul 2020 10:50:06 -0400 Received: from mail-wr1-x443.google.com (mail-wr1-x443.google.com [IPv6:2a00:1450:4864:20::443]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id CFDAFC0619E4 for ; Fri, 24 Jul 2020 07:50:05 -0700 (PDT) Received: by mail-wr1-x443.google.com with SMTP id f2so8559704wrp.7 for ; Fri, 24 Jul 2020 07:50:05 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=sbSetUwrSbr+vfh9kXLAONxXQfhjpBwlhJKLTwQ8Bb0=; b=i5z8gThrFymRsCnvkaoVzoEx5yGuK/LL8XHkzaCJLTevTT9PAw0VYe1yZQmtoMq9Lp +QKaOL+DWQTrGR8fbW6D10nlFDG4gt4ZnOKT6YpTk1e05mZc12DFSWk0g4iZAZryKAar uh/vgzzwtSj9wOePrfZJ3ndzXM0Jy460UCL3asQ/yrcLKH9taUFZzPC4+7oyjl+I6B5C ZGwf65Z+NlPUSsMohWlyTpV+74C+pIkhpmMZrxPQTa/7g9/kUcav+/rt+fGNw3kw+v4J Pmmp9VpzMw9dNBfsNQLNVNQ3oWigWY8cRNj/zgqfJpMHkzyNdsL+hiBmLXA8mG+e/lSO NVxw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=sbSetUwrSbr+vfh9kXLAONxXQfhjpBwlhJKLTwQ8Bb0=; b=bi4dR4F5hOf9kSuu2yUBJc+9OgzEjzWapQVjrBkUgfTwGW6rhbicOagqarks9NoeLp ht2CXl5CBNU5XdXzYIqUIGRVWJobCG8dR7VPQmy6HvVqgXYhVOivc5yVRSuno0jYem2o 4OT/bApqJd64Yi9aF3eSq1Jtrs1LotPusEpzszCVjl1rg7aDFRJgqSmbEYL2qoXbuQdK rn9dUSjvSRjyf6P2u+1wCbK9OXp1J0cIkZ59MnN4k9Gno+3bEfGu1VnAYeTznQhZieAI eaLHfztT8inrdclE5kG/+VaS4O0djNbC+JRWtxuwIdXMrmAL6e1jTkDkdsK8eZKn2qod LklQ== X-Gm-Message-State: AOAM533Z4Y/VaK3KTT4fLqSpxhOJYXjmFQFLg9zu6araNI7ZyCQGVgqT m41Q3o6xZMsd56c3O+SIZBrsXQ== X-Received: by 2002:adf:d1b2:: with SMTP id w18mr5663164wrc.235.1595602204528; Fri, 24 Jul 2020 07:50:04 -0700 (PDT) Received: from [192.168.1.4] ([195.24.90.54]) by smtp.googlemail.com with ESMTPSA id b18sm1595015wrs.46.2020.07.24.07.50.00 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 24 Jul 2020 07:50:03 -0700 (PDT) Subject: Re: [PATCH v2 0/6] Add new controls for CQ and Frame-skip To: Stanimir Varbanov , linux-media@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-arm-kernel@lists.infradead.org Cc: Mauro Carvalho Chehab , Kyungmin Park , Kamil Debski , Jeongtae Park , Andrzej Hajda , Ezequiel Garcia , Maheshwar Ajja , Nicolas Dufresne References: <20200721074538.505-1-stanimir.varbanov@linaro.org> From: Stanimir Varbanov Message-ID: Date: Fri, 24 Jul 2020 17:49:59 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: <20200721074538.505-1-stanimir.varbanov@linaro.org> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Hans, Could you suggest how to proceed with this : - wait Samsung mainteners for ack. - make a pull request with your ack for samsung mfc driver changes. - make a pull request for constant quality only. - postpone the whole patchset for 5.10 merge window. On 7/21/20 10:45 AM, Stanimir Varbanov wrote: > Hello, > > Here is v2 with following changes: > > * 3/6 Added references for VBV size and h264 CPB size - requested by Nicolas > * 4/6 Fixed compile warning > > Previous version can be found at [1]. > > regards, > Stan > > [1] https://lkml.org/lkml/2020/7/20/619 > > Maheshwar Ajja (1): > media: v4l2-ctrls: Add encoder constant quality control > > Stanimir Varbanov (5): > venus: venc: Add support for constant quality control > media: v4l2-ctrl: Add frame-skip std encoder control > venus: venc: Add support for frame-skip mode v4l2 control > media: s5p-mfc: Use standard frame skip mode control > media: docs: Deprecate mfc frame skip control > > .../media/v4l/ext-ctrls-codec.rst | 53 +++++++++++++++++++ > drivers/media/platform/qcom/venus/core.h | 2 + > drivers/media/platform/qcom/venus/hfi_cmds.c | 37 ++++++++++++- > .../media/platform/qcom/venus/hfi_helper.h | 10 +++- > drivers/media/platform/qcom/venus/venc.c | 20 +++++-- > .../media/platform/qcom/venus/venc_ctrls.c | 18 ++++++- > drivers/media/platform/s5p-mfc/s5p_mfc_enc.c | 6 +++ > drivers/media/v4l2-core/v4l2-ctrls.c | 12 +++++ > include/uapi/linux/v4l2-controls.h | 8 +++ > 9 files changed, 160 insertions(+), 6 deletions(-) > -- regards, Stan