Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Fri, 24 Jul 2020 17:06:41 +0100
From:   Lee Jones <lee.jones@linaro.org>
To:     Suman Anna <s-anna@ti.com>
Cc:     Arnd Bergmann <arnd@arndb.de>,
        David Lechner <david@lechnology.com>,
        Tony Lindgren <tony@atomide.com>,
        Roger Quadros <rogerq@ti.com>, linux-kernel@vger.kernel.org,
        linux-arm-kernel@lists.infradead.org, linux-omap@vger.kernel.org
Subject: Re: [PATCH v2] mfd: syscon: Use a unique name with regmap_config
Message-ID: <20200724160641.GB1850026@dell>
References: <20200127231208.1443-1-s-anna@ti.com>
 <20200224100037.GK3494@dell>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <20200224100037.GK3494@dell>
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Mon, 24 Feb 2020, Lee Jones wrote:

> On Mon, 27 Jan 2020, Suman Anna wrote:
> 
> > The DT node full name is currently being used in regmap_config
> > which in turn is used to create the regmap debugfs directories.
> > This name however is not guaranteed to be unique and the regmap
> > debugfs registration can fail in the cases where the syscon nodes
> > have the same unit-address but are present in different DT node
> > hierarchies. Replace this logic using the syscon reg resource
> > address instead (inspired from logic used while creating platform
> > devices) to ensure a unique name is given for each syscon.
> > 
> > Signed-off-by: Suman Anna <s-anna@ti.com>
> > ---
> > v2: Fix build warning reported by kbuild test bot
> > v1: https://patchwork.kernel.org/patch/11346363/
> > 
> >  drivers/mfd/syscon.c | 4 +++-
> >  1 file changed, 3 insertions(+), 1 deletion(-)
> 
> Waiting for Arnd to review.

Still waiting for some input from Arnd.

Might be worth submitting a [RESEND].

-- 
Lee Jones [李琼斯]
Senior Technical Lead - Developer Services
Linaro.org │ Open source software for Arm SoCs
Follow Linaro: Facebook | Twitter | Blog