Received: by 2002:a25:e74b:0:0:0:0:0 with SMTP id e72csp2308323ybh; Fri, 24 Jul 2020 09:29:47 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzY6eTPq5xIOhc2R+FJIAoPIojQhYqFIB28v3sNXW6mVQGB9CoptqPtLETN+ti/FOXLg5D7 X-Received: by 2002:a17:907:411b:: with SMTP id nw19mr9764482ejb.84.1595608187496; Fri, 24 Jul 2020 09:29:47 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1595608187; cv=none; d=google.com; s=arc-20160816; b=ayCXBVpkmBOf6FqC9UgN64hHN6814LZDkvXtmsmRCQDRISiz3VLu0BqIVRqU6elQ2+ anXpfLX0ZZcECWKt2Ast7oupT/dRri4Qdy0BKFzOR73oYYme2LmObUnAgefE4U4cEVFV EfL17M4BASplpoxMFFP57FrHMXdpWTbVAcHWuMVTf2fP0A/JNwSDHlLRJZ0ETb+H1XTJ yu/El+fwv1Eryh/wooehq1lOzhzptu5NIqJpzXn2WXVvARALAALzne9wxuTZ4EB6bSFm aWLE9Ob39o0XzlW22EU9o0YWbJatTeG/Qea5TXNCPv5q1w6JR5B8qGjT4uXA7FfPS4zD 1ddw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date; bh=61/EJ34SylBYieOZBRZwtJqAx5GSKA5lxRm0cUvdQmM=; b=uQjR3ZarLJkceZOc/AzVC81zCuP5fIvxguKBBpMc2xnxkBdB5h/1RNnAJXRan0Y9Xu 7v5BRxaeL36wswEOrj99gjjvMkAdTiS2MS8lF7RGRCuQ7L28kLyNCrdE9Tl/b+1YsixA z67wdDkxmn9cft0MzdmSr53pymKVY1NAGoE2q6HGhBZNIt3bFr0LhO7Yx0LkgTeQNM6E DhbBy5YIxgOEXV/syEM2ZVopo6fRW57rv4q/Ul4skd8AbLS4AiBHT37uIKG5Syxqc5Bq IyUtOvOWQW/DLZOTYQI+2JMikAXE0Fv2TVicLbg+t1Zwipi2rqbtdbV4tIpqV+HkSxwp rK7A== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id a12si907688edf.185.2020.07.24.09.29.25; Fri, 24 Jul 2020 09:29:47 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726527AbgGXQ1N (ORCPT + 99 others); Fri, 24 Jul 2020 12:27:13 -0400 Received: from verein.lst.de ([213.95.11.211]:36298 "EHLO verein.lst.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726326AbgGXQ1M (ORCPT ); Fri, 24 Jul 2020 12:27:12 -0400 Received: by verein.lst.de (Postfix, from userid 2407) id ACA5968AFE; Fri, 24 Jul 2020 18:27:09 +0200 (CEST) Date: Fri, 24 Jul 2020 18:27:09 +0200 From: Christoph Hellwig To: Amit Pundir Cc: Christoph Hellwig , Nicolas Saenz Julienne , Marek Szyprowski , Robin Murphy , David Rientjes , linux-rpi-kernel@lists.infradead.org, jeremy.linton@arm.com, iommu@lists.linux-foundation.org, lkml , John Stultz , Sumit Semwal Subject: Re: [PATCH] dma-pool: Do not allocate pool memory from CMA Message-ID: <20200724162709.GA15051@lst.de> References: <011994f8a717a00dcd9ed7682a1ddeb421c2c43f.camel@suse.de> <01831596e4a2a6c9c066138b23bd30435f8e5569.camel@suse.de> <6db722947546221ed99d3f473f78e1a6de65d7d6.camel@suse.de> <0dc1e922bf87fa73790e7471b3974528dd261486.camel@suse.de> <20200724134114.GA3152@lst.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.17 (2007-11-01) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Jul 24, 2020 at 09:49:17PM +0530, Amit Pundir wrote: > On Fri, 24 Jul 2020 at 19:11, Christoph Hellwig wrote: > > > > Yes, the iommu is an interesting case, and the current code is > > wrong for that. Can you try the patch below? It contains a modified > > version of Nicolas' patch to try CMA again for the expansion and a new > > (for now hackish) way to not apply the addressability check for dma-iommu > > allocations. > > Thank you. The below patch worked on today's linux/master (f37e99aca03f). Ok, I'll try to massage it into a few cleaner patches over the weekend and will send them to you again for retesting. Thanks a lot for your patience!