Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
From:   Arvind Sankar <nivedita@alum.mit.edu>
Date:   Fri, 24 Jul 2020 13:38:21 -0400
To:     Sedat Dilek <sedat.dilek@gmail.com>
Cc:     Arvind Sankar <nivedita@alum.mit.edu>,
        Nick Terrell <nickrterrell@gmail.com>,
        Borislav Petkov <bp@alien8.de>,
        Thomas Gleixner <tglx@linutronix.de>,
        linux-kernel@vger.kernel.org, Chris Mason <clm@fb.com>,
        linux-kbuild@vger.kernel.org, x86@kernel.org,
        gregkh@linuxfoundation.org, Petr Malat <oss@malat.biz>,
        Kees Cook <keescook@chromium.org>,
        Kernel Team <Kernel-team@fb.com>,
        Adam Borowski <kilobyte@angband.pl>,
        Patrick Williams <patrickw3@fb.com>, rmikey@fb.com,
        mingo@kernel.org, Patrick Williams <patrick@stwcx.xyz>,
        Norbert Lange <nolange79@gmail.com>,
        Andrew Morton <akpm@linux-foundation.org>,
        Alex Xu <alex_y_xu@yahoo.ca>, Nick Terrell <terrelln@fb.com>
Subject: Re: [PATCH v8 6/7] x86: Add support for ZSTD compressed kernel
Message-ID: <20200724173821.GA675116@rani.riverdale.lan>
References: <20200723192801.351114-1-nickrterrell@gmail.com>
 <20200723192801.351114-7-nickrterrell@gmail.com>
 <CA+icZUWV3ANmBj08QZKBtEE38Y-iyCGGxLWtiFkdpKqkGP7ZqQ@mail.gmail.com>
 <20200724143022.GA601509@rani.riverdale.lan>
 <CA+icZUWr0FBO1dpu-PPXJDSFzemoD7zniq+eQQrWXA_uGVKVAA@mail.gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
In-Reply-To: <CA+icZUWr0FBO1dpu-PPXJDSFzemoD7zniq+eQQrWXA_uGVKVAA@mail.gmail.com>
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Fri, Jul 24, 2020 at 04:48:36PM +0200, Sedat Dilek wrote:
> On Fri, Jul 24, 2020 at 4:30 PM Arvind Sankar <nivedita@alum.mit.edu> wrote:
> >
> > On Fri, Jul 24, 2020 at 02:50:34AM +0200, Sedat Dilek wrote:
> > > On Thu, Jul 23, 2020 at 9:30 PM Nick Terrell <nickrterrell@gmail.com> wrote:
> > > >
> > > > From: Nick Terrell <terrelln@fb.com>
> > > >
> > > > * Define __DISABLE_EXPORTS in misc.c
> > > >
> > > > __DISABLE_EXPORTS is defined in misc.c instead of the Makefile because
> > > > kaslr.c defines __DISABLE_EXPORTS, and defining it in the Makefile gives
> > > > duplicate definition warnings.
> > > >

> > I'd have added it to the Makefile and just dropped the definition in
> > kaslr.c -- should be no reason for anything in here to use EXPORT_SYMBOL.
> >
> 
> I cannot follow - this is no more needed as this was due to some of
> your local changes in kaslr.c?
> 
> - Sedat -

That part was meant as a comment on the patch, i.e. avoid the duplicate
definition warning not by putting it in misc.c instead of the Makefile,
but by dropping the definition in kaslr.c.