Received: by 2002:a25:e74b:0:0:0:0:0 with SMTP id e72csp2448833ybh; Fri, 24 Jul 2020 13:08:44 -0700 (PDT) X-Google-Smtp-Source: ABdhPJz7rD2ccpsfoti8X98gfPaFjxGvmDftnCAgtxlYiPLI/eQdGttyGXYfMp9F/pQzDezFBaPs X-Received: by 2002:a17:906:d106:: with SMTP id b6mr7090745ejz.125.1595621323604; Fri, 24 Jul 2020 13:08:43 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1595621323; cv=none; d=google.com; s=arc-20160816; b=lsyGO0uToJrRnPbOcxGJoK8Rzmd26bG+2Fq7f2r5hFdY5UpXvTVHngDnP0Td043Tmm 0b3bzcGgwcvi6eWpexSwFcKHw2RBi54Aze8WY1+yR2XCouSQ5cWvrPSC6PfwukvwcXQa CH6z4cipQHpnE6xU+u48Wz0jlLQsflaGh0f643hrODJFpcknLBqAp84DkkRYpdHH7ccF k+ZCx5uSakrtvXtTipTuF/llLKS+8bDOM3bFPicehkoYtTIE68RFqp6bmd3zXVSf7N0y r66M6Bq/kwWDHGyWcX5AKcA6IRPHHn8kUYhXP5b5PFWk/YS9YynAe8S0+2r7g0ozxAwc u5Ug== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:message-id:date :mime-version:subject:references:in-reply-to:cc:to:envelope-from :from:dkim-signature; bh=m2BanQAPl69vRg18tTrq/938FSkS17kTikJwpIpVrUM=; b=EgUYtWm0acrD4/G1xh6JcBJokl8pDlutv+l590kPhre9/R3IUWpUH7sZ932gAoIu2V JzKsUutXcLx0yabeNYnAfk5KcZ4TPC14inztYrv6f/ZfBxBGLZPDaux6wVrf0QNP/bSN WW7BAxuUZ+37fRP7J08RsrRbYbOS8byv/zybSWQnSvaUJAieQpPm5h+PYT84K0p70etO 6+RIo30bUAbrRui07rQBu0R84rqBjsWk+gvco7Jw5S6W0xEOYeXCE0zHgNinbkUFFFja cBD44tf+80ftxUQaJNsjVN9hQxI7wfN1wbNJma8vUosw5xzmmzQ94fI2rxdDulWApju/ 0duw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@yandex.ru header.s=mail header.b="M/PUXsLP"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=ispras.ru Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id g1si1075757edy.370.2020.07.24.13.08.21; Fri, 24 Jul 2020 13:08:43 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@yandex.ru header.s=mail header.b="M/PUXsLP"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=ispras.ru Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726696AbgGXUIH (ORCPT + 99 others); Fri, 24 Jul 2020 16:08:07 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:43916 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726381AbgGXUIH (ORCPT ); Fri, 24 Jul 2020 16:08:07 -0400 Received: from forward500o.mail.yandex.net (forward500o.mail.yandex.net [IPv6:2a02:6b8:0:1a2d::610]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 0F568C0619D3; Fri, 24 Jul 2020 13:08:07 -0700 (PDT) Received: from mxback5o.mail.yandex.net (mxback5o.mail.yandex.net [IPv6:2a02:6b8:0:1a2d::1f]) by forward500o.mail.yandex.net (Yandex) with ESMTP id 3A4CD60153; Fri, 24 Jul 2020 23:08:03 +0300 (MSK) Received: from localhost (localhost [::1]) by mxback5o.mail.yandex.net (mxback/Yandex) with ESMTP id 5fFSXZVXpp-82RmFQZQ; Fri, 24 Jul 2020 23:08:02 +0300 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yandex.ru; s=mail; t=1595621282; bh=m2BanQAPl69vRg18tTrq/938FSkS17kTikJwpIpVrUM=; h=Message-Id:Cc:Subject:In-Reply-To:Date:References:To:From; b=M/PUXsLP+lUs7DO8C50LfiUKM3ttQZKL0NvefnDa02DzdYpudYOguaf9HpnVDk682 cys3JqbfQWB50XohGatwOYcp2diDsfY3u7i19Bvw+nB7lopKC/JnJbdF386PpNzAwJ nV9sQID/QnKZ2jvWAnQPunMeyR7rIOIjq54M5X3Q= Authentication-Results: mxback5o.mail.yandex.net; dkim=pass header.i=@yandex.ru Received: by sas8-b090c2642e35.qloud-c.yandex.net with HTTP; Fri, 24 Jul 2020 23:08:02 +0300 From: Evgeny Novikov Envelope-From: eugenenovikov@yandex.ru To: Markus Elfring , "ldv-project@linuxtesting.org" , "linux-media@vger.kernel.org" Cc: "linux-kernel@vger.kernel.org" , "kernel-janitors@vger.kernel.org" , Mauro Carvalho Chehab , Prabhakar Lad In-Reply-To: References: Subject: Re: [PATCH] media: davinci: vpif_capture: fix potential double free MIME-Version: 1.0 X-Mailer: Yamail [ http://yandex.ru ] 5.0 Date: Fri, 24 Jul 2020 23:08:02 +0300 Message-Id: <236161595621028@mail.yandex.ru> Content-Transfer-Encoding: 8bit Content-Type: text/plain; charset=utf-8 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Markus, It seems that Lad Prabhakar detected a critical issue introduced by the patch instead of a minor bug fixed by it. So, we should take care of this first, but I will address your notes as well. --  Evgeny Novikov Linux Verification Center, ISP RAS http://linuxtesting.org 23.07.2020, 23:15, "Markus Elfring" : >>  In case of errors vpif_probe_complete() releases memory for vpif_obj.sd >>  and unregisters the V4L2 device. But then this is done again by >>  vpif_probe() itself. The patch removes the cleaning from >>  vpif_probe_complete(). > > * An imperative wording can be preferred for the change description, >   can't it? > > * Would you like to add the tag “Fixes” to the commit message? > > Regards, > Markus