Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
IronPort-SDR: Vx2vK1CxwuQVpspXaO42nVtUa0ukj/KN/qh/5WJPrnyGulO+GE1GO1B7YRzomulhrrJpEVXKzd
 1jQL+Jn/zvzw==
IronPort-SDR: pbLf7hxeNV+PKCGzkxmcygZu9IRN8UI8TXUQmRZYpVjx055wlBFKutLr7o25IMJEnAl2p1QuZg
 oAyp+zrflfVg==
From:   "Eads, Gage" <gage.eads@intel.com>
To:     Greg KH <gregkh@linuxfoundation.org>
CC:     "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "arnd@arndb.de" <arnd@arndb.de>,
        "Karlsson, Magnus" <magnus.karlsson@intel.com>,
        "Topel, Bjorn" <bjorn.topel@intel.com>
Subject: RE: [PATCH 01/20] dlb2: add skeleton for DLB 2.0 driver
Thread-Topic: [PATCH 01/20] dlb2: add skeleton for DLB 2.0 driver
Thread-Index: AQHWWGU9Tth4ik4BzU63g7CSJsQmkakKx86wgAIl3ACAA+YfQIAAEK6AgAZgyWA=
Date:   Fri, 24 Jul 2020 21:00:20 +0000
Message-ID: <DM6PR11MB2572EB1152A0B1453531D72BF6770@DM6PR11MB2572.namprd11.prod.outlook.com>
References: <20200712134331.8169-1-gage.eads@intel.com>
 <20200712134331.8169-2-gage.eads@intel.com>
 <20200712155810.GC186665@kroah.com>
 <SN6PR11MB2574E9B6F6957D765BC18F29F67C0@SN6PR11MB2574.namprd11.prod.outlook.com>
 <20200718064656.GB245355@kroah.com>
 <SN6PR11MB25746161DC8D54AD5BD30F96F67B0@SN6PR11MB2574.namprd11.prod.outlook.com>
 <20200720191903.GD1529125@kroah.com>
In-Reply-To: <20200720191903.GD1529125@kroah.com>
Accept-Language: en-US
Content-Language: en-US
dlp-version: 11.2.0.6
dlp-product: dlpe-windows
dlp-reaction: no-action
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-Network-Message-Id: e45a0edc-a225-4a2d-9fb0-08d830149360
X-MS-Exchange-CrossTenant-originalarrivaltime: 24 Jul 2020 21:00:20.1958
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: NQTKf0XQ9WYsAq+csAo7q7KPh0PIAB1yo2PsNUEH6QWDGIfoNKBAif5e7MPnOPDNIK/MaxNqei7UDzKW4WG7iQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR11MB2572
X-OriginatorOrg: intel.com
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


> -----Original Message-----
> From: Greg KH <gregkh@linuxfoundation.org>
> Sent: Monday, July 20, 2020 2:19 PM
> To: Eads, Gage <gage.eads@intel.com>
> Cc: linux-kernel@vger.kernel.org; arnd@arndb.de; Karlsson, Magnus
> <magnus.karlsson@intel.com>; Topel, Bjorn <bjorn.topel@intel.com>
> Subject: Re: [PATCH 01/20] dlb2: add skeleton for DLB 2.0 driver
>=20
> On Mon, Jul 20, 2020 at 07:02:05PM +0000, Eads, Gage wrote:
> >
> >
> > > -----Original Message-----
> > > From: Greg KH <gregkh@linuxfoundation.org>
> > > Sent: Saturday, July 18, 2020 1:47 AM
> > > To: Eads, Gage <gage.eads@intel.com>
> > > Cc: linux-kernel@vger.kernel.org; arnd@arndb.de; Karlsson, Magnus
> > > <magnus.karlsson@intel.com>; Topel, Bjorn <bjorn.topel@intel.com>
> > > Subject: Re: [PATCH 01/20] dlb2: add skeleton for DLB 2.0 driver
> > >
> > > On Fri, Jul 17, 2020 at 06:18:46PM +0000, Eads, Gage wrote:
> > > >
> > > >
> > > > > -----Original Message-----
> > > > > From: Greg KH <gregkh@linuxfoundation.org>
> > > > > Sent: Sunday, July 12, 2020 10:58 AM
> > > > > To: Eads, Gage <gage.eads@intel.com>
> > > > > Cc: linux-kernel@vger.kernel.org; arnd@arndb.de; Karlsson, Magnus
> > > > > <magnus.karlsson@intel.com>; Topel, Bjorn <bjorn.topel@intel.com>
> > > > > Subject: Re: [PATCH 01/20] dlb2: add skeleton for DLB 2.0 driver
> > > > >
> > > > > On Sun, Jul 12, 2020 at 08:43:12AM -0500, Gage Eads wrote:
> > > > > > +static int dlb2_probe(struct pci_dev *pdev,
> > > > > > +		      const struct pci_device_id *pdev_id) {
> > > > > > +	struct dlb2_dev *dlb2_dev;
> > > > > > +	int ret;
> > > > > > +
> > > > > > +	dev_dbg(&pdev->dev, "probe\n");
> > > > >
> > > > > ftrace is your friend.  Remove all of your debugging code now, yo=
u
> don't
> > > need
> > > > > it anymore, especially for stuff like this where you didn't even =
need it
> in
> > > the
> > > > > first place :(
> > > >
> > > > I'll remove this and other similar dev_dbg() calls. This was an ove=
rsight
> on
> > > my part.
> > > >
> > > > I have other instances that a kprobe can't easily replace, such as
> printing
> > > structure contents, that are useful for tracing the usage of the driv=
er. It
> looks
> > > like other misc drivers use dev_dbg() similarly -- do you consider th=
is an
> > > acceptable use of a debug print?
> > >
> > > Why can't a kernel tracepoint print a structure?
> >
> > I meant the command-line installed kprobes[1], but instrumenting the
> driver is
> > certainly an option. We don't require the much lower overhead of a
> tracepoint,
> > so I didn't choose it. This driver handles the (performance-insensitive=
)
> > device configuration, while the fast-path operations take place in user=
-
> space.
> >
> > Another reason is the "hardware access library" files use only non-GPL
> external
> > symbols, and some tracepoint functions are exported GPL. Though it's
> probably
> > feasible to lift that tracing code up into a (GPLv2-only) caller functi=
on.
>=20
> Stop going through crazy gyrations for something that your own legal
> team has told you not to do anymore in the first place.
>=20
> No "hardware access library" files please, that's not how Linux drivers
> are written.
>=20
> you all know better...
>=20
> > But if tracepoints are the preferred method and/or you think the driver
> would
> > benefit, I'll make the change.
>=20
> I don't think you need any of that stuff, now that the code works
> properly, right?

There are no known issues, correct. The logging (whether it's
dev_dbg/tracepoints/etc.) would be for user-space developers -- visibility =
into
the driver could help them debug issues in their own code.

It's hardly a critical feature; I'm happy to change or remove it if necessa=
ry.
But it could be helpful, isn't a maintenance burden or performance hindranc=
e,
and (AFAICT) shouldn't pose any security risks.

Thanks,
Gage

>=20
> greg k-h