Received: by 2002:a25:e74b:0:0:0:0:0 with SMTP id e72csp2498296ybh; Fri, 24 Jul 2020 14:37:42 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzK799dU3xE+D/5eOvw5XaG14jGmzz1qfHLXc4kcm3l5k8bUIjxNoh79n9PYyny8CqrGgiO X-Received: by 2002:a50:fa07:: with SMTP id b7mr10609735edq.298.1595626662501; Fri, 24 Jul 2020 14:37:42 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1595626662; cv=none; d=google.com; s=arc-20160816; b=GF7Aj4zq1ujVzxAYDQhujZmEKR8PwMdh4oKthAukmGakQFqBYsqzydQ3CqzkLt8gXH T5ZK4ZrfUKLjr9IaM+V2jkVVFhX9SHRuEMPqUnm4PG1rRxvVYp3dq4DKH5ECjrbN5+VT ZNzsKUNcXTrJ4Ub6LpC/jqxXMCp90uM/4ZTXFk30tZaCUHZ1o1XCn4j1zl/e1k/lElLK 0pu4imvdcWhICmD87yXxN1LJREA1NWraEGyB6rEcEydSZtDQEtEQPrntqX9DoqpWv5pH VkrA+KhvSvUO6MUVbG5QiMVZBklUiDMxJJ9/JJwKMYoiOHc6kYxCemYEsQ1BUFtXKXN7 xYOw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=5Or2hRyZ+DJD2fMv0vkFvtUzR/cluRUiM0su+3Iw/kY=; b=D5xOKz0at5nsCNOnD4f9ozYLh6N0AtYqmtN0BoDezpCgavtCFTEdpT6+iy0FdB5ObT 40Oz2YDy560KWRTpGZgvl/uF69OaMmomDfGQod3iShqWnxQdyRD4HvwZCra7d3ybPvIE fQeZyHWUUJ7ho9pPoRDNbzMc72+w0zL3wiU36EScTm+Q8L6njsj2C+AXn9eSCqPUxr+k PvqUo7FFRkCbnHkda6NoZf1asxy4ismqYMAcF6oVdQ4pAi+rXyXegwxj+ktWx3pZA5EO rw4V4RfFqBSjwjTGkjCbAX1uk+pVLOUzt0TrS0uXaTNT1MQpqXlFlO9isSnPdokVjibx 8b5Q== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@chromium.org header.s=google header.b=bueanFjG; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=chromium.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id h8si1172338edz.380.2020.07.24.14.37.19; Fri, 24 Jul 2020 14:37:42 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@chromium.org header.s=google header.b=bueanFjG; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=chromium.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726899AbgGXVdu (ORCPT + 99 others); Fri, 24 Jul 2020 17:33:50 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:57242 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726742AbgGXVde (ORCPT ); Fri, 24 Jul 2020 17:33:34 -0400 Received: from mail-pj1-x1041.google.com (mail-pj1-x1041.google.com [IPv6:2607:f8b0:4864:20::1041]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 04934C0619E6 for ; Fri, 24 Jul 2020 14:33:34 -0700 (PDT) Received: by mail-pj1-x1041.google.com with SMTP id md7so6240359pjb.1 for ; Fri, 24 Jul 2020 14:33:34 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=5Or2hRyZ+DJD2fMv0vkFvtUzR/cluRUiM0su+3Iw/kY=; b=bueanFjGE8P6y0aX0kwLr2tZV2YD96YtUUUTOZYK/ammPsZ0QoUt0HZCNi1ZOtnfN2 9gedv4E86CKFfdSifS9RuWJ7hPiVHPmSsGQsOJZNE3NneGyBG/L2woCwcQHCZRlJDtTg dBEkIFoYCBcSRPmhMMzNwfYN7pVeD8XIqlPi8= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=5Or2hRyZ+DJD2fMv0vkFvtUzR/cluRUiM0su+3Iw/kY=; b=irjJrKvgszvN7Knn6fUWgbX0Q2N0dqOI0GzO+Rr3gVRvUvhQZw4pY4CDphPbvlXQAn yfbBgL5omT9PF0ZdvujRPz2DmYB4gEtqJ2atkR/WiHS0YfPNgvI7c01XQcgYiSoERRKu mwhQCxf6IA1VMIUn8uLyyCBzgbRrO5sHyXb9yMSTAN0vFWwKglNoKQTcxmzQhglk0tk6 BNAs92PDFwCRZOPNQ0G/fJ65Z5zBZ5mfLN5FwZaXIsOxy2Mq3d0wgaQswz5jGdKBRZCC NDhGZo6yxvA0x+MO1/z3hnZDTYfCDS9ZMg5j94h6Siqzn/HLv5PEyCtL7/1fBbgwTpAU bSOw== X-Gm-Message-State: AOAM533zSeZWEC+cefKzh500mP3r5MfHevpQFHvD6qu5QK31wAWYrY2m Z7zEkdTOpYdJdffAnB2l+6u19g== X-Received: by 2002:a17:90a:62c1:: with SMTP id k1mr7522698pjs.107.1595626413574; Fri, 24 Jul 2020 14:33:33 -0700 (PDT) Received: from smtp.gmail.com ([2620:15c:202:1:3e52:82ff:fe6c:83ab]) by smtp.gmail.com with ESMTPSA id z6sm7312919pfn.173.2020.07.24.14.33.32 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 24 Jul 2020 14:33:33 -0700 (PDT) From: Stephen Boyd To: Jonathan Cameron Cc: linux-kernel@vger.kernel.org, linux-iio@vger.kernel.org, Gwendal Grignou , Daniel Campello , Hartmut Knaack , Lars-Peter Clausen , Peter Meerwald-Stadler , Douglas Anderson Subject: [PATCH v2 2/5] iio: sx9310: Add newlines to printks Date: Fri, 24 Jul 2020 14:33:26 -0700 Message-Id: <20200724213329.899216-3-swboyd@chromium.org> X-Mailer: git-send-email 2.28.0.rc0.142.g3c755180ce-goog In-Reply-To: <20200724213329.899216-1-swboyd@chromium.org> References: <20200724213329.899216-1-swboyd@chromium.org> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Printks in the kernel have newlines at the end. Add them to the few printks in this driver. Cc: Gwendal Grignou Reviewed-by: Daniel Campello Cc: Hartmut Knaack Cc: Lars-Peter Clausen Cc: Peter Meerwald-Stadler Reviewed-by: Douglas Anderson Fixes: 72ad02b15d63 ("iio: Add SEMTECH SX9310/9311 sensor driver") Signed-off-by: Stephen Boyd --- drivers/iio/proximity/sx9310.c | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/drivers/iio/proximity/sx9310.c b/drivers/iio/proximity/sx9310.c index d161f3061e35..84c3c9ae80dc 100644 --- a/drivers/iio/proximity/sx9310.c +++ b/drivers/iio/proximity/sx9310.c @@ -824,7 +824,7 @@ static int sx9310_init_compensation(struct iio_dev *indio_dev) if (i < 0) { dev_err(&data->client->dev, - "initial compensation timed out: 0x%02x", val); + "initial compensation timed out: 0x%02x\n", val); ret = -ETIMEDOUT; } @@ -871,14 +871,14 @@ static int sx9310_set_indio_dev_name(struct device *dev, /* id will be NULL when enumerated via ACPI */ if (id) { if (id->driver_data != whoami) - dev_err(dev, "WHOAMI does not match i2c_device_id: %s", + dev_err(dev, "WHOAMI does not match i2c_device_id: %s\n", id->name); } else if (ACPI_HANDLE(dev)) { acpi_id = acpi_match_device(dev->driver->acpi_match_table, dev); if (!acpi_id) return -ENODEV; if (acpi_id->driver_data != whoami) - dev_err(dev, "WHOAMI does not match acpi_device_id: %s", + dev_err(dev, "WHOAMI does not match acpi_device_id: %s\n", acpi_id->id); } else return -ENODEV; @@ -891,7 +891,7 @@ static int sx9310_set_indio_dev_name(struct device *dev, indio_dev->name = "sx9311"; break; default: - dev_err(dev, "unexpected WHOAMI response: %u", whoami); + dev_err(dev, "unexpected WHOAMI response: %u\n", whoami); return -ENODEV; } @@ -920,7 +920,7 @@ static int sx9310_probe(struct i2c_client *client, ret = regmap_read(data->regmap, SX9310_REG_WHOAMI, &data->whoami); if (ret < 0) { - dev_err(&client->dev, "error in reading WHOAMI register: %d", + dev_err(&client->dev, "error in reading WHOAMI register: %d\n", ret); return ret; } -- Sent by a computer, using git, on the internet