Received: by 2002:a25:e74b:0:0:0:0:0 with SMTP id e72csp2515303ybh; Fri, 24 Jul 2020 15:08:24 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzlduGKIgzuZQ09te4/aNTfHFuxU7xjT6xKy2tYFaH/A9n+0UEYJLN5JkHwosJQFJ81B6pa X-Received: by 2002:a05:6402:d0d:: with SMTP id eb13mr9822610edb.307.1595628504612; Fri, 24 Jul 2020 15:08:24 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1595628504; cv=none; d=google.com; s=arc-20160816; b=yMUN5BC/TmAejPjdaPzm7l+TaeVmoU/3AHh8hZ0E8GfU7Rf0CugDfvheGcvskDiHuv Er3f210T91cLpFp9RHvw2/DIw4H0rY9xp4kQtN+xEnf0YGxOVg7z3iXAhYBeEEvTDQJt hN9yAhbOBsXeRSLKnmTQKR5kvgSqjvJjgwQ6CxiMxQg8jjawmrTaigTTp7LJeaSgw72G hMzsgmYNs3pCf2ql0S8icnM3Wl3tfYKC74Zj5pDhJEuRdsJqMasm7plkCwRmGR/jptvl QPgU/t0RlLZIrKjtj+5iWbwBGj4C/I0F+AU10oJGVbhi3UsHLTM901dPCjdEHbWW9MDj lsSw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date; bh=g7rGf6alo+Kh18b7Mr3XKk4s2fLML3av4slBsMsqN1E=; b=GGqTaw9ccQspDUoKz37zSG9iGV5xhMKGtJRfnGSTQ+Y3eQzd+KPVRU2s7T6VIhModh 3u31hHPX5S0qVhnmPMoKOHLOnn5cIFA9gLQ8fphQHBfeeShJf8Y3hcFhFCg0EZalvzp3 52F76eyZ8hBe6oYBmif5Y9qMCAqUcsobgYFspi94DODlewr0O7CzvvTyizEnq5jSHtWE j22U5RNEmw8mA8W3XRloylZRvjHAvOgMVKOMxCj7kb9R/u0W5FqWsqnwcJcvhIit/FsL dPm1DKh3k79F/PWFl+SPVsDskASKqoZxeUPZg02jtvyfeD2ZaN0Nr9djGYDUbnRpN29Y CFlw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id k19si497820ejz.79.2020.07.24.15.08.00; Fri, 24 Jul 2020 15:08:24 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726835AbgGXWFU (ORCPT + 99 others); Fri, 24 Jul 2020 18:05:20 -0400 Received: from jabberwock.ucw.cz ([46.255.230.98]:47340 "EHLO jabberwock.ucw.cz" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726607AbgGXWFT (ORCPT ); Fri, 24 Jul 2020 18:05:19 -0400 Received: by jabberwock.ucw.cz (Postfix, from userid 1017) id 112D11C0BE2; Sat, 25 Jul 2020 00:05:17 +0200 (CEST) Date: Sat, 25 Jul 2020 00:05:16 +0200 From: Pavel Machek To: Martin Botka Cc: Jacek Anaszewski , Dan Murphy , Rob Herring , Thierry Reding , Uwe =?iso-8859-1?Q?Kleine-K=F6nig?= , Lee Jones , linux-leds@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-pwm@vger.kernel.org Subject: Re: [PATCH RFC 0/6] Add QCOM pwm-lpg and tri-led drivers Message-ID: <20200724220516.GA21965@amd> References: <20200724213659.273599-1-martin.botka1@gmail.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="wac7ysb48OaltWcw" Content-Disposition: inline In-Reply-To: <20200724213659.273599-1-martin.botka1@gmail.com> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --wac7ysb48OaltWcw Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Hi! Dalsi cech co hackuje LEDky? > This series brings QCOM pwm-lpg and tri-led drivers from 4.14 that is req= uired to support pmic-connected notification LED. > This comes straight from downstream and I'm ready for your comments. Yeah, so... Bindings should go first, they may need to be converted to yml (devicetree people will know). Can generic pwm driver be used here? This is for RGB modules, right? It will need to use multicolor framework. "Breathing" will need to be figured out. It should become a trigger. Is this for phone, btw? If so, which one? Best regards, Pavel > .../bindings/leds/leds-qti-tri-led.txt | 72 + > .../devicetree/bindings/pwm/pwm-qti-lpg.txt | 163 +++ > drivers/leds/Kconfig | 9 + > drivers/leds/Makefile | 1 + > drivers/leds/leds-qti-tri-led.c | 640 ++++++++ > drivers/pwm/Kconfig | 10 + > drivers/pwm/Makefile | 1 + > drivers/pwm/core.c | 56 +- > drivers/pwm/pwm-qti-lpg.c | 1284 +++++++++++++++++ > drivers/pwm/sysfs.c | 56 +- > include/linux/pwm.h | 144 +- > 11 files changed, 2418 insertions(+), 18 deletions(-) > create mode 100644 Documentation/devicetree/bindings/leds/leds-qti-tri-l= ed.txt > create mode 100644 Documentation/devicetree/bindings/pwm/pwm-qti-lpg.txt > create mode 100644 drivers/leds/leds-qti-tri-led.c > create mode 100644 drivers/pwm/pwm-qti-lpg.c >=20 --=20 (english) http://www.livejournal.com/~pavelmachek (cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blo= g.html --wac7ysb48OaltWcw Content-Type: application/pgp-signature; name="signature.asc" Content-Description: Digital signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iEYEARECAAYFAl8bWxwACgkQMOfwapXb+vLWJQCdHtl9UD/9yDfZ1yGURJGOFa/h BlsAmwV9txSx+kK7qN9Y9fI6OBfNv+A3 =cLGg -----END PGP SIGNATURE----- --wac7ysb48OaltWcw--