Received: by 2002:a25:e74b:0:0:0:0:0 with SMTP id e72csp2561747ybh; Fri, 24 Jul 2020 16:35:15 -0700 (PDT) X-Google-Smtp-Source: ABdhPJypE4EKYKPWGnnC6Q4n+LISe4IXMz+yMRBUcuq1jItFwvybJOVqBMXhINLTM25rnTndk/sm X-Received: by 2002:a17:907:1059:: with SMTP id oy25mr12097994ejb.90.1595633715517; Fri, 24 Jul 2020 16:35:15 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1595633715; cv=none; d=google.com; s=arc-20160816; b=yGc570cOS0EwEk6DdoDoKe5rIvh1NiuRW90kA0YDwa3bmupS3Z6oITLd5rFEq9rLSB T2GpNM/HUur59AXL4u7SznDGxKgXZrsBJoCvv4nms31PA5GfzCKFXTMWG3B4UPVdhCM+ CyzqWQq9+3aNfVDhM4PDbUHwZZzdvrEaoILv8DTH3q2k0AYyORVYk2j1yBoCYwgqFoM+ 13N2/kUtPgSDTe6SEJiH+a88i6JqcDgdBsfRl+TL5K04s6ziElMKWtzTgqbJhSoBT3h5 X8sohLNxHtqBGnpHsmpKROn7UdT+c8m1LMts+iMkUaS1Tg6fHDeGvaQmJchlD3r31ulq Mskg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :message-id:date:references:in-reply-to:subject:cc:to:dkim-signature :dkim-signature:from; bh=s86KpX4gEQp9O8JUTp5Kv2QZ3KmBoiheWWny0AIVQrw=; b=uQCYwGTYaeRyc4K30hjvrgNP8lsXAD2z+TfmsdpxDnSX8HzSDwskSRnaJ78ODe6lpO J6wFhp4nQo1dbq6SZulQOu1cDzW9cStEk1hQBX4fQO3TSWRZaePCuAOkSW0QbMVprQr7 eaw1Ld3g4I3FFt1yhXAHOfk3eam4Ff/rgOEaF1s+6zrc3uECkMU9fVGXjrut5xyNVn2Z sJEYME/+1QMbTIPsatp58dbbnqMNFriBoyVU5MrWzMSI7u3kNVM6vCymEpg1fMQ6BXF+ muCVQgeQFcH/TSJCid/ZQiK89tLCIOnkiTQyXrcVnAKhzwI+QebVH0RjYUNmv34GJZNz HDCQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linutronix.de header.s=2020 header.b=Utl4iStv; dkim=neutral (no key) header.i=@linutronix.de header.b=RHYIU2tM; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=linutronix.de Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id g16si28942ejf.619.2020.07.24.16.34.51; Fri, 24 Jul 2020 16:35:15 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@linutronix.de header.s=2020 header.b=Utl4iStv; dkim=neutral (no key) header.i=@linutronix.de header.b=RHYIU2tM; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=linutronix.de Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726703AbgGXXbl (ORCPT + 99 others); Fri, 24 Jul 2020 19:31:41 -0400 Received: from Galois.linutronix.de ([193.142.43.55]:41168 "EHLO galois.linutronix.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726503AbgGXXbk (ORCPT ); Fri, 24 Jul 2020 19:31:40 -0400 From: Thomas Gleixner DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linutronix.de; s=2020; t=1595633499; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=s86KpX4gEQp9O8JUTp5Kv2QZ3KmBoiheWWny0AIVQrw=; b=Utl4iStvmks4F/x7c50zDmwxsxqWfC484X/c1aGEriQJUQXjdCrez7GOHMCyOooB4JdNQw Q8CsNfQVInlbev77cIGJj1lbIXC7PNymbSD0G8pvUhlCr8uZw3Zyd71GIQLo0ID6waEJ7O 7CLBPgcOrpsUhUXJ4EzP6pvBDUFhUij++AxDYqCcRkz/qtt9MLPWos6+8m6wuxvIxV5gFU +Gp+8mJspSLC/uLFw+3J5YGd14jgjMa1v7BObs+OzA404xzYcCFZxp7uHimoXpeFKUVBIh UgADjIeLRF1EwUx7Uxg87uewNLCuZumecSXZ5IhX2P6PhRjCh4RIGKwCZoNdsQ== DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=linutronix.de; s=2020e; t=1595633499; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=s86KpX4gEQp9O8JUTp5Kv2QZ3KmBoiheWWny0AIVQrw=; b=RHYIU2tMmbWTK4xQgazmPFYe+Wy35hX0U5R04s9JQHcDADlWTPeZwld4q7THZGfX8ZZjnT Gp/SOjSSCx+k0oBQ== To: jun qian Cc: kernel test robot , peterz@infradead.org, will@kernel.org, luto@kernel.org, linux-kernel@vger.kernel.org, Uladzislau Rezki , Yafang Shao , lkp@lists.01.org Subject: Re: [Softirq] a76eadba0d: WARNING:at_net/mac80211/rx.c:#ieee80211_rx_napi[mac80211] In-Reply-To: References: <20200723091715.GL19262@shao2-debian> <87v9iexztl.fsf@nanos.tec.linutronix.de> <874kpyxpro.fsf@nanos.tec.linutronix.de> Date: Sat, 25 Jul 2020 01:31:37 +0200 Message-ID: <87y2n8sd5y.fsf@nanos.tec.linutronix.de> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org jun qian writes: > I have two questions that need to be discussed. > > 1. If the __do_sofrirq() is executed in the ksoftirqd, we may not need > to check the timeout in the loop. > 2. Both the invoke_softirq() and run_ksoftirqd() will execute > __do_sofirq, they all execute the same code=EF=BC=8C > when it is in the ksoftirqd, Do we need to wake up ksoftirqd in > the process context according to > max_restart and MAX_SOFTIRQ_TIME. In my opinion, If we use a flag > to distinguish where > __do_softirq() is called from, we can do what is most suitable > for __do_softirq based on this flag. You answered your questions yourself :)