Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Sat, 25 Jul 2020 09:29:36 +0200
From:   Johan Hovold <johan@kernel.org>
To:     Li Heng <liheng40@huawei.com>
Cc:     johan@kernel.org, elder@kernel.org, gregkh@linuxfoundation.org,
        viresh.kumar@linaro.org, greybus-dev@lists.linaro.org,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH] svc: add missed destroy_workqueue when gb_svc_create
 fails
Message-ID: <20200725072936.GQ3634@localhost>
References: <1595646397-53868-1-git-send-email-liheng40@huawei.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <1595646397-53868-1-git-send-email-liheng40@huawei.com>
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Sat, Jul 25, 2020 at 11:06:37AM +0800, Li Heng wrote:
> destroy_workqueue() should be called to destroy svc->wq
> when gb_svc_create() init resources fails.
> 
> Fixes: 8465def499c7 ("staging: greybus: move the greybus core to drivers/greybus")
> Reported-by: Hulk Robot <hulkci@huawei.com>
> Signed-off-by: Li Heng <liheng40@huawei.com>
> ---
>  drivers/greybus/svc.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/greybus/svc.c b/drivers/greybus/svc.c
> index ce7740e..38f858f 100644
> --- a/drivers/greybus/svc.c
> +++ b/drivers/greybus/svc.c
> @@ -1340,6 +1340,7 @@ struct gb_svc *gb_svc_create(struct gb_host_device *hd)
>  
>  err_put_device:
>  	put_device(&svc->dev);
> +	destroy_workqueue(svc->wq);

Your bot is broken; the workqueue is released in gb_svc_release(). 

And please fix your internal review process so that you catch things
like this before posting.

>  	return NULL;
>  }

Johan