Received: by 2002:a25:e74b:0:0:0:0:0 with SMTP id e72csp2784207ybh;
        Sat, 25 Jul 2020 01:16:01 -0700 (PDT)
X-Google-Smtp-Source: ABdhPJztG9PILhykrZVGcQAh18hWT8cuh75LKHqKr7nbFOeyXlQ3sic6fq20l+W+CYKhjM8u5Psa
X-Received: by 2002:a17:906:87c8:: with SMTP id zb8mr12492687ejb.35.1595664961253;
        Sat, 25 Jul 2020 01:16:01 -0700 (PDT)
ARC-Seal: i=1; a=rsa-sha256; t=1595664961; cv=none;
        d=google.com; s=arc-20160816;
        b=pyZCWEtWEfp+l0SQIGxcOARGII0zJj1scyfhpbBXVnLaA35CF1d6WFqHFzMfH2k0ry
         oAx5Qa4v8Mf/wd1tsFIY/n3hGyXvlqKXJTG2MDT3kQ0JS6dnrXRJmGpanZJdG8489y2Y
         S6Wp3B3l5UoPoT2hf9Vseve4QN9zax7cEffLDss6gtkw6cuOXdl6pY63fi8Je7AFgxZZ
         oisq/CBFaWE7EoLpJkQBLvG5Tu1Uk1UdyiSX8RaCtaUbi+OzSsTR1Z4GGNiywYJKII9p
         Dp3206sfVa5e5zfAIwqaBQ34ZSi/8GbjYg9P/jWSGvSMfqa/wvHCE6/TCQWBuOj7eJZ/
         g/fg==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816;
        h=list-id:precedence:sender:thread-index:thread-topic
         :content-transfer-encoding:mime-version:subject:references
         :in-reply-to:message-id:cc:to:from:date;
        bh=Bf44xyknm+V7+NzVSzBLlutDaDpT1YnKKX+fBlrRP/Q=;
        b=n8ZHxNWy/cud6eLXfCuATTtizriTam/Ak2VUIDLS3YeEdTalOmWHDDLL8NQol3nInP
         txcFfckrkjyxGwr6nPLfAHg46iCi+UAj9VMV9tvtaKxDQpAD8vDkr6T32en76kWNwCuK
         qPhewtWcSnWc+Wy++px9UpEJnJRzXOQU8eop2hlHU1SI/Zfedj98lj6/3yZHWPNxFI8e
         ai8Z0HKgau3GWqjVOZ2N68tEdcJMlEd1/LYL5g3QpSzMKWzJTYVEqvMN48SaaE2L6uFv
         wwzkkCre/6NOuEC5rAlthX1qM5Fhqnc2u1PBi0ER+KlRyZzB9QpI3PIZqKdAbFODXCMQ
         j/OQ==
ARC-Authentication-Results: i=1; mx.google.com;
       spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18])
        by mx.google.com with ESMTP id jo13si1988467ejb.198.2020.07.25.01.15.38;
        Sat, 25 Jul 2020 01:16:01 -0700 (PDT)
Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Authentication-Results: mx.google.com;
       spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1726711AbgGYINS convert rfc822-to-8bit (ORCPT
        <rfc822;peterpeng024@gmail.com> + 99 others);
        Sat, 25 Jul 2020 04:13:18 -0400
Received: from lithops.sigma-star.at ([195.201.40.130]:36688 "EHLO
        lithops.sigma-star.at" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1725944AbgGYINR (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Sat, 25 Jul 2020 04:13:17 -0400
Received: from localhost (localhost [127.0.0.1])
        by lithops.sigma-star.at (Postfix) with ESMTP id F303D6071A74;
        Sat, 25 Jul 2020 10:13:14 +0200 (CEST)
Received: from lithops.sigma-star.at ([127.0.0.1])
        by localhost (lithops.sigma-star.at [127.0.0.1]) (amavisd-new, port 10032)
        with ESMTP id mmZdptfRQbs3; Sat, 25 Jul 2020 10:13:13 +0200 (CEST)
Received: from localhost (localhost [127.0.0.1])
        by lithops.sigma-star.at (Postfix) with ESMTP id EC4D26071A7C;
        Sat, 25 Jul 2020 10:13:12 +0200 (CEST)
Received: from lithops.sigma-star.at ([127.0.0.1])
        by localhost (lithops.sigma-star.at [127.0.0.1]) (amavisd-new, port 10026)
        with ESMTP id 7pjzFcqw8NDv; Sat, 25 Jul 2020 10:13:12 +0200 (CEST)
Received: from lithops.sigma-star.at (lithops.sigma-star.at [195.201.40.130])
        by lithops.sigma-star.at (Postfix) with ESMTP id C40136071A74;
        Sat, 25 Jul 2020 10:13:12 +0200 (CEST)
Date:   Sat, 25 Jul 2020 10:13:12 +0200 (CEST)
From:   Richard Weinberger <richard@nod.at>
To:     Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc:     Wei Yongjun <weiyongjun1@huawei.com>,
        Miquel Raynal <miquel.raynal@bootlin.com>,
        Vignesh Raghavendra <vigneshr@ti.com>,
        linux-mtd <linux-mtd@lists.infradead.org>,
        linux-kernel <linux-kernel@vger.kernel.org>,
        kernel-janitors <kernel-janitors@vger.kernel.org>,
        Hulk Robot <hulkci@huawei.com>
Message-ID: <265316380.171213.1595664792652.JavaMail.zimbra@nod.at>
In-Reply-To: <20200725063701.GA1058480@kroah.com>
References: <20200725063416.172037-1-weiyongjun1@huawei.com> <20200725063701.GA1058480@kroah.com>
Subject: Re: [PATCH -next] mtd: fix missing unlock on error in
 mtdchar_compat_ioctl()
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 8BIT
X-Originating-IP: [195.201.40.130]
X-Mailer: Zimbra 8.8.12_GA_3807 (ZimbraWebClient - FF68 (Linux)/8.8.12_GA_3809)
Thread-Topic: fix missing unlock on error in mtdchar_compat_ioctl()
Thread-Index: unRYG1XOaa/d55A4orlZmW/yp+6gkg==
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

----- Ursprüngliche Mail -----
> Von: "Greg Kroah-Hartman" <gregkh@linuxfoundation.org>
> An: "Wei Yongjun" <weiyongjun1@huawei.com>
> CC: "Miquel Raynal" <miquel.raynal@bootlin.com>, "richard" <richard@nod.at>, "Vignesh Raghavendra" <vigneshr@ti.com>,
> "linux-mtd" <linux-mtd@lists.infradead.org>, "linux-kernel" <linux-kernel@vger.kernel.org>, "kernel-janitors"
> <kernel-janitors@vger.kernel.org>, "Hulk Robot" <hulkci@huawei.com>
> Gesendet: Samstag, 25. Juli 2020 08:37:01
> Betreff: Re: [PATCH -next] mtd: fix missing unlock on error in mtdchar_compat_ioctl()
> I think Richard already resolved this in his tree, but I could be wrong.

Yes, fixed in git://git.kernel.org/pub/scm/linux/kernel/git/mtd/linux.git mtd/fixes
and should be visible in linux-next very soon.
 
> And nice detection by your bot, that's good to see.

Yeah, good to see that such issues are being detected automatically.

Thanks,
//richard