Received: by 2002:a25:e74b:0:0:0:0:0 with SMTP id e72csp2787321ybh; Sat, 25 Jul 2020 01:23:18 -0700 (PDT) X-Google-Smtp-Source: ABdhPJysA0RbgH+phAVGZxU6YZzlZSMpI9T/fUNwWlI8xTQ0zLODWtRdDV8jcgHw6wkJtPhTqUi0 X-Received: by 2002:a17:906:2b54:: with SMTP id b20mr12587467ejg.366.1595665398317; Sat, 25 Jul 2020 01:23:18 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1595665398; cv=none; d=google.com; s=arc-20160816; b=n06HEglzX9y6h2isVBHQlFew4C+vVDhg+m8lXTes3cHwFLTeXGw0VJZ/q/r3e4gV3Z 4RjSfSZW0d5+PBe75/ty1DNI/bDjmoaemp0fTM1jwFzVOecNBEF8vBPaEzqGms/Gji8T sK6iJEtjgxvQ96EyBVFsKPwyVrtAmSxF5AHTeWPhzjMfC/f3p/Z3g6aL5XCRVo5M4HDf BVaWwXLNtNiMKkFsOxcfni9e4d+ue/RV2qU6U1+TSRfhSD+eg826LnT7AJzNrVel/tBp LAXnhU1jr/qn9js2oM+kPr6+gfQSLf1urVuDTuXi7p2/0mr0RzxjvDH7eK5BIqKFPsSR tM/g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from; bh=+8ChgzF4uwxsSD6Jb27DQARhsmM00IH2ZEqAH0DHASQ=; b=XQx3S1UyY2zgYcreqA98jsIPno0Es4+mJ40jLgm520TZiLxXeiFAYuf0fJ3VaFJdmm bJ5MH7GU4syBt0H7yBT7UTAVsWJl+mdkNj32hisgMbJqio7KYb1rfTHUTHoK/qdhVNM7 +Fb8j87/LGRZJqxDjEW2xodFfsJD6MZh+LLzKZoaISOJ3C/+ZwgdzndsNYBO0LhiZbkM /gPKtRBKmkDF6Om9cdX767ghAFgqErqfbGNTG1D+7wMWMZg3panjdlpAuTX66Z1sBn6h ULuNzKLR2Wmq1FniJI1tczxFlV6Ell7aX1gNBJN4uvRMARF6yol4O6++cV/fJpdoQD69 +njw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id l21si2235151ejg.690.2020.07.25.01.22.55; Sat, 25 Jul 2020 01:23:18 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726805AbgGYIUw (ORCPT + 99 others); Sat, 25 Jul 2020 04:20:52 -0400 Received: from szxga04-in.huawei.com ([45.249.212.190]:8823 "EHLO huawei.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1726540AbgGYIUv (ORCPT ); Sat, 25 Jul 2020 04:20:51 -0400 Received: from DGGEMS401-HUB.china.huawei.com (unknown [172.30.72.58]) by Forcepoint Email with ESMTP id A4B2DBF548CF5B8AA0AE; Sat, 25 Jul 2020 16:20:48 +0800 (CST) Received: from huawei.com (10.69.192.56) by DGGEMS401-HUB.china.huawei.com (10.3.19.201) with Microsoft SMTP Server id 14.3.487.0; Sat, 25 Jul 2020 16:20:41 +0800 From: Luo Jiaxing To: , CC: , , , , , , Subject: [PATCH v2 1/2] scsi: libsas: delete postreset at sas_sata_ops Date: Sat, 25 Jul 2020 16:18:50 +0800 Message-ID: <1595665131-24543-2-git-send-email-luojiaxing@huawei.com> X-Mailer: git-send-email 2.7.4 In-Reply-To: <1595665131-24543-1-git-send-email-luojiaxing@huawei.com> References: <1595665131-24543-1-git-send-email-luojiaxing@huawei.com> MIME-Version: 1.0 Content-Type: text/plain X-Originating-IP: [10.69.192.56] X-CFilter-Loop: Reflected Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org We fill postreset with ata_std_postreset() at sas_sata_ops before, but we found out that ata_std_postreset() call sata_scr_read()/sata_scr_write() which need to access SCR register. Actually we don't own these kind of register, so sata_scr_read()/sata_scr_write always return -EOPNOTSUPP. We drop ata_std_postreset() at sas_sata_ops. Signed-off-by: Luo Jiaxing Reviewed-by: John Garry Reviewed-by: Jason Yan --- drivers/scsi/libsas/sas_ata.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/scsi/libsas/sas_ata.c b/drivers/scsi/libsas/sas_ata.c index 5d716d3..a7d16d2 100644 --- a/drivers/scsi/libsas/sas_ata.c +++ b/drivers/scsi/libsas/sas_ata.c @@ -510,7 +510,6 @@ void sas_ata_end_eh(struct ata_port *ap) static struct ata_port_operations sas_sata_ops = { .prereset = ata_std_prereset, .hardreset = sas_ata_hard_reset, - .postreset = ata_std_postreset, .error_handler = ata_std_error_handler, .post_internal_cmd = sas_ata_post_internal, .qc_defer = ata_std_qc_defer, -- 2.7.4