Received: by 2002:a25:e74b:0:0:0:0:0 with SMTP id e72csp2838901ybh; Sat, 25 Jul 2020 03:13:52 -0700 (PDT) X-Google-Smtp-Source: ABdhPJyOi24KzfucYGenngXzhjhyIIgRtV8BWgFhIAk3xDBWM9O85NyuTMJozvkVNmaK9t+zst1A X-Received: by 2002:a05:6402:1ca8:: with SMTP id cz8mr12370658edb.55.1595672032311; Sat, 25 Jul 2020 03:13:52 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1595672032; cv=none; d=google.com; s=arc-20160816; b=zpr14LqBTM61N+mWSq+yaxQ50gYHUhTSA6W7xEfU6l4wRriP8WjARUXVFtvW7VldFK R3nFvKWYaByY6rt+idW9HPtCLd/NnpYZRaJuYL2fJvam/J+Tauok0ah6cUlYsKOrn2Wf dmfSNIs9BBzlZsr8JpcicDEHOnTMwQ0vduJOjhP8mTCMRdTY7IZqpGoOAVe6zw5DqPkW vU0SotG6vDFAzli00AmoBrhCH0CoKQWsTUKa4TfxN256KeQiVJEvmm6+Ttbf+dzaVAIF KDIp4TwlDiJhC1KRW1oMW8XqBm8LOhBZf9/6lcyH/2BGT2jvyxq43ZPBGJ4bJKbNkQVD qzWQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:in-reply-to:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :dkim-signature; bh=KqTDJd9ETHcS3v7tmJFCw8WBpPbyh+LALlwkboMEuv0=; b=GNJcnLq0nzll8FKV2G7/A1P4idhe7UmPvybgQb/+46hGbZQpRQxgvRRyjgKaYVfaq3 MA/Ba4UguIhxiEBd7gzmdLnqRIvj/zgFUewxVoTGPABcanWlswwESiH1YlsU3I/ZHVar uuRWQ+VmA8PC8rQw7nXt9PehhlS2u7/lQgkwnzgECctCk2XFoIB+7brbeGKOiXQDff9J ArL1aIbU90TO+AXvmybe1d2NqXkfPO8F1GW0Z3e6Ws5ofxd8bU6PwUG7mz9Ojn2hbclJ DanXia3Hn0jmFrrTT/Nu3HTkew2U0PzpsBcTEr0VN5ockXlD0Bp1lbQ8rcnDG35vGGRF 1Vuw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=csoeNhZK; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id t25si2149129edr.537.2020.07.25.03.13.28; Sat, 25 Jul 2020 03:13:52 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=csoeNhZK; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726857AbgGYKHB (ORCPT + 99 others); Sat, 25 Jul 2020 06:07:01 -0400 Received: from mail.kernel.org ([198.145.29.99]:47284 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726572AbgGYKHA (ORCPT ); Sat, 25 Jul 2020 06:07:00 -0400 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id F3EA3206D7; Sat, 25 Jul 2020 10:06:59 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1595671620; bh=DXKTp7F9hVX/ZMZ3cMvlM+waZARTWo/ANSvb7sYnEho=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=csoeNhZKhfy/PaKNHDzhb6fewTblIs59HKYmONeMkW7H74jifgwJGAr6lPRX4Vxlw Z7+gvZk8JV6ESWik0r9XZf9nTKM+BHkr7Qjq2D4AQsu3HRqL+SabERQUdkBlDdSpup e4N/tbzlVOUSYcVU4+kHmshhXryc9aBAsUBwgFMM= Date: Sat, 25 Jul 2020 12:07:00 +0200 From: Greg Kroah-Hartman To: Kees Cook Cc: stable@vger.kernel.org, Scott Branden , Mimi Zohar , Luis Chamberlain , Jessica Yu , SeongJae Park , KP Singh , linux-efi@vger.kernel.org, linux-security-module@vger.kernel.org, linux-integrity@vger.kernel.org, selinux@vger.kernel.org, linux-kselftest@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v3 03/19] firmware_loader: EFI firmware loader must handle pre-allocated buffer Message-ID: <20200725100700.GB1073708@kroah.com> References: <20200724213640.389191-1-keescook@chromium.org> <20200724213640.389191-4-keescook@chromium.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200724213640.389191-4-keescook@chromium.org> Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Jul 24, 2020 at 02:36:24PM -0700, Kees Cook wrote: > The EFI platform firmware fallback would clobber any pre-allocated > buffers. Instead, correctly refuse to reallocate when too small (as > already done in the sysfs fallback), or perform allocation normally > when needed. > > Fixes: e4c2c0ff00ec ("firmware: Add new platform fallback mechanism and firm ware_request_platform()") "firmware_request_platform()" :)