Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S964804AbWEJUgV (ORCPT ); Wed, 10 May 2006 16:36:21 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S964777AbWEJUgV (ORCPT ); Wed, 10 May 2006 16:36:21 -0400 Received: from emailhub.stusta.mhn.de ([141.84.69.5]:40978 "HELO mailout.stusta.mhn.de") by vger.kernel.org with SMTP id S964789AbWEJUgU (ORCPT ); Wed, 10 May 2006 16:36:20 -0400 Date: Wed, 10 May 2006 22:36:22 +0200 From: Adrian Bunk To: Steven Rostedt , Stephen Hemminger Cc: Daniel Walker , Alan Cox , akpm@osdl.org, LKML Subject: Re: [PATCH -mm] sys_semctl gcc 4.1 warning fix Message-ID: <20060510203622.GT3570@stusta.de> References: <200605100256.k4A2u8bd031779@dwalker1.mvista.com> <1147257266.17886.3.camel@localhost.localdomain> <1147271489.21536.70.camel@c-67-180-134-207.hsd1.ca.comcast.net> <1147273787.17886.46.camel@localhost.localdomain> <1147273598.21536.92.camel@c-67-180-134-207.hsd1.ca.comcast.net> <20060510162404.GR3570@stusta.de> <20060510202401.GS3570@stusta.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20060510202401.GS3570@stusta.de> User-Agent: Mutt/1.5.11+cvs20060403 Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1763 Lines: 49 On Wed, May 10, 2006 at 10:24:01PM +0200, Adrian Bunk wrote: > On Wed, May 10, 2006 at 01:45:58PM -0400, Steven Rostedt wrote: > > > > Oh fsck! gcc is hosed. I just tried out this BS module: > >... > > And this is what I got! > > > > CC [M] /home/rostedt/c/modules/warning.o > > /home/rostedt/c/modules/warning.c: In function 'warn_here': > > /home/rostedt/c/modules/warning.c:14: warning: 'x' is used uninitialized in this function > > Building modules, stage 2. > > > > > > Why the fsck isn't the func but_not_here not getting a warning for the > > first use of printk?? If I remove the if statement it gives me the > > warning. Hell, that if statement isn't even entered (g = 0). > >... > > I can't reproduce this, gcc 4.1 gives me: > > CC [M] init/test.o > init/test.c: In function 'warn_here': > init/test.c:14: warning: 'x' is used uninitialized in this function > init/test.c: In function 'but_not_here': > init/test.c:23: warning: 'y' is used uninitialized in this function Same with gcc 4.0. I can reproduce your problem only with gcc 3.3 and gcc 3.4. Can we please discuss issues in current gcc releases instead of gcc bashing ("Oh fsck! gcc is hosed.") based on issues no longer present in the latest two major releases of gcc? TIA Adrian -- "Is there not promise of rain?" Ling Tan asked suddenly out of the darkness. There had been need of rain for many days. "Only a promise," Lao Er said. Pearl S. Buck - Dragon Seed - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/