Received: by 2002:a25:e74b:0:0:0:0:0 with SMTP id e72csp2878708ybh; Sat, 25 Jul 2020 04:29:12 -0700 (PDT) X-Google-Smtp-Source: ABdhPJynGhCeEOnFB9rI0NdScNS5xJyn85mp1QK5rJje8HybHX6Qwi2z4exyI1JAIh5oJ5z+Eug7 X-Received: by 2002:a17:906:eb11:: with SMTP id mb17mr5909556ejb.501.1595676552574; Sat, 25 Jul 2020 04:29:12 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1595676552; cv=none; d=google.com; s=arc-20160816; b=ieupVvQsAFo0aIPpVdyB1t3W3uK03Dsg5w9ySRI1ccoM6NSiPGLpdn1ENKY3/HNRDD yjSgtECllQCIyJSnSL01LQcuLk3feRSIT5gN8M/j5dexlofv+pmv54kAKPKgQrESNXrT ZvQo5oAqsnMguilwHKf6zjyjjIDV+SuxiGf1RYKoEDrN3w7vnS+XZfCg+m1C0MJc4Od1 +8rVQdblUX06wk1/R6tcbEo6tlbkDaCQRKY5alAvyx9MGLD//SHCe1PFvadztz8SjNGu OqFRaYcHXBspf/eZPY/80ZdWnYZsE4jUabizTUd2r+7VmhR+xJeuWo8Tn2UJfFWb0GK9 rEUg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding :content-language:mime-version:user-agent:date:message-id:autocrypt :from:subject:cc:to:dkim-signature; bh=3/3s19FINLS3HQNYDltRpdY6lWUimUQCQyW/z/gJlq8=; b=t8PUH6jAgFP/ONMPSK7/NAg51+ozSa4tZsSyZCeiYVqcNrcao4h5K+LuFMiKpwjwIi JPsxd9RLsMmuUKbggagZqYopG+Sa+r+VHJQYmSmzdr5yMQiSb1F3HM4JVJCsSzZ4EJsh IFAEa3LNjXNkyykvczEqcZ4rXBq4jOoL2rP7eoBNtWSyac0TlgOuCCm19usNqzF+nGe+ iig5dg1va1//yyef3nCPlV6hRXyUYivFwMXoADZgE2ZJrr95CRUlKVgh4EIjqXNfYR/O CGBnpk2H750d+4/VSUAoFhuRncNPHj7za0geCduynfqSYg/hfENq3hdE2GRnGp60Lw1Z Pdyw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@web.de header.s=dbaedf251592 header.b=Kwiw857J; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id b14si2280145edx.461.2020.07.25.04.28.49; Sat, 25 Jul 2020 04:29:12 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@web.de header.s=dbaedf251592 header.b=Kwiw857J; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726904AbgGYL2o (ORCPT + 99 others); Sat, 25 Jul 2020 07:28:44 -0400 Received: from mout.web.de ([212.227.15.3]:59721 "EHLO mout.web.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726612AbgGYL2n (ORCPT ); Sat, 25 Jul 2020 07:28:43 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=web.de; s=dbaedf251592; t=1595676481; bh=tL632JoesBjA1nIjOOtilNQQx0JJmdlSdql+Vgh01R0=; h=X-UI-Sender-Class:To:Cc:Subject:From:Date; b=Kwiw857J2bBKYJHL9hwvp6Z/paHUma/WSxf9EGc+2UfXG/IPcRPIF+/BOEwWwsrA8 5vqLHZutxZf/lffPP6kUE5BhsWux3O4nltK9r1SzskyRXquyL7VVo1TmoQDg3pQ/5/ EoMP7Vp3UBCoKt7+t9WeXIqXEo/GF7XFxzprixdE= X-UI-Sender-Class: c548c8c5-30a9-4db5-a2e7-cb6cb037b8f9 Received: from [192.168.1.2] ([93.135.94.55]) by smtp.web.de (mrweb002 [213.165.67.108]) with ESMTPSA (Nemesis) id 0MMFB7-1jrrAL42Pd-0085d8; Sat, 25 Jul 2020 13:28:01 +0200 To: Yi Wang , Liao Pingfang , linux-sh@vger.kernel.org Cc: kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org, Andrew Morton , Peter Zijlstra , Rich Felker , Wang Liang , Xue Zhihong , Yoshinori Sato Subject: Re: [PATCH] sh: sh4: Fix reference count leak in sq_dev_add From: Markus Elfring Autocrypt: addr=Markus.Elfring@web.de; prefer-encrypt=mutual; keydata= mQINBFg2+xABEADBJW2hoUoFXVFWTeKbqqif8VjszdMkriilx90WB5c0ddWQX14h6w5bT/A8 +v43YoGpDNyhgA0w9CEhuwfZrE91GocMtjLO67TAc2i2nxMc/FJRDI0OemO4VJ9RwID6ltwt mpVJgXGKkNJ1ey+QOXouzlErVvE2fRh+KXXN1Q7fSmTJlAW9XJYHS3BDHb0uRpymRSX3O+E2 lA87C7R8qAigPDZi6Z7UmwIA83ZMKXQ5stA0lhPyYgQcM7fh7V4ZYhnR0I5/qkUoxKpqaYLp YHBczVP+Zx/zHOM0KQphOMbU7X3c1pmMruoe6ti9uZzqZSLsF+NKXFEPBS665tQr66HJvZvY GMDlntZFAZ6xQvCC1r3MGoxEC1tuEa24vPCC9RZ9wk2sY5Csbva0WwYv3WKRZZBv8eIhGMxs rcpeGShRFyZ/0BYO53wZAPV1pEhGLLxd8eLN/nEWjJE0ejakPC1H/mt5F+yQBJAzz9JzbToU 5jKLu0SugNI18MspJut8AiA1M44CIWrNHXvWsQ+nnBKHDHHYZu7MoXlOmB32ndsfPthR3GSv jN7YD4Ad724H8fhRijmC1+RpuSce7w2JLj5cYj4MlccmNb8YUxsE8brY2WkXQYS8Ivse39MX BE66MQN0r5DQ6oqgoJ4gHIVBUv/ZwgcmUNS5gQkNCFA0dWXznQARAQABtCZNYXJrdXMgRWxm cmluZyA8TWFya3VzLkVsZnJpbmdAd2ViLmRlPokCVAQTAQgAPhYhBHDP0hzibeXjwQ/ITuU9 Figxg9azBQJYNvsQAhsjBQkJZgGABQsJCAcCBhUICQoLAgQWAgMBAh4BAheAAAoJEOU9Figx g9azcyMP/iVihZkZ4VyH3/wlV3nRiXvSreqg+pGPI3c8J6DjP9zvz7QHN35zWM++1yNek7Ar OVXwuKBo18ASlYzZPTFJZwQQdkZSV+atwIzG3US50ZZ4p7VyUuDuQQVVqFlaf6qZOkwHSnk+ CeGxlDz1POSHY17VbJG2CzPuqMfgBtqIU1dODFLpFq4oIAwEOG6fxRa59qbsTLXxyw+PzRaR LIjVOit28raM83Efk07JKow8URb4u1n7k9RGAcnsM5/WMLRbDYjWTx0lJ2WO9zYwPgRykhn2 sOyJVXk9xVESGTwEPbTtfHM+4x0n0gC6GzfTMvwvZ9G6xoM0S4/+lgbaaa9t5tT/PrsvJiob kfqDrPbmSwr2G5mHnSM9M7B+w8odjmQFOwAjfcxoVIHxC4Cl/GAAKsX3KNKTspCHR0Yag78w i8duH/eEd4tB8twcqCi3aCgWoIrhjNS0myusmuA89kAWFFW5z26qNCOefovCx8drdMXQfMYv g5lRk821ZCNBosfRUvcMXoY6lTwHLIDrEfkJQtjxfdTlWQdwr0mM5ye7vd83AManSQwutgpI q+wE8CNY2VN9xAlE7OhcmWXlnAw3MJLW863SXdGlnkA3N+U4BoKQSIToGuXARQ14IMNvfeKX NphLPpUUnUNdfxAHu/S3tPTc/E/oePbHo794dnEm57LuuQINBFg2+xABEADZg/T+4o5qj4cw nd0G5pFy7ACxk28mSrLuva9tyzqPgRZ2bdPiwNXJUvBg1es2u81urekeUvGvnERB/TKekp25 4wU3I2lEhIXj5NVdLc6eU5czZQs4YEZbu1U5iqhhZmKhlLrhLlZv2whLOXRlLwi4jAzXIZAu 76mT813jbczl2dwxFxcT8XRzk9+dwzNTdOg75683uinMgskiiul+dzd6sumdOhRZR7YBT+xC wzfykOgBKnzfFscMwKR0iuHNB+VdEnZw80XGZi4N1ku81DHxmo2HG3icg7CwO1ih2jx8ik0r riIyMhJrTXgR1hF6kQnX7p2mXe6K0s8tQFK0ZZmYpZuGYYsV05OvU8yqrRVL/GYvy4Xgplm3 DuMuC7/A9/BfmxZVEPAS1gW6QQ8vSO4zf60zREKoSNYeiv+tURM2KOEj8tCMZN3k3sNASfoG fMvTvOjT0yzMbJsI1jwLwy5uA2JVdSLoWzBD8awZ2X/eCU9YDZeGuWmxzIHvkuMj8FfX8cK/ 2m437UA877eqmcgiEy/3B7XeHUipOL83gjfq4ETzVmxVswkVvZvR6j2blQVr+MhCZPq83Ota xNB7QptPxJuNRZ49gtT6uQkyGI+2daXqkj/Mot5tKxNKtM1Vbr/3b+AEMA7qLz7QjhgGJcie qp4b0gELjY1Oe9dBAXMiDwARAQABiQI8BBgBCAAmFiEEcM/SHOJt5ePBD8hO5T0WKDGD1rMF Alg2+xACGwwFCQlmAYAACgkQ5T0WKDGD1rOYSw/+P6fYSZjTJDAl9XNfXRjRRyJSfaw6N1pA Ahuu0MIa3djFRuFCrAHUaaFZf5V2iW5xhGnrhDwE1Ksf7tlstSne/G0a+Ef7vhUyeTn6U/0m +/BrsCsBUXhqeNuraGUtaleatQijXfuemUwgB+mE3B0SobE601XLo6MYIhPh8MG32MKO5kOY hB5jzyor7WoN3ETVNQoGgMzPVWIRElwpcXr+yGoTLAOpG7nkAUBBj9n9TPpSdt/npfok9ZfL /Q+ranrxb2Cy4tvOPxeVfR58XveX85ICrW9VHPVq9sJf/a24bMm6+qEg1V/G7u/AM3fM8U2m tdrTqOrfxklZ7beppGKzC1/WLrcr072vrdiN0icyOHQlfWmaPv0pUnW3AwtiMYngT96BevfA qlwaymjPTvH+cTXScnbydfOQW8220JQwykUe+sHRZfAF5TS2YCkQvsyf7vIpSqo/ttDk4+xc Z/wsLiWTgKlih2QYULvW61XU+mWsK8+ZlYUrRMpkauN4CJ5yTpvp+Orcz5KixHQmc5tbkLWf x0n1QFc1xxJhbzN+r9djSGGN/5IBDfUqSANC8cWzHpWaHmSuU3JSAMB/N+yQjIad2ztTckZY pwT6oxng29LzZspTYUEzMz3wK2jQHw+U66qBFk8whA7B2uAU1QdGyPgahLYSOa4XAEGb6wbI FEE= Message-ID: <69b70f2a-c4c9-6dd2-95c7-5858873037b8@web.de> Date: Sat, 25 Jul 2020 13:27:56 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Language: en-GB Content-Transfer-Encoding: quoted-printable X-Provags-ID: V03:K1:sG/y852jU81boQ3F8W/bwzbm1EGUa8mk5sueiIiGGdI2y4Ks1SK UTrgdpVuDNgIRBCu/XPTbD1VizJ6vQPTdmq9Ax+WfZjHtndM0v2t0+0paWR+eSo7FG4c4Lp 3xMvGclh2mJJRuq/r7vExmhlhwWpA5kMvBYDJRTMrUJRSt9j3eQNudJHI1cMGmxNHysJjrz VTMx/LTBeDlEH9vhot0eA== X-Spam-Flag: NO X-UI-Out-Filterresults: notjunk:1;V03:K0:RiqtQUvptJo=:fI+HNEkVYhxGL3dPvZg9yW 8Q4mnC8X6Ku7EUAaXTGPffccTRykxbPvMxwxXQs2sbf3PGMiwAhtCGCOZNxw/bzS/fzx3QPmp C+Ff5cwbnyvB/pbhUqr9NeP2dfTOe4niNNuxIss4Hphy38znaXih0zHwIN+6e5X6QVNL43Yjy xwlnwg2piVqO/mertdKnDokxEaKJ6l7T2j/xMyK0dKpbbGk7yIOEzq+M1D06bMBi4U61ZHvnO 9iLVubibmASJTSyFzPLuRvla5vpXrlawYeuHkBcV3bVDiqcfqKMJQRiJc0w0L6bbVaFVBhORY aCwn/34Xj8+XmRULzZnCaU+YwpARQMT0zYhYwVMmsM0h7VRgDLqfffWZ+7XUIhIg1jhOCqaka w6j+6SojksRmfRrDEclDh10/zZuvcJzieDCS2YISsFeROnFcwRJ7m+TKoC+uKhghpNoXdP6l3 8DkPPonTmqjGbrAGnMDBShoXmbx1hnYaVgjwnEGigwbA7Wo0YiBI0YV6vXh8h+5IBrdAOV7+Q BTTuHWD3Hh0wfb5rY6X3ZiiuoNBJhCOAhcHisHX7wJUKz/S1RP+NmvYxaWGOxPjLFiKLwll3E SBKy3jQcCnnE9YQbsABHrsCIGS5cA4h9YXcRmmyfFVcj8JeAmBX4Twiiw6pc7R0Qpx3FxDkiU Pw9Kslkf1HSVcMQqVLhx0iY9CtAhQnQx5C6DvthFi3CNdb+IWSXQQ1Wb6cIKlBtQA/5QiH0p2 ssqFmqbhs77aJzB8GmLqgdHBdNL3zbzoOAGQolPOMtnqJzGILEI7kaRF1QLcM0fOFJYX+5qj+ e8noqqSMYRZcbT0v4+VaR55VLhQamqIwaff/ETaPVjeZCfeDt7LcuKo+fhgYPMW0syjVSGCSu Hv05Bh0p1tp1RCI7YO4cyXonFIrFZIV1diu88grv5jjzGf4YDftQuFrXJ/4ZMNGRFcPX1JPmu O6FJLcp8GbZLbvV0Lg0p1lGLFjRUsQQ8vuVQ1eqYS9f4IimNRfiS6vUjb0w9awyrOxv1NSMt8 Vk3jiFGMQqLla2D1OE3XHI1aKHz5QwQEJ0MMq1mIYPjfyZHHUgA6KiYUWoQfsq11AuyQOcOIt Rntprd4ZKfdZBCkXetu9m38D2bBjyo1GrWqxhNqu9zGbUxrNTpHIREbLPMM+kXfgIC5r4WZY6 LvzYLTfotgwAmFYvDApxiqkekkzIollD+BLLLYtqYIXxropLx/xA7RTueZPa+zScsfYvAJ8cg 9JTI/3ckKrOyFfJY3UhoORWJrY5CPQZlyUo/x7A== Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org > kobject_init_and_add() takes reference even when it fails. If this > function returns an error, kobject_put() must be called to properly > clean up the memory associated with the object. * An imperative wording can be preferred for the change description, can't it? * Would you like to add the tag =E2=80=9CFixes=E2=80=9D to the commit mess= age? Regards, Markus