Received: by 2002:a25:e74b:0:0:0:0:0 with SMTP id e72csp2978981ybh; Sat, 25 Jul 2020 07:24:36 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzQmyO2xiUINNdBXCPKOWre/A6EMx7Q3BcRb23n49EyaNfx5V+yD6QQY4YqMo1jZVBF+zxN X-Received: by 2002:a05:6402:cb:: with SMTP id i11mr1037753edu.372.1595687075909; Sat, 25 Jul 2020 07:24:35 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1595687075; cv=none; d=google.com; s=arc-20160816; b=jbCj0fRDFMlHlkk0r/rLRx+wSUzkYKDtn2F0cvR+TsnZFtodWN9F23r7mf9MLIHAcB CyLqVDjIlmZC6bb86rn+jyVurF4FxpGb+Nftm5jEYKb3gcnuqpHRK+FTbqI1stXkixvq fttkK+5NsMWBZw/39fpg2kb6tiLeni2/s4Ca134cmiJNh2gwjFGVhes3rSRGpbzmV5pn 5B2I3p4LJevG72m68/LxB044J6fzbi/B+1wd/da3VB54ZDJkIYg9JVW8gHVUetPsgQU+ 9LyzP3Tc7qeXNZ26QNXd1Lyw+QOiCBH4JYcseWb7k5zbcTVPOQ1FW58VO7UuGAMmSwnm FN9Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=RHuG1PJYfrzWdsPUp2gaDAJoCZZjnDUJ70n4BU3OuV0=; b=jdJqzJMssyoLIQMqNEj4GJ8TNkSbDQP7ue02/IjuVw3wxzXRdD0C1vumMsIiCQHunF 1KpXlCtNy8dFQMiSn+J7Sfrl+MP33Vw12Ig0MGekNkDT54DH1vG8nbjzH2wNnW5HusD9 0Nu1mx+vkKku6DT5PqQ1P4+rLE0JaKsAk1Za3z4JIVit1+kMWqiZ9D0ZtPhiuQ3OVgqe TE3WQIe2CPC1oyU95Bk8yFB8J0YfpGW+pI5iPXt4+N0BwXsGMlzi9SXRr+vEQ++donyf GCNLIhtZYxWMdb1v/nPm4kpYPSfDdd4Th/Ak/sEsn0481b62qsl5IvuDM8dFu41Mk3xJ sAig== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b="ZtPTk/Pk"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id x17si2777305edq.518.2020.07.25.07.24.05; Sat, 25 Jul 2020 07:24:35 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b="ZtPTk/Pk"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727836AbgGYOXy (ORCPT + 99 others); Sat, 25 Jul 2020 10:23:54 -0400 Received: from mail.kernel.org ([198.145.29.99]:42180 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727819AbgGYOXx (ORCPT ); Sat, 25 Jul 2020 10:23:53 -0400 Received: from disco-boy.misterjones.org (disco-boy.misterjones.org [51.254.78.96]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 92CAC2074A; Sat, 25 Jul 2020 14:23:52 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1595687032; bh=HgKb2gMwLhyoVgicuPtR2MT47iWJoelMNq4UC+XQ968=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=ZtPTk/PkmwauIApJUo7+g3hHyOOyUUj6eTTExaOtlePSByjL7a3erBMEzio5DkdKG JEyUty6h9YKBmT4C/hm4mzKrirHw6eCac8/mZKLcKxFTGkC3cZANnDSd/gq2JjyYRA mHkl0FCQd6aq4baBYiK88Rt6FkKnnSKZLW5Ad7KE= Received: from 78.163-31-62.static.virginmediabusiness.co.uk ([62.31.163.78] helo=wait-a-minute.lan) by disco-boy.misterjones.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1jzL5b-00Er45-3s; Sat, 25 Jul 2020 15:23:51 +0100 From: Marc Zyngier To: Jason Cooper , Alexandre Torgue , Thomas Gleixner , Zenghui Yu , linux-kernel@vger.kernel.org Cc: linux-gpio@vger.kernel.org, marex@denx.de, linux-stm32@st-md-mailman.stormreply.com, linux-arm-kernel@lists.infradead.org, stable@vger.kernel.org, wanghaibin.wang@huawei.com Subject: Re: [PATCH v2] irqchip/gic-v4.1: Ensure accessing the correct RD when writing INVALLR Date: Sat, 25 Jul 2020 15:23:35 +0100 Message-Id: <159568680935.564881.3670480595242978406.b4-ty@kernel.org> X-Mailer: git-send-email 2.27.0 In-Reply-To: <20200720092328.708-1-yuzenghui@huawei.com> References: <20200720092328.708-1-yuzenghui@huawei.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-SA-Exim-Connect-IP: 62.31.163.78 X-SA-Exim-Rcpt-To: jason@lakedaemon.net, alexandre.torgue@st.com, tglx@linutronix.de, yuzenghui@huawei.com, linux-kernel@vger.kernel.org, linux-gpio@vger.kernel.org, marex@denx.de, linux-stm32@st-md-mailman.stormreply.com, linux-arm-kernel@lists.infradead.org, stable@vger.kernel.org, wanghaibin.wang@huawei.com X-SA-Exim-Mail-From: maz@kernel.org X-SA-Exim-Scanned: No (on disco-boy.misterjones.org); SAEximRunCond expanded to false Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, 20 Jul 2020 17:23:28 +0800, Zenghui Yu wrote: > The GICv4.1 spec tells us that it's CONSTRAINED UNPREDICTABLE to issue a > register-based invalidation operation for a vPEID not mapped to that RD, > or another RD within the same CommonLPIAff group. > > To follow this rule, commit f3a059219bc7 ("irqchip/gic-v4.1: Ensure mutual > exclusion between vPE affinity change and RD access") tried to address the > race between the RD accesses and the vPE affinity change, but somehow > forgot to take GICR_INVALLR into account. Let's take the vpe_lock before > evaluating vpe->col_idx to fix it. Applied to irq/irqchip-5.9, thanks! [1/1] irqchip/gic-v4.1: Ensure accessing the correct RD when writing INVALLR commit: fdccf1d9d10395abfe082f50694f374997c6e101 Cheers, M. -- Without deviation from the norm, progress is not possible.