From: Michael Buesch <mb@bu3sch.de>
To: Greg KH <gregkh@suse.de>
Subject: Re: [patch 2/6] New Generic HW RNG
Date: Wed, 10 May 2006 23:18:16 +0200
User-Agent: KMail/1.9.1
References: <20060507113513.418451000@pc1> <200605071516.09167.mb@bu3sch.de> <20060510205743.GC23446@suse.de>
In-Reply-To: <20060510205743.GC23446@suse.de>
Cc: Sergey Vlasov <vsu@altlinux.ru>, akpm@osdl.org,
       Deepak Saxena <dsaxena@plexity.net>, bcm43xx-dev@lists.berlios.de,
       linux-kernel@vger.kernel.org
MIME-Version: 1.0
Content-Type: text/plain;
  charset="iso-8859-1"
Content-Transfer-Encoding: 7bit
Content-Disposition: inline
Message-Id: <200605102318.16939.mb@bu3sch.de>
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 999
Lines: 26

On Wednesday 10 May 2006 22:57, you wrote:
> On Sun, May 07, 2006 at 03:16:08PM +0200, Michael Buesch wrote:
> > On Sunday 07 May 2006 15:03, you wrote:
> > > > +	list_for_each_entry(rng, &rng_list, list) {
> > > > +		if (strncmp(rng->name, buf, len) == 0) {
> > > 
> > > This will match if the passed string is just a prefix of rng->name.
> > > Apparently sysfs guarantees that the buffer passed to ->store will be
> > > NUL-terminated, so this should be just a strcmp().
> > 
> > I am not sure if it is guaranteed NUL terminated. Greg?
> > But I will look into this.
> 
> Yes it will be.

Ok, very nice.
I will resend the patches as soon as I have some time.
I also splitted up the x86 drivers. Looks very good and clean now. ;)

-- 
Greetings Michael.
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/