Received: by 2002:a25:e74b:0:0:0:0:0 with SMTP id e72csp3069702ybh; Sat, 25 Jul 2020 10:01:19 -0700 (PDT) X-Google-Smtp-Source: ABdhPJymaDGg77ahIM20091DWT/fxeavgIKtr7cE6EE4Nu6MGRSNR/VjQZZq2gkdp2IvemV0D+c0 X-Received: by 2002:aa7:d04e:: with SMTP id n14mr14565222edo.161.1595696479473; Sat, 25 Jul 2020 10:01:19 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1595696479; cv=none; d=google.com; s=arc-20160816; b=kYPsbTDbdjur6ciIQkc6WrjKavmnBIbzJcmCXr0zP2us+E1h2SoWDqSUl9Z6PGqzGq 8uxh35PsGEjMOiCrlu5BDYrMug7UnzXgHx9ELYUP6ayXwQwlp9S4un/Imf7TuLj3F1W0 5k/MySd8+2m2+piBD6F7MuMY5tVvflbxO9pR6TynpkaiT4k0DEPXPl/g+GddHsx4cL2O 0EhK1EbBhR+qbm52QVpiPjDboFGDmv5FfYSoT4e6ZhiTKJFnzVjHQhMEl6nUFDXETvwS 5mk8altdwDGM/7Z8wHzhyI3pmn9+a18ICbw4f89tpCmrEYEcRsQwUGVvVNlC+4X21xAE uPaQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:in-reply-to:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :dkim-signature; bh=6ltveWQkhnBb6mzizvV/wAJDe13OC+WrI+RXwa5RzLM=; b=I89PcG6O+WGjZbVTB6LiuaLZt90S74Y7rlHMKG1Pletcp/4hEfLzfqCHq39o1JOorQ VNy1OHN1hsTVvNKR2BnJW2kXG2x4StGhi1I41/y6SUh3yCE+dGV7PjH3GKSMH414SmRZ Xc22VfrXYqoRV6H5dak3LjdiOQmLL8CAmxwMkYB24YGJ46HMiOXzhvtMkFIx3AZ8OmSu Y5bOyrCrktHkAhakbA0OPsJERExJfk/LLIgsRiRnB4Adta7HKwfgcUexO6MRfxywrzh3 LcOh6Lnd39VciLrS8rFeV3znE/D5oAEvk1tBZun2Qp91mQgHU+1PyXLWZb92kVXlIUlF vklw== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail header.i=@infradead.org header.s=casper.20170209 header.b=OEmj9sk3; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id cz9si2505173edb.530.2020.07.25.10.00.53; Sat, 25 Jul 2020 10:01:19 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=fail header.i=@infradead.org header.s=casper.20170209 header.b=OEmj9sk3; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727119AbgGYQ6r (ORCPT + 99 others); Sat, 25 Jul 2020 12:58:47 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:39290 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726567AbgGYQ6q (ORCPT ); Sat, 25 Jul 2020 12:58:46 -0400 Received: from casper.infradead.org (casper.infradead.org [IPv6:2001:8b0:10b:1236::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id B80F8C08C5C0 for ; Sat, 25 Jul 2020 09:58:46 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=6ltveWQkhnBb6mzizvV/wAJDe13OC+WrI+RXwa5RzLM=; b=OEmj9sk3+aCTN1rhW4dLSnMDAZ KLE97gsN8PEKVIHUn2yVlrD+h8Im9y0R/2+gVRAO9/YCwybxS2sg8DGWM2LfmA0nhHYhVVx2Xp4y0 C6hq8gYsRPEa0NSSIcioNlyU0bYlcFIAxXjthXYtBcXxGQxp3XkwYvU3wtMJ6Uu5ZPSyYUychh3NT 5IcFpdSJaFULTa8PZo9cQ4uVMVkzdG0eAeemBCo9d7W8AXNNe6DpgcriEqY8zwR+laHp2efOxA623 Pu2JWxoWWY+w1/ZUW9Ay+Os14zE8ZDIGUW6Na4sMgmOH82huASuOe99hU5NE8mATyC0/YipbWtBDw njQL/dbA==; Received: from j217100.upc-j.chello.nl ([24.132.217.100] helo=noisy.programming.kicks-ass.net) by casper.infradead.org with esmtpsa (Exim 4.92.3 #3 (Red Hat Linux)) id 1jzNV4-0000Hb-TV; Sat, 25 Jul 2020 16:58:19 +0000 Received: from hirez.programming.kicks-ass.net (hirez.programming.kicks-ass.net [192.168.1.225]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by noisy.programming.kicks-ass.net (Postfix) with ESMTPS id C34B23013E5; Sat, 25 Jul 2020 18:58:16 +0200 (CEST) Received: by hirez.programming.kicks-ass.net (Postfix, from userid 1000) id 5060A20104627; Sat, 25 Jul 2020 18:58:16 +0200 (CEST) Date: Sat, 25 Jul 2020 18:58:16 +0200 From: Peter Zijlstra To: Steven Rostedt Cc: kernel test robot , kbuild-all@lists.01.org, linux-kernel@vger.kernel.org, x86@kernel.org, Ingo Molnar , sfr@canb.auug.org.au Subject: Re: [PATCH v2] sched,tracing: Convert to sched_set_fifo() Message-ID: <20200725165816.GE10769@hirez.programming.kicks-ass.net> References: <202006192249.AYnVBGCH%lkp@intel.com> <20200709124505.GT597537@hirez.programming.kicks-ass.net> <20200709115818.36a956a4@oasis.local.home> <20200720214918.GM5523@worktop.programming.kicks-ass.net> <20200724213911.GX119549@hirez.programming.kicks-ass.net> <20200724174618.7487ee7c@oasis.local.home> <20200724215003.GY119549@hirez.programming.kicks-ass.net> <20200724181846.415bfd43@oasis.local.home> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200724181846.415bfd43@oasis.local.home> Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Jul 24, 2020 at 06:18:46PM -0400, Steven Rostedt wrote: > On Fri, 24 Jul 2020 23:50:03 +0200 > peterz@infradead.org wrote: > > > - if (producer_fifo < 0) > > + if (producer_fifo) > > + trace_printk("Running Producer at SCHED_FIFO %s\n", > > + consumer_fifo == 1 ? "low" : "high"); > > I'm going to take cut-and-paste away from you! Well, yes, I said so, I also already have it fixed. Aside from that, is the patch ok?