Received: by 2002:a25:e74b:0:0:0:0:0 with SMTP id e72csp3082491ybh; Sat, 25 Jul 2020 10:23:20 -0700 (PDT) X-Google-Smtp-Source: ABdhPJyKQL6Ho9LATvBPJ9hT/zq0hr1c/RcaRgyk3Zv+JcG/vGOPICdjdz3zT2WchuAh/CksfDUe X-Received: by 2002:a17:906:269a:: with SMTP id t26mr14119479ejc.286.1595697800351; Sat, 25 Jul 2020 10:23:20 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1595697800; cv=none; d=google.com; s=arc-20160816; b=IDxS9txUQ4fi2NiCicXz4oBxW36hNKSYpAlGVlJKTcKLR2dx3A9Y3xlhAFb2u0WroX 9L0UY3cMJlby1EjYCk20D3bJPt1O+3cwBsgZRgVs4SMpDCCyxuYvh4CbWK0+4ejt6n4o vL00gRxc42sn4o/hW5XTYzMm7WPZZ8N9xSYGFbKshKuqp5ufHx4+KFBubCDA4FNCI3Qf kWu5oVEvYGQAhaiasZUoaGYYpMUkdHdaxf+FHOWI8JffTVLRepgz9umdJiPBslk5PVQd wG7nF8i6hZ7IoJgA39Aj7P560319eShW6+pzTiVA6q/+fsMTDsEaOsDMFGEVab+B2FAN LZ2Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:in-reply-to:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :dkim-signature; bh=4vxUfqijl+Cp0DLW6TemznVtiH45MzuB6akqAES8BeQ=; b=hGh4fk7RGCWQgSaM0XNFA1J/kJ33Gi1EJnfUDOYx2uwdbsUMbEDvKeR/ZGNLGASoug DoQH1RZsHEasomMPnadoFmdAhozWRNZblnmHjD387FzDoZR3qzwAUCYtjmWsy/ewFm/m JhVhK4boQAuTkRnnUM3t+kmKiyrsdPaoQ/LHxcO3s3Ykf5YZZCQq6Izs5FhKpjC8tIwx hAxKcbxL0076XsPmwzYI/BT7YaeNol8B18pK6qUkVOAuj1tn3ibWXdUc9sV8tC+Pv/3U kqSmcJCTPs0cPElWKypWvQ1wNc4fu3SEgRhA7OzAMG8qAQncgPqwBBY+BqgppWEzyWxa rOCQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=x90CcWVO; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id v15si2776816edl.205.2020.07.25.10.22.58; Sat, 25 Jul 2020 10:23:20 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=x90CcWVO; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727125AbgGYRV2 (ORCPT + 99 others); Sat, 25 Jul 2020 13:21:28 -0400 Received: from mail.kernel.org ([198.145.29.99]:59912 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726904AbgGYRV1 (ORCPT ); Sat, 25 Jul 2020 13:21:27 -0400 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id B012A206D8; Sat, 25 Jul 2020 17:21:26 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1595697687; bh=Rteg0/PtsTehHLQ/ZXCZ6zO53UN+mrJQNeQDprdEaOs=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=x90CcWVOFR0mAI7+jp3d5kwU6PyHqj0Ewfq4evGmICrUkHABME96x452iXB5gy26Y y5OXtbylWE+Gy04JXx/plhItOwYnqOoxyqE/BufC1pKTdFZjUEQFCppOc2HPR4g6rt XdNMdIldldD5AeXFrdcPoG/4lCP0R4bZkmBzU9gg= Date: Sat, 25 Jul 2020 19:21:24 +0200 From: Greg KH To: John Oldman Cc: devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org, gustavo@embeddedor.com Subject: Re: [PATCH V3] staging: rtl8723bs: core: Using comparison to true is error prone Message-ID: <20200725172124.GB405510@kroah.com> References: <20200725143712.16667-1-john.oldman@polehill.co.uk> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200725143712.16667-1-john.oldman@polehill.co.uk> Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sat, Jul 25, 2020 at 03:37:12PM +0100, John Oldman wrote: > clear below issues reported by checkpatch.pl: > > CHECK: Using comparison to true is error prone Again, you did more than just this in the patch :(