Received: by 2002:a25:e74b:0:0:0:0:0 with SMTP id e72csp3090710ybh; Sat, 25 Jul 2020 10:37:23 -0700 (PDT) X-Google-Smtp-Source: ABdhPJw8MIkSWBues9mwHVOVGjyeIcr036WDB1wUTsewHQERsXy55eyaoPzh5A2dSqM94NN1zB44 X-Received: by 2002:a17:906:7a16:: with SMTP id d22mr360136ejo.478.1595698643034; Sat, 25 Jul 2020 10:37:23 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1595698643; cv=none; d=google.com; s=arc-20160816; b=XKdqbLJ+VeHd5TQk+sXUdqXoPijnc2E5h/f19yuh3kL6uBcyDsAQYzeZA4BEaIBhBV NxpuDTW6D7W9zzVwbvcOFV28bMbcZXoPm467eh9KgMoIaQSTXqO9QQcbi0rSxUgCw9U8 IQkPuIgvOBFvvNQ+DVmorAiO443j+XnOJl4yH97DAXRQ9hpRn4EMHwRj9+kOJ1mICnJe xrmcJC4ig87ejvlzDYeMKVELMwcGorolnf4bxhUYI9GtEvVcjWAdSSDry/0SVWsARNeT KFzq0mtngi/qRqeigY16YUV9+ynkMn3Rw2Ytwa3O1Zctj66TPzMSQKbfNb1Z4tzj+Nbb 6hFQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date; bh=p9lkYFFsRZWNRJenZUNOSyG0WjS2UTM88JEofIAtS7I=; b=hFFDMs+aEqASKGdSBUSsaSfi48goAsxd+pEY5uwMaC1Y+W6c/cjc2EtNCrzOmR0nzr 5RYGjUHjcMPxqcG8beLB6DqJQqksO33x2CZBjlkQ9/xKpWUi+iY74XzyyHRvaM4v+5Vn uoFvuT35jaDQa9nUkj4RL4+R8+6DADgXT7YZtDWOw8YvvjlD/HtHf/e16BDBy/HrY2Z6 lrXG/qkThtsoT/r5AXVsSHX8S39vVkEF47/goFuEe9fvBUAHvFeO0wwQiz0RY4d8ZCJW Yrp/XWcs5GP3ui+/HOrjnAMR7uubx1qQclFD93J/8y3yPQmeJJQADsBoPJoYXIgea3hQ CTmg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id ca11si2556554ejb.252.2020.07.25.10.37.00; Sat, 25 Jul 2020 10:37:23 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727846AbgGYRgJ (ORCPT + 99 others); Sat, 25 Jul 2020 13:36:09 -0400 Received: from mailomta28-sa.btinternet.com ([213.120.69.34]:24279 "EHLO sa-prd-fep-046.btinternet.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1726904AbgGYRgI (ORCPT ); Sat, 25 Jul 2020 13:36:08 -0400 Received: from sa-prd-rgout-005.btmx-prd.synchronoss.net ([10.2.38.8]) by sa-prd-fep-046.btinternet.com with ESMTP id <20200725173607.FDNZ4114.sa-prd-fep-046.btinternet.com@sa-prd-rgout-005.btmx-prd.synchronoss.net>; Sat, 25 Jul 2020 18:36:07 +0100 Authentication-Results: btinternet.com; auth=pass (LOGIN) smtp.auth=j.oldman998@btinternet.com X-Originating-IP: [86.152.161.91] X-OWM-Source-IP: 86.152.161.91 (GB) X-OWM-Env-Sender: j.oldman998@btinternet.com X-VadeSecure-score: verdict=clean score=0/300, class=clean X-RazorGate-Vade: gggruggvucftvghtrhhoucdtuddrgeduiedrheehgdduudehucetufdoteggodetrfdotffvucfrrhhofhhilhgvmecuueftkffvkffujffvgffngfevqffopdfqfgfvnecuuegrihhlohhuthemuceftddunecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenucfjughrpeffhffvuffkfhggtggujggfsehttdertddtredvnecuhfhrohhmpedfoeflohhhnhcuqfhlughmrghnqedfuceojhhohhhnrdholhgumhgrnhesphholhgvhhhilhhlrdgtohdruhhkqeenucggtffrrghtthgvrhhnpeffveekffekffefhfevvdevieelvdduuedvteeviefgteetfeffffekieduieekveenucfkphepkeeirdduhedvrdduiedurdeludenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhephhgvlhhopehhvghnrhihpdhinhgvthepkeeirdduhedvrdduiedurdeluddpmhgrihhlfhhrohhmpeeojhhohhhnrdholhgumhgrnhesphholhgvhhhilhhlrdgtohdruhhkqedprhgtphhtthhopeeouggvvhgvlhesughrihhvvghruggvvhdrohhsuhhoshhlrdhorhhgqedprhgtphhtthhopeeoghhrvghgkhhhsehlihhnuhigfhhouhhnuggrthhiohhnrdhorhhgqedprhgtphhtthhopeeoghhushhtrghvohesvghmsggvugguvgguohhrrdgtohhmqedprhgtphhtthhopeeolhhinhhugidqkhgvrhhnvghlsehvghgvrhdrkhgvrhhnvghlrdhorhhgqe X-RazorGate-Vade-Verdict: clean 0 X-RazorGate-Vade-Classification: clean Received: from henry (86.152.161.91) by sa-prd-rgout-005.btmx-prd.synchronoss.net (5.8.340) (authenticated as j.oldman998@btinternet.com) id 5ED9B8A708925B5B; Sat, 25 Jul 2020 18:36:06 +0100 Date: Sat, 25 Jul 2020 18:36:05 +0100 From: "" To: Greg KH Cc: devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org, gustavo@embeddedor.com Subject: Re: [PATCH V3] staging: rtl8723bs: core: Using comparison to true is error prone Message-ID: <20200725173605.GA16980@henry> References: <20200725143712.16667-1-john.oldman@polehill.co.uk> <20200725172124.GB405510@kroah.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200725172124.GB405510@kroah.com> User-Agent: Mutt/1.9.4 (2018-02-28) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sat, Jul 25, 2020 at 07:21:24PM +0200, Greg KH wrote: > On Sat, Jul 25, 2020 at 03:37:12PM +0100, John Oldman wrote: > > clear below issues reported by checkpatch.pl: > > > > CHECK: Using comparison to true is error prone > > Again, you did more than just this in the patch :( do you mean by reducing line lengths??