Received: by 2002:a25:ca44:0:0:0:0:0 with SMTP id a65csp111681ybg; Sat, 25 Jul 2020 22:09:42 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxtN+DD9mWmYJKuXoKyNV+2LkMtc6q2PIUPbDpgndS69cUOLwJFRIKGRcnrsw+r2us8Q0au X-Received: by 2002:aa7:dcc8:: with SMTP id w8mr16324254edu.305.1595740182086; Sat, 25 Jul 2020 22:09:42 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1595740182; cv=none; d=google.com; s=arc-20160816; b=RTq3qTYr6UEUYmsYIr2F9ZcaBRQ9qaOYxEvliNZhHMiHCRy2HoFo+ZhbQKQgnt0Yt8 dkOUkCNIKRAzLmVaC5ejer9BuSz7cLDOJsj5D0a4uWtxLNM1562b9MRsYQl+CiR+upGn TJkwRBk9SyqIj2MDX8o3lLLkwQZsiUN25s6fgsA+Exx4QoLWXWgNZ9ZKVEjLGIhdrgLn sdI1fK2V0d+MQdypEqvEboy4RQ5/281RbZceXqosN16ShugfC+j6FTs8AmAcLvbfkqhK /tIr04YQ0dc/eV9alZmFdJndQ1qNIV6mwkjCGTmWFZCidctUcSDFx95G0rsDDRCmIPu0 tMQw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:message-id:date:subject:to:from :dkim-signature; bh=4fBbTXl0es9SI3RqVvzZLJMaeaB5Sye+SLS57bBCWEQ=; b=Tr93vS7svxKtthZbMpgNXhKnomWkfbnFHq5ygw2YfpKhk1CNJPQTmNRKUlzjNyqPwQ P4q99Bt8vnxT6K70EWU+ejGOEJqNJvxyw8q/R2EyK8iRQHb0jCKr6W4Sv6zAr4Eai+Y8 liTkH6fYx0SABxyU5zK0bhTMkHmSe9g5oFUzXP7LOAH4s7Nrm15MTsiio91pbfggm16N Pdmg3Bc9XTj/pNXytnZ5XUBqx4gp/d9l6U1eYttmxtUBqGirkSr9IJz/p1DQkt0Rs00B 0dVLISz7U3Xz7MKt/1nVBOwzPxuuBtuBAPAnethWhjcSzUkkc+ztUnfaO7j4QRhF95eL c0sg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=gEa1dPIS; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id bs1si3819791edb.418.2020.07.25.22.09.03; Sat, 25 Jul 2020 22:09:42 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=gEa1dPIS; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1725810AbgGZFHY (ORCPT + 99 others); Sun, 26 Jul 2020 01:07:24 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:38536 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725298AbgGZFHX (ORCPT ); Sun, 26 Jul 2020 01:07:23 -0400 Received: from mail-qt1-x835.google.com (mail-qt1-x835.google.com [IPv6:2607:f8b0:4864:20::835]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id A088BC0619D2; Sat, 25 Jul 2020 22:07:23 -0700 (PDT) Received: by mail-qt1-x835.google.com with SMTP id b25so9919550qto.2; Sat, 25 Jul 2020 22:07:23 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:subject:date:message-id; bh=4fBbTXl0es9SI3RqVvzZLJMaeaB5Sye+SLS57bBCWEQ=; b=gEa1dPISUTZ4vnR9iujU0mYuDOKP6FYT5i36LpU2njvmiEJJuY96e28Jcn7jXLQLuv FU+1J6h4PvCEZlz/HYlsevsMABM2Ob/QQq8OSBC3Oj+rSOSl2Tfx6u6hMWWa4lr7coFV E5UgQLcBPJ2VCIbs+F5uiAPo0dxZtOQDQDccDP9DKlgRDrfOmls2lCJ/Gu8OU/sC5gO/ 43jSFsQRrg2RxQUolhHvvoKN0ZBMrYO4EBQUnlD45ga3ZurPYXE/UzdCV2vy4nmPDv5e VTwtbdGAif7CCsrBp0FSagPrxQv8cMjCy8mHPVmyD0DPDEMtVQrqdmgHqEobN+xGQ7QB Uu4Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:subject:date:message-id; bh=4fBbTXl0es9SI3RqVvzZLJMaeaB5Sye+SLS57bBCWEQ=; b=XqcURIVPtXsAZQzyUFn8q4s9toOGzoa4U4Hf8yreIctKfqWrj9DCJPgPIp+7ObiU4o jXvBTANP9FZO/zdi5bak0/VOhai61HovPRcoNjLoCraspkQdE5XDdyoZS03SZzh6QI1y d/Sk2Mw6jD5cEzBLKOrbXCnvebRP+yQmMj8oBaziEOoMdT0wGbyhJIMOtm2dAK5/6CEp f8de4gnV8IvDQcOeICbfe6ZEM2yz0eygbo5ZV6FzFoPgYd1Bb5HS9JKW6ALSb4CR1Re0 Ffpdwf8rgvYR7md4/qEKjlKpKtkzL2gGGFyk0LQy5TCDOq/3FPHjmNJoHQroxkq2v9sp SOfw== X-Gm-Message-State: AOAM531URVwzD95Fl9ufOw/xwv7Gocglo7BUzNHAi1UfSvnXiKC+H/mx yjSKTWsgRPQdLfZSQNmJ9vMZVioWwJ9pkA== X-Received: by 2002:aed:3947:: with SMTP id l65mr3946373qte.374.1595740042255; Sat, 25 Jul 2020 22:07:22 -0700 (PDT) Received: from linux.home ([2604:2000:1344:41d:159c:94c1:6e96:1b7e]) by smtp.googlemail.com with ESMTPSA id t127sm13031881qkc.100.2020.07.25.22.07.20 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 25 Jul 2020 22:07:21 -0700 (PDT) From: Gaurav Singh To: gaurav1086@gmail.com, Bartlomiej Zolnierkiewicz , Daniel Vetter , Qiujun Huang , Sam Ravnborg , Geert Uytterhoeven , Peter Rosin , Nathan Chancellor , dri-devel@lists.freedesktop.org (open list:FRAMEBUFFER LAYER), linux-fbdev@vger.kernel.org (open list:FRAMEBUFFER LAYER), linux-kernel@vger.kernel.org (open list) Subject: [PATCH] [video/fbdev] fb_flashcursor: Remove redundant null check Date: Sun, 26 Jul 2020 01:07:00 -0400 Message-Id: <20200726050713.9461-1-gaurav1086@gmail.com> X-Mailer: git-send-email 2.17.1 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org ops cannot be NULL as its being accessed later without checks. Remove the redundant NULL check. Signed-off-by: Gaurav Singh --- drivers/video/fbdev/core/fbcon.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/video/fbdev/core/fbcon.c b/drivers/video/fbdev/core/fbcon.c index e2a490c5ae08..9551f40c6d14 100644 --- a/drivers/video/fbdev/core/fbcon.c +++ b/drivers/video/fbdev/core/fbcon.c @@ -401,7 +401,7 @@ static void fb_flashcursor(struct work_struct *work) if (ret == 0) return; - if (ops && ops->currcon != -1) + if (ops->currcon != -1) vc = vc_cons[ops->currcon].d; if (!vc || !con_is_visible(vc) || -- 2.17.1