Received: by 2002:a25:ca44:0:0:0:0:0 with SMTP id a65csp195809ybg; Sun, 26 Jul 2020 01:27:41 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwxtbu7Q6UhkYusAvjknc2lzDGsDtxbAcOBYF98hK+6M2kNL0LQR0GtIGrWsdpAvrZgklWi X-Received: by 2002:a05:6402:13d0:: with SMTP id a16mr16226878edx.269.1595752061101; Sun, 26 Jul 2020 01:27:41 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1595752061; cv=none; d=google.com; s=arc-20160816; b=Nmc5eVSL+kGNQVaqMLoEbYIxRMCnm2dt3R4SXYS5W8pqrOBoV1pCDVIc0NkNqcWtjv +ziQiXw5U3+WH4zIM6uY419a9rsLkQWgwBdoHpDNeotmyGe9698asV1zyCMxRifD5vje TSgnf1AhcEthcuQnFMn+wdiW6R3Ekcu0iBD0rMpymmGwPgnz9yhNVYC1RfU8du3LeN1d M/G0gkYVN9Agq0ac62Q5QenxrxXNMTFhmHDGqOT5YYT2yVMyMnxYzE/2G/9XimgB3R1H W3ScFDZ94gdsPOvi+/UEnpafKbVLIKBoG95nxCLwViAxbilMO5jPMLKJ5xLmpSZISddW mqtg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:in-reply-to:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :dkim-signature; bh=5eaA/b6SbyStsSAuXSGhQausRCCsXoKCl8z2NyQZdBk=; b=EngurotoLVSBufzZyHSnGPbL6YrI+Kp8ruVZPC4WKiam89uk1GiOtlrpm+3iW0pA94 A/Jv2iisOiOZnfllXa49ETlqzIaRPh16mnh52esdjc3rDbCwTs2fWyMdZzoo5q52dEMv Mi01oB28P1kyuCFLVrM87PVLPc4VuU3rKjKTupiVQRXWA5x5nF+emcMSPpmfBqvoDZ7E Vx2wQ/sC8omgpPtPcAlNFmMmI7EABqUHRs7cwtxzTJQPaI+qycBxSAluygCgYJ+j4gA/ VePW9novnx+ede8/CEhfSH7GRSWKCx6IQtGWcjP2WC2eAasx1okQARKpGyfFagWxEmUg KtQg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=DlkvWHEm; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id p32si3957004edd.55.2020.07.26.01.27.17; Sun, 26 Jul 2020 01:27:41 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=DlkvWHEm; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726826AbgGZI0k (ORCPT + 99 others); Sun, 26 Jul 2020 04:26:40 -0400 Received: from mail.kernel.org ([198.145.29.99]:47238 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725794AbgGZI0k (ORCPT ); Sun, 26 Jul 2020 04:26:40 -0400 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 3F29E206F6; Sun, 26 Jul 2020 08:26:38 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1595751998; bh=+uk7MIIMPHgiZ/Vvk6Ik8YDGvxAcPrqQ5e2EgEoj2w4=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=DlkvWHEm2ut0XyRhMxCTFTHz9gNwFUG/DlNUO5f5kYbij/7FmUpn5WRyl5HM7Ecb1 EVUbSCbn6cweIcTxCAqhvV3d2Ba6DM5HJkdUM4Hdj7rDE+q77gpqQlPzh5FhJ2WtZr n90JshAE4sA1aPKtXYBr9qnwLR6YaQS3kt2GBW+k= Date: Sun, 26 Jul 2020 10:26:36 +0200 From: Greg KH To: Aditya Jain Cc: devel@driverdev.osuosl.org, hdegoede@redhat.com, linux-kernel@vger.kernel.org, Larry.Finger@lwfinger.net Subject: Re: [PATCH] staging: rtl8723bs: include: Fix coding style errors Message-ID: <20200726082636.GA447282@kroah.com> References: <20200726080215.41501-1-aditya.jainadityajain.jain@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200726080215.41501-1-aditya.jainadityajain.jain@gmail.com> Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sun, Jul 26, 2020 at 01:32:15PM +0530, Aditya Jain wrote: > Fixing ERROR: "foo * bar" should be "foo *bar" in hal_phy_cfg.h > as reported by checkpatch.pl > > Signed-off-by: Aditya Jain > --- > .../staging/rtl8723bs/include/hal_phy_cfg.h | 18 +++++++++--------- > 1 file changed, 9 insertions(+), 9 deletions(-) > > diff --git a/drivers/staging/rtl8723bs/include/hal_phy_cfg.h b/drivers/staging/rtl8723bs/include/hal_phy_cfg.h > index 419ddb0733aa..fd5f377bad4f 100644 > --- a/drivers/staging/rtl8723bs/include/hal_phy_cfg.h > +++ b/drivers/staging/rtl8723bs/include/hal_phy_cfg.h > @@ -42,7 +42,7 @@ u32 Data > > u32 > PHY_QueryRFReg_8723B( > -struct adapter * Adapter, > +struct adapter *Adapter, > u8 eRFPath, > u32 RegAddr, > u32 BitMask Ick, these are all horrid. How about just making these all on a single line like most functions have them instead of this one cleanup? Same for the other changes you made in this file. thanks, greg k-h