Date: Wed, 10 May 2006 16:00:54 -0700
From: Mike Kravetz <kravetz@us.ibm.com>
To: Andrew Morton <akpm@osdl.org>, Arnd Bergmann <arnd.bergmann@de.ibm.com>
Cc: penberg@cs.Helsinki.FI, clameter@sgi.com, haveblue@us.ibm.com,
       linux-kernel@vger.kernel.org
Subject: Re: [PATCH] add slab_is_available() routine for boot code
Message-ID: <20060510230054.GA11214@w-mikek2.ibm.com>
References: <20060510205543.GI3198@w-mikek2.ibm.com> <20060510155026.173c57a1.akpm@osdl.org>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20060510155026.173c57a1.akpm@osdl.org>
User-Agent: Mutt/1.4.2.1i
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1161
Lines: 27

On Wed, May 10, 2006 at 03:50:26PM -0700, Andrew Morton wrote:
> Mike Kravetz <kravetz@us.ibm.com> wrote:
> > diff -Naupr linux-2.6.17-rc3-mm1/mm/sparse.c linux-2.6.17-rc3-mm1.work3/mm/sparse.c
> > --- linux-2.6.17-rc3-mm1/mm/sparse.c	2006-05-03 22:19:16.000000000 +0000
> > +++ linux-2.6.17-rc3-mm1.work3/mm/sparse.c	2006-05-10 19:15:56.000000000 +0000
> > @@ -32,7 +32,7 @@ static struct mem_section *sparse_index_
> >  	unsigned long array_size = SECTIONS_PER_ROOT *
> >  				   sizeof(struct mem_section);
> >  
> > -	if (system_state == SYSTEM_RUNNING)
> > +	if (slab_is_available())
> >  		section = kmalloc_node(array_size, GFP_KERNEL, nid);
> >  	else
> >  		section = alloc_bootmem_node(NODE_DATA(nid), array_size);
> 
> Is this a needed-for-2.6.17 fix?

I'll let Arnd answer.  He ran into this when doing some Cell work.  Not
sure where in the development cycle the code is that exposes this bug.

-- 
Mike
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/