Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Sun, 26 Jul 2020 15:35:51 +0200
From:   Wolfram Sang <wsa@kernel.org>
To:     Alain Volmat <alain.volmat@st.com>
Cc:     pierre-yves.mordret@st.com, alexandre.torgue@st.com,
        linux-i2c@vger.kernel.org,
        linux-stm32@st-md-mailman.stormreply.com,
        linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org,
        fabrice.gasnier@st.com
Subject: Re: [PATCH v2 1/2] i2c: smbus: add core function handling SMBus
 host-notify
Message-ID: <20200726133551.GC16169@ninjato>
References: <1593776168-17867-1-git-send-email-alain.volmat@st.com>
 <1593776168-17867-2-git-send-email-alain.volmat@st.com>
 <20200725202733.GA946@kunai>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
        protocol="application/pgp-signature"; boundary="DSayHWYpDlRfCAAQ"
Content-Disposition: inline
In-Reply-To: <20200725202733.GA946@kunai>
User-Agent: Mutt/1.10.1 (2018-07-13)
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk


--DSayHWYpDlRfCAAQ
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable


> > +void i2c_free_slave_host_notify_device(struct i2c_client *client)
> > +{
> > +	i2c_slave_unregister(client);
> > +	kfree(client->dev.platform_data);
> > +	i2c_unregister_device(client);
> > +}
> > +EXPORT_SYMBOL_GPL(i2c_free_slave_host_notify_device);
>=20
> Sidenote: With my recent series "i2c: slave: improve sanity checks when
> un-/registering" this code became NULL-safe (and IS_ERR safe, too).

Stupid me, it is not NULL safe. The functions are. But, we deregister
'client' on our own. It probably makes sense to add some sanity checking
of the parameters of the exported functions.


--DSayHWYpDlRfCAAQ
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQIzBAABCgAdFiEEOZGx6rniZ1Gk92RdFA3kzBSgKbYFAl8dhrMACgkQFA3kzBSg
KbbyGxAAqCXGbq/i0jvy+gmv+JJk5HTVXYtglHm52P7iDw0zolpXRm0OEmF4+yRt
4MmbRDeEeQLeR2TvtaziN1q+LNQ2CObxbbVoyjcgNuc9pyo/zoM4No2JNnFqKWUt
k5gl0nzVKXIlmJy2zb0EJT/xoyX+rae4hamgve7t3TvdQC3DS+sFJcReM9AmmMtN
XHdPkrSbwHUhEUfDzmKw63CJZ46ExLmM03Ev08nkxW6YDkpZJeLMmloL54e8aVz7
KEYKO24PUZ4/fzgtvHK7H1baBmALgIn4sR2R6UqgIDE0BDGKP9a6XXUz2S+ZDuja
vmJXZYwwKMgNPjFN5vFku1vxLUQRTNnQGy3cjX0PYW9AVMFcqLt7AOR7qHzNCZv7
t0MFewm19NOJMztPP+iLDPVOTACbuinF9NK4DptHwiBlEF2CIRYmBifJyLFjERW1
Q/S6T1k7u9EQ7ya9Rc6J8j9qk3GU9q6xU6DJtGlMGM94MvqNwdOrhzN9ysrJso7U
tvfiv2lw0yDkQysl1QgtR68xpI2PLBZwahv5t+11M/7A14bd4LAWr+6kZ7Oc8G08
GeCpGIu1Ja1rMV/zPptp4IrxC1BA5GyVYaX6n01B59mK5GZMorzASUv18thLWNtq
k64ubcie8Ka+C6YNvNPe9hs3egA3En5BHIXrZJidbM11PhZjY34=
=AW42
-----END PGP SIGNATURE-----

--DSayHWYpDlRfCAAQ--