Received: by 2002:a25:ca44:0:0:0:0:0 with SMTP id a65csp399772ybg; Sun, 26 Jul 2020 08:08:43 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzHz2cDG+/R8z/Iry0k7VyTknxQ79XcTMZoh7MaImeVFpQnN1IfGm2jenn0P0pmOYVtxbGq X-Received: by 2002:a17:906:3e4f:: with SMTP id t15mr3443523eji.368.1595776123443; Sun, 26 Jul 2020 08:08:43 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1595776123; cv=none; d=google.com; s=arc-20160816; b=WI6iyvQXYjNW/BmaF+VivN6C6q0/zRSSCKKON25BN2MHDCDoJBbhqoWQ8cOebwept9 d0LxeK0/05L8SMz+gMMP8sv0aXN5vguzo53Vq1oIGOnCRkJl1gICMA/kxIX1V52I+2b7 0Vpv3wOUzTo4yJFkklhdn3oooaHXArU1jXF9NYC1e+FZyEVHSxthU4dmzWjbxB+V2ulK gNFFm/lrezGSvTHR9MPmi0CVV0Gc4Jl0BhD6BQ7BAe3jOIpfhU/1FvZCiHeAddLFOKu2 ygGsWbNQgU3jw8cXpheDCNnCmZPNytHMtIuDqauYX+aMkNt/gzA553GhMWFmjW/5NnaY /1tA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=7sLr773opB4TCq8qFsHUwDVwSWroJwloCS8BnU42JTo=; b=I9TKD3RbZpZ9KtC9lXuxasMLcWlqHH137/gk4S+0DgRWWENwefo5TYCmwgJsZr6VQw 0P7Z3edS1hlWpwfrsLy9so/nYY1uIPFhWJ6Bwa/opvPhxcGVY5ZMRWYCixCXlwfK1bdA EcBkxA/7n8RMdNCWqhgfD5uOX3/HVcnphd07qGb6qqrdwWUCYk3yUymjYxUbd+xCnAk+ b01ABQsVaOebJ99K+26Cq/tMseonPvlbHw053Ov++yWHCTmQHxXD9YUGcTKH+7GKuuVU /PMjmxsYYaK8tm++HxqZClw0ln7FRfDIbLa2rHMcT5W+Q3ly61X11b6hEzKhQWPyHIBf p0KA== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail header.i=@infradead.org header.s=casper.20170209 header.b=nzfTTc0U; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id rp11si3845333ejb.280.2020.07.26.08.08.21; Sun, 26 Jul 2020 08:08:43 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=fail header.i=@infradead.org header.s=casper.20170209 header.b=nzfTTc0U; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726760AbgGZPDt (ORCPT + 99 others); Sun, 26 Jul 2020 11:03:49 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:47318 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725978AbgGZPDt (ORCPT ); Sun, 26 Jul 2020 11:03:49 -0400 Received: from casper.infradead.org (casper.infradead.org [IPv6:2001:8b0:10b:1236::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id EABB8C0619D2; Sun, 26 Jul 2020 08:03:48 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=Content-Transfer-Encoding:MIME-Version: References:In-Reply-To:Message-Id:Date:Subject:Cc:To:From:Sender:Reply-To: Content-Type:Content-ID:Content-Description; bh=7sLr773opB4TCq8qFsHUwDVwSWroJwloCS8BnU42JTo=; b=nzfTTc0USVN6e4AgohXkVVBtnB ao8yENWY5PaMchxhF88PqoEDZtsOvvDBfsVqL5hxXs1TfPKZsT0QKdC04koNuyIqUVWff6t7WpMsO 6ROQmy7Z3SuqIBiB5MY/GlauBE2dCXtfkRYHkWeVcikSjYbCzVU2/9edWtltJgwhQPO8y9ky/Xq/n Dq60znZ4ygSsHIMpgg0I35t1JLX8qrL50CEXCilpvkDH9ZQuY5bE4HRktCNPrXIuHlRbKpJ2f0ipn dC9zHgaHUxCnVaVQ4ZdLhkeU0PuMsURYlqj8BSpk8D6OEOUCXOpRijEYlhL5KzDLJWB3Oi9DhpYgb NRdWrmvQ==; Received: from [2001:4bb8:18c:2acc:2375:88ff:9f84:118d] (helo=localhost) by casper.infradead.org with esmtpsa (Exim 4.92.3 #3 (Red Hat Linux)) id 1jziBe-0005fc-UA; Sun, 26 Jul 2020 15:03:39 +0000 From: Christoph Hellwig To: Jens Axboe Cc: Song Liu , Hans de Goede , Richard Weinberger , Minchan Kim , linux-mtd@lists.infradead.org, dm-devel@redhat.com, linux-block@vger.kernel.org, linux-kernel@vger.kernel.org, drbd-dev@lists.linbit.com, linux-raid@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, cgroups@vger.kernel.org Subject: [PATCH 02/14] drbd: remove dead code in device_to_statistics Date: Sun, 26 Jul 2020 17:03:21 +0200 Message-Id: <20200726150333.305527-3-hch@lst.de> X-Mailer: git-send-email 2.27.0 In-Reply-To: <20200726150333.305527-1-hch@lst.de> References: <20200726150333.305527-1-hch@lst.de> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-SRS-Rewrite: SMTP reverse-path rewritten from by casper.infradead.org. See http://www.infradead.org/rpr.html Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Ever since the switch to blk-mq, a lower device not used for VM writeback will not be marked congested, so the check will never trigger. Signed-off-by: Christoph Hellwig --- drivers/block/drbd/drbd_nl.c | 6 ------ 1 file changed, 6 deletions(-) diff --git a/drivers/block/drbd/drbd_nl.c b/drivers/block/drbd/drbd_nl.c index d0d9a549b58388..650372ee2c7822 100644 --- a/drivers/block/drbd/drbd_nl.c +++ b/drivers/block/drbd/drbd_nl.c @@ -3370,7 +3370,6 @@ static void device_to_statistics(struct device_statistics *s, if (get_ldev(device)) { struct drbd_md *md = &device->ldev->md; u64 *history_uuids = (u64 *)s->history_uuids; - struct request_queue *q; int n; spin_lock_irq(&md->uuid_lock); @@ -3384,11 +3383,6 @@ static void device_to_statistics(struct device_statistics *s, spin_unlock_irq(&md->uuid_lock); s->dev_disk_flags = md->flags; - q = bdev_get_queue(device->ldev->backing_bdev); - s->dev_lower_blocked = - bdi_congested(q->backing_dev_info, - (1 << WB_async_congested) | - (1 << WB_sync_congested)); put_ldev(device); } s->dev_size = drbd_get_capacity(device->this_bdev); -- 2.27.0