Received: by 2002:a25:ca44:0:0:0:0:0 with SMTP id a65csp497971ybg; Sun, 26 Jul 2020 11:12:14 -0700 (PDT) X-Google-Smtp-Source: ABdhPJytvQbnolzOSDF02fsGPIRoFSRLsPNIqmC0wqH+IfvTvzhDUxQ+5gF8CILwfQrGtOVx8I7E X-Received: by 2002:a05:6402:1c10:: with SMTP id ck16mr18379673edb.72.1595787134395; Sun, 26 Jul 2020 11:12:14 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1595787134; cv=none; d=google.com; s=arc-20160816; b=J8x2G+Bq6QtIB2jjcJOwDdWCGd1dYMlRM5AGsKJLIaFOBOnunQU1utlbJGWuQ/EIbP yQX0l740qJwIdIy5AETIz4fEHf2Yk4ynbo/g4lHrLlTAiTdfNXXBTpTTjfIxGZHptZl2 JckMR8DwivGFQzO/Myl5KlX5HN5AZbZw+jqvo0Ut5gR5WXw2+GQawbU8r5bssY6Dnyxn /MvtnE6jjE0jwaakKYqF8kBIBv1+cQ+hbTZIfUbEk4pd0/SaJlLUaaoPcMWx7MpidA+y m4uUVGuNie6Qr+XEMCExBbmsFO2GJ0rSMDO+ZVdCh2nRktQTo3KixNmCoaHyPw+oAjqC un/A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:mime-version:user-agent:message-id :in-reply-to:date:references:subject:cc:to:from:dmarc-filter :dkim-signature; bh=dkeTWaUqQPIijBo2b2trYUH4UirL83EHI+atIYwWFzE=; b=I+WEAeExTzVzr2rhr3Y19WdQWXENgGdxfs3LOjJ0XcKOdDwtJAULT/4e8x42x8CvVP 5HQC2flCAvaFZql8Gk/boOI/lbanB5OHo3gioH2dmn1WIpZ808+Ha3dSOVAiT+ZyRgjS 7NdN+mYNsMvAlk+SpQ7r8B8VTih9mPSD2L5cTEphUTikc3AcdCBx1FHTeREZusHJo8L/ tm8j0pFC0XzS0iBBaYxlFRDQccWIGe/yg8KZwpNjkCfbfaoTsZ5tViykQS1kMS2meqa2 /izX0GpoUDjH85Ps7wFV7qP2U6UBqiSribvy8eQT4lf0Wql1amBpEKTgzIT7KxNobGyg Z7ZA== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail header.i=@mg.codeaurora.org header.s=smtp header.b=XH1cbqhw; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id i5si2149421edn.13.2020.07.26.11.11.53; Sun, 26 Jul 2020 11:12:14 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=fail header.i=@mg.codeaurora.org header.s=smtp header.b=XH1cbqhw; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726821AbgGZSLc (ORCPT + 99 others); Sun, 26 Jul 2020 14:11:32 -0400 Received: from mail29.static.mailgun.info ([104.130.122.29]:42117 "EHLO mail29.static.mailgun.info" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725972AbgGZSLc (ORCPT ); Sun, 26 Jul 2020 14:11:32 -0400 DKIM-Signature: a=rsa-sha256; v=1; c=relaxed/relaxed; d=mg.codeaurora.org; q=dns/txt; s=smtp; t=1595787091; h=Content-Type: MIME-Version: Message-ID: In-Reply-To: Date: References: Subject: Cc: To: From: Sender; bh=dkeTWaUqQPIijBo2b2trYUH4UirL83EHI+atIYwWFzE=; b=XH1cbqhw7zeavxrPibQdPDcHohoAhDxJ778jspNtqLvqznoBhaLsRIGnFivHWZ+hGQElOnWB kPn9W6ayjpmSTmaUhmSv/Bu7rHjIB8yh5BOSmg/qOhGWo1HI26ZRN3G9caGZkZQWlwMB9lKn OvRxP54+nXPsjrBiXuFnF7rmecY= X-Mailgun-Sending-Ip: 104.130.122.29 X-Mailgun-Sid: WyI0MWYwYSIsICJsaW51eC1rZXJuZWxAdmdlci5rZXJuZWwub3JnIiwgImJlOWU0YSJd Received: from smtp.codeaurora.org (ec2-35-166-182-171.us-west-2.compute.amazonaws.com [35.166.182.171]) by smtp-out-n11.prod.us-west-2.postgun.com with SMTP id 5f1dc75235f3e3d3168ebeff (version=TLS1.2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256); Sun, 26 Jul 2020 18:11:30 GMT Received: by smtp.codeaurora.org (Postfix, from userid 1001) id C6F6FC43391; Sun, 26 Jul 2020 18:11:30 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-caf-mail-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.0 required=2.0 tests=ALL_TRUSTED,SPF_NONE autolearn=unavailable autolearn_force=no version=3.4.0 Received: from potku.adurom.net (88-114-240-156.elisa-laajakaista.fi [88.114.240.156]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) (Authenticated sender: kvalo) by smtp.codeaurora.org (Postfix) with ESMTPSA id 09F83C433C9; Sun, 26 Jul 2020 18:11:27 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 smtp.codeaurora.org 09F83C433C9 Authentication-Results: aws-us-west-2-caf-mail-1.web.codeaurora.org; dmarc=none (p=none dis=none) header.from=codeaurora.org Authentication-Results: aws-us-west-2-caf-mail-1.web.codeaurora.org; spf=none smtp.mailfrom=kvalo@codeaurora.org From: Kalle Valo To: Wolfram Sang Cc: linux-wireless@vger.kernel.org, Johannes Berg , Emmanuel Grumbach , Luca Coelho , Intel Linux Wireless , "David S. Miller" , Jakub Kicinski , netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [RFC PATCH] iwlwifi: yoyo: don't print failure if debug firmware is missing References: <20200625165210.14904-1-wsa@kernel.org> <20200726152642.GA913@ninjato> Date: Sun, 26 Jul 2020 21:11:25 +0300 In-Reply-To: <20200726152642.GA913@ninjato> (Wolfram Sang's message of "Sun, 26 Jul 2020 17:26:42 +0200") Message-ID: <87y2n6404y.fsf@codeaurora.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.5 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Wolfram Sang writes: > On Thu, Jun 25, 2020 at 06:52:10PM +0200, Wolfram Sang wrote: >> Missing this firmware is not fatal, my wifi card still works. Even more, >> I couldn't find any documentation what it is or where to get it. So, I >> don't think the users should be notified if it is missing. If you browse >> the net, you see the message is present is in quite some logs. Better >> remove it. >> >> Signed-off-by: Wolfram Sang >> --- > > Any input on this? Or people I should add to CC? This was discussed on another thread: https://lkml.kernel.org/r/87mu3magfp.fsf@tynnyri.adurom.net Unless Intel folks object I'm planning to take this to wireless-drivers-next. -- https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches