Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
IronPort-SDR: aXNxlDRhgzZvlvETaAY0Zy/dJIer17clw70YXl/rmE3/Su0R/oxPxOauEJNzBhqe3lc9GwZ6xX
 EPKzjVoD6M1A==
IronPort-SDR: ruCzwV8wfiVUS1iQhquK5wWU1uWCE4bxre3lUeTum1cZsdrDT6w0OrBXM/8rWVWRqvkaQNuggw
 8isKvTsgDLRA==
Subject: Re: [PATCHv2 2/2] perf tools: Fix term parsing for raw syntax
From:   "Jin, Yao" <yao.jin@linux.intel.com>
To:     Jiri Olsa <jolsa@kernel.org>,
        Arnaldo Carvalho de Melo <acme@kernel.org>
Cc:     lkml <linux-kernel@vger.kernel.org>,
        Ingo Molnar <mingo@kernel.org>,
        Namhyung Kim <namhyung@kernel.org>,
        Alexander Shishkin <alexander.shishkin@linux.intel.com>,
        Peter Zijlstra <a.p.zijlstra@chello.nl>,
        Michael Petlan <mpetlan@redhat.com>,
        Ian Rogers <irogers@google.com>,
        Stephane Eranian <eranian@google.com>,
        Andi Kleen <ak@linux.intel.com>,
        Thomas Richter <tmricht@linux.ibm.com>
References: <20200726075244.1191481-1-jolsa@kernel.org>
 <20200726075244.1191481-2-jolsa@kernel.org>
 <4d30edad-8df1-ac9d-c70d-9019935c4d4c@linux.intel.com>
Message-ID: <003c9419-4396-6ad6-b934-ec04bf9f8a63@linux.intel.com>
Date:   Mon, 27 Jul 2020 08:26:27 +0800
User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:68.0) Gecko/20100101
 Thunderbird/68.10.0
MIME-Version: 1.0
In-Reply-To: <4d30edad-8df1-ac9d-c70d-9019935c4d4c@linux.intel.com>
Content-Type: text/plain; charset=windows-1252; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: 8bit
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk


On 7/27/2020 8:21 AM, Jin, Yao wrote:
> 
> 
> On 7/26/2020 3:52 PM, Jiri Olsa wrote:
>> Jin Yao reported issue with possible conflict between raw
>> events and term values in pmu event syntax.
>>
>> Currently following syntax is resolved as raw event with
>> 0xead value:
>> ?? uncore_imc_free_running/read/
>>
>> instead of using 'read' term from uncore_imc_free_running pmu,
>> because 'read' is correct raw event syntax with 0xead value.
>>
>> To solve this issue we do following:
>> ?? - check existing terms during rXXXX syntax processing
>> ???? and make them priority in case of conflict
>> ?? - allow pmu/r0x1234/ syntax to be able to specify conflicting
>> ???? raw event (implemented in previous patch)
>>
>> Also adding automated tests for this and perf_pmu__parse_cleanup
>> call to parse_events_terms, so the test gets properly cleaned up.
>>
>> Reported-by: Jin Yao<yao.jin@linux.intel.com>
>> Signed-off-by: Jiri Olsa<jolsa@kernel.org>
>> ---
>> v2 changes:
>> ? - added comment to perf_pmu__test_parse_init
> 
> Acked-by: Jin Yao <yao.jin@linux.intel.com>
> 
> Thanks
> Jin Yao

Also added with:
Fixes: 3a6c51e4d66c ("perf parser: Add support to specify rXXX event with pmu")?

Thanks
Jin Yao