Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Mon, 27 Jul 2020 09:46:01 +0800
From:   Kent Gibson <warthog618@gmail.com>
To:     Linus Walleij <linus.walleij@linaro.org>
Cc:     "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "open list:GPIO SUBSYSTEM" <linux-gpio@vger.kernel.org>,
        Bartosz Golaszewski <bgolaszewski@baylibre.com>
Subject: Re: [PATCH v2 03/18] gpiolib: make cdev a build option
Message-ID: <20200727014601.GA10761@sol>
References: <20200725041955.9985-1-warthog618@gmail.com>
 <20200725041955.9985-4-warthog618@gmail.com>
 <CACRpkdZymmO9ku5OmCO74eiX3Y3jq_1g5De9Tx4hg3Lyrdt6bQ@mail.gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <CACRpkdZymmO9ku5OmCO74eiX3Y3jq_1g5De9Tx4hg3Lyrdt6bQ@mail.gmail.com>
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Mon, Jul 27, 2020 at 12:25:53AM +0200, Linus Walleij wrote:
> On Sat, Jul 25, 2020 at 6:21 AM Kent Gibson <warthog618@gmail.com> wrote:
> 
> > +config GPIO_CDEV
> > +       bool "/dev/gpiochipN (character device interface)"
> > +       default y
> 
> I don't want to make it too easy to do this, as I see it as a standard
> kernel feature.
> 
> Can we add:
> 
> depends on EXPERT
> 
> as with other standard kernel features?
> 

Fair enough.

But what of the GPIO_CDEV_V1 option to disable uAPI V1 added in patch 04,
and that depends on GPIO_CDEV?
That is equivalent to GPIO_SYSFS, which is not dependent on EXPERT,
so I'll need to restructure the dependencies so it doesn't
inherit the EXPERT dependency.
Unless you also want it to be dependent on EXPERT.

Hmmm, and maybe patch 04 should be later in the series - after V2 is
fully implemented and V1 is deprecated - around patch 11.

Cheers,
Kent.